From c9e8c4b38c0d633b9e288169f647bceebddda72f Mon Sep 17 00:00:00 2001
From: Harald Sitter <sitter@kde.org>
Date: Wed, 27 Apr 2016 15:29:54 +0200
Subject: [PATCH] warn about need for production data, skip tests that depend
 on them

numerous icon tests expect the actual production plasma theme to be present
it won't however be resolved because we disable qstandardpaths' default
fallbacks by switching it into testing mode. this ultimately means the
test run needs to have XDG_DATA_DIRS in the environment, if it doesn't
test data will not be present

furthermore QSKIP tests that depend on:
- hicolor icon theme to be present
- production plasma themes

this allows the entire test to pass in less than optimal environments by
means of skipping but also gives a reasonable hint as to why tests are
skipped in the first place. also moving forward if a test isn't guarded
we still have the warning about failure potential allowing someone to
quickly figure out why things failed

REVIEW: 127764
---
 autotests/iconitemtest.cpp | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/autotests/iconitemtest.cpp b/autotests/iconitemtest.cpp
index 0b55abdf1..bc97aaea5 100644
--- a/autotests/iconitemtest.cpp
+++ b/autotests/iconitemtest.cpp
@@ -47,6 +47,14 @@ static bool imageIsEmpty(const QImage &img)
 
 void IconItemTest::initTestCase()
 {
+    if (qgetenv("XDG_DATA_DIRS").isEmpty()) {
+        QWARN("\n"
+              "  !!!\n"
+              "  Switching QStandardPaths into testing mode.\n"
+              "  Make sure xdg data can be found or set XDG_DATA_DIRS.\n"
+              "  !!!\n");
+    }
+
     // make our theme in search path
     qputenv("XDG_DATA_DIRS",
             qgetenv("XDG_DATA_DIRS") + ":" + QFINDTESTDATA("data").toLocal8Bit());
@@ -219,6 +227,11 @@ void IconItemTest::usesPlasmaTheme()
 
 void IconItemTest::animation()
 {
+    if (!Plasma::Theme().themeName().startsWith("default")) {
+        // This this depends on the production default theme.
+        QSKIP("Current Plasma theme is not Breeze.");
+    }
+
     // animated = true (default)
     QQuickItem *item1 = createIconItem();
     item1->setProperty("source", "user-away");
@@ -246,6 +259,11 @@ void IconItemTest::animation()
 
 void IconItemTest::animationAfterHide()
 {
+    if (!Plasma::Theme().themeName().startsWith("default")) {
+        // This this depends on the production default theme.
+        QSKIP("Current Plasma theme is not Breeze.");
+    }
+
     QQuickItem *item1 = createIconItem();
     QQuickItem *item2 = createIconItem();
     item1->setProperty("source", "user-away");
@@ -268,6 +286,11 @@ void IconItemTest::animationAfterHide()
 
 void IconItemTest::bug_359388()
 {
+    if (!KIconTheme::list().contains("hicolor")) {
+        // This test depends on hicolor icon theme to resolve the icon.
+        QSKIP("hicolor icon theme not available");
+    }
+
     QString name("bug359388");
     KIconLoader iconLoader("tst_plasma-framework");
     QIcon customThemeIcon(new KIconEngine(name, &iconLoader));
@@ -315,6 +338,11 @@ void IconItemTest::loadSvg()
 
 void IconItemTest::themeChange()
 {
+    if (!Plasma::Theme().themeName().startsWith("default")) {
+        // This this depends on the production themes (infer their presence from default).
+        QSKIP("Current Plasma theme is not Breeze.");
+    }
+
     // Icon from Plasma theme
     QQuickItem *item1 = createIconItem();
     item1->setProperty("animated", false);
@@ -361,6 +389,11 @@ void IconItemTest::qiconFromTheme()
 
 void IconItemTest::changeColorGroup()
 {
+    if (!Plasma::Theme().themeName().startsWith("default")) {
+        // This this depends on the production default theme.
+        QSKIP("Current Plasma theme is not Breeze.");
+    }
+
     // Icon from Plasma theme
     QQuickItem *item = createIconItem();
     item->setProperty("animated", false);