From da2b6e270fb66258a54ba93cb09678a617d86fdd Mon Sep 17 00:00:00 2001 From: Kai Uwe Broulik Date: Sat, 2 Dec 2017 18:11:24 +0100 Subject: [PATCH] [Icon Item] Explicitly emit overlaysChanged in the setter rather than connecting to it There's literally just one place where this thing changes so just emit the signal there and call it a day. Differential Revision: https://phabricator.kde.org/D9112 --- src/declarativeimports/core/iconitem.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/declarativeimports/core/iconitem.cpp b/src/declarativeimports/core/iconitem.cpp index 20437fc5b..f0cb2eb3a 100644 --- a/src/declarativeimports/core/iconitem.cpp +++ b/src/declarativeimports/core/iconitem.cpp @@ -73,9 +73,6 @@ IconItem::IconItem(QQuickItem *parent) connect(this, &QQuickItem::windowChanged, this, &IconItem::schedulePixmapUpdate); - connect(this, &IconItem::overlaysChanged, - this, &IconItem::schedulePixmapUpdate); - connect(this, &IconItem::implicitWidthChanged, this, &IconItem::implicitWidthChanged2); connect(this, &IconItem::implicitHeightChanged, this, &IconItem::implicitHeightChanged2); @@ -280,6 +277,7 @@ void IconItem::setOverlays(const QStringList &overlays) return; } m_overlays = overlays; + schedulePixmapUpdate(); emit overlaysChanged(); }