alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

-use QStringLiteral and QLatin1String in the code that is executed multiple times (avoids utf8->utf16 conversions)

Browse Source 
-use splitRef when converting parts of qstring to ints to avoid redundant memory allocations
-warnings--: remove redundant ';'

CCMAIL: notmart@gmail.com
This commit is contained in:
Nick Shaforostoff 2015-11-06 13:39:18 +00:00
parent f32677b8e0
commit db7f198a19
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/declarativeimports/platformcomponents/application.h
View File

@ -43,13 +43,13 @@ class Application: public QObject
/** /**
* The name or path of the applications * The name or path of the applications
*/ */
Q_PROPERTY(QString application READ application WRITE setApplication NOTIFY applicationChanged); Q_PROPERTY(QString application READ application WRITE setApplication NOTIFY applicationChanged)
/** /**
* Indicates whether the user wants the application to be running or not. * Indicates whether the user wants the application to be running or not.
* It does not refer to the actual state of the application. * It does not refer to the actual state of the application.
*/ */
Q_PROPERTY(bool running READ running WRITE setRunning NOTIFY runningChanged); Q_PROPERTY(bool running READ running WRITE setRunning NOTIFY runningChanged)
public: public:
Application(QObject *parent = Q_NULLPTR); Application(QObject *parent = Q_NULLPTR);

2
src/plasma/private/theme_p.cpp
View File

@ -815,7 +815,7 @@ void ThemePrivate::setThemeName(const QString &tempThemeName, bool writeSettings
apiMinor = 0; apiMinor = 0;
apiRevision = 0; apiRevision = 0;
if (!apiVersion.isEmpty()) { if (!apiVersion.isEmpty()) {
QStringList parts = apiVersion.split('.'); QVector<QStringRef> parts = apiVersion.splitRef('.');
if (!parts.isEmpty()) { if (!parts.isEmpty()) {
apiMajor = parts.value(0).toInt(); apiMajor = parts.value(0).toInt();
} }

5
src/scriptengines/qml/plasmoid/appletinterface.cpp
View File

@ -500,9 +500,10 @@ int AppletInterface::apiVersion() const
// Look for C++ plugins first // Look for C++ plugins first
auto filter = [](const KPluginMetaData &md) -> bool auto filter = [](const KPluginMetaData &md) -> bool
{ {
return md.value("X-Plasma-API") == "declarativeappletscript" && md.value("X-Plasma-ComponentTypes").contains("Applet"); return md.value(QStringLiteral("X-Plasma-API")) == QLatin1String("declarativeappletscript")
&& md.value(QStringLiteral("X-Plasma-ComponentTypes")).contains(QLatin1String("Applet"));
}; };
QVector<KPluginMetaData> plugins = KPluginLoader::findPlugins("plasma/scriptengines", filter); QVector<KPluginMetaData> plugins = KPluginLoader::findPlugins(QStringLiteral("plasma/scriptengines"), filter);
if (plugins.isEmpty()) { if (plugins.isEmpty()) {
return -1; return -1;
} }