From e143f7d457f666bedc07c81bb9c1b342f8e7f835 Mon Sep 17 00:00:00 2001 From: Kai Uwe Broulik Date: Fri, 17 Aug 2018 15:46:29 +0200 Subject: [PATCH] [Icon Item] Use ItemEnabledHasChanged Preferred over having a connect and it go through meta signal invocation when it's emitted Differential Revision: https://phabricator.kde.org/D14531 --- src/declarativeimports/core/iconitem.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/declarativeimports/core/iconitem.cpp b/src/declarativeimports/core/iconitem.cpp index c554f8673..bc3722777 100644 --- a/src/declarativeimports/core/iconitem.cpp +++ b/src/declarativeimports/core/iconitem.cpp @@ -67,8 +67,10 @@ IconItem::IconItem(QQuickItem *parent) connect(KIconLoader::global(), &KIconLoader::iconLoaderSettingsChanged, this, &IconItem::updateImplicitSize); +#if QT_VERSION < QT_VERSION_CHECK(5, 10, 0) connect(this, &QQuickItem::enabledChanged, this, &IconItem::onEnabledChanged); +#endif connect(this, &IconItem::implicitWidthChanged, this, &IconItem::implicitWidthChanged2); connect(this, &IconItem::implicitHeightChanged, this, &IconItem::implicitHeightChanged2); @@ -654,6 +656,10 @@ void IconItem::itemChange(ItemChange change, const ItemChangeData &value) { if (change == ItemVisibleHasChanged && value.boolValue) { m_blockNextAnimation = true; +#if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0) + } else if (change == ItemEnabledHasChanged) { + onEnabledChanged(); +#endif } else if (change == ItemSceneChange && value.window) { schedulePixmapUpdate(); }