alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

null string:fallback empty string: empty

Browse Source
This commit is contained in:
Marco Martin 2014-02-10 16:18:13 +01:00
parent 0573a47e06
commit e30a50f755
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/scriptengines/qml/plasmoid/appletinterface.cpp
View File

@ -182,17 +182,25 @@ QString AppletInterface::toolTipMainText() const
void AppletInterface::setToolTipMainText(const QString &text) void AppletInterface::setToolTipMainText(const QString &text)
{ {
if (m_toolTipMainText == text) { //Here we are abusing the differentce between a null and and empty string.
//by default is null so fallsback to the name
//the fist time it gets set, an empty non null one is set, and won't fallback anymore
if (!m_toolTipMainText.isNull() && m_toolTipMainText == text) {
return; return;
} }
m_toolTipMainText = text; if (m_toolTipMainText.isEmpty()) {
m_toolTipMainText = QString("");//this "" makes it non-null
} else {
m_toolTipMainText = text;
}
emit toolTipMainTextChanged(); emit toolTipMainTextChanged();
} }
QString AppletInterface::toolTipSubText() const QString AppletInterface::toolTipSubText() const
{ {
if (m_toolTipMainText.isNull()) { if (m_toolTipSubText.isNull()) {
return applet()->pluginInfo().comment(); return applet()->pluginInfo().comment();
} else { } else {
return m_toolTipSubText; return m_toolTipSubText;
@ -201,11 +209,17 @@ QString AppletInterface::toolTipSubText() const
void AppletInterface::setToolTipSubText(const QString &text) void AppletInterface::setToolTipSubText(const QString &text)
{ {
if (m_toolTipSubText == text) { //Also there the difference between null and empty gets exploited
if (!m_toolTipSubText.isNull() && m_toolTipSubText == text) {
return; return;
} }
m_toolTipSubText = text; if (m_toolTipSubText.isEmpty()) {
m_toolTipSubText = QString("");//this "" makes it non-null
} else {
m_toolTipSubText = text;
}
emit toolTipSubTextChanged(); emit toolTipSubTextChanged();
} }