alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

don't reset the model if the source isn't ours

Browse Source
This commit is contained in:
Marco Martin 2011-07-25 19:11:36 +02:00
parent e3f18bded0
commit e8432fe351
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
declarativeimports/core/datamodel.cpp
View File

@ -293,20 +293,25 @@ void DataModel::removeSource(const QString &sourceName)
{ {
//FIXME: this could be way more efficient by not resetting the whole model //FIXME: this could be way more efficient by not resetting the whole model
//FIXME: find a way to remove only the proper things also in the case where sources are items //FIXME: find a way to remove only the proper things also in the case where sources are items
beginResetModel();
//source name as key of the map //source name as key of the map
if (!m_keyRoleFilter.isEmpty()) { if (!m_keyRoleFilter.isEmpty()) {
if (m_items.contains(sourceName)) {
beginResetModel();
m_items.remove(sourceName); m_items.remove(sourceName);
endResetModel();
}
//source name in the map, linear scan //source name in the map, linear scan
} else { } else {
for (int i = 0; i < m_items.value(QString()).count(); ++i) { for (int i = 0; i < m_items.value(QString()).count(); ++i) {
if (m_items.value(QString())[i].value<QVariantHash>().value("DataEngineSource") == sourceName) { if (m_items.value(QString())[i].value<QVariantHash>().value("DataEngineSource") == sourceName) {
beginResetModel();
m_items[QString()].remove(i); m_items[QString()].remove(i);
endResetModel();
break; break;
} }
} }
} }
endResetModel();
} }
QVariant DataModel::data(const QModelIndex &index, int role) const QVariant DataModel::data(const QModelIndex &index, int role) const