alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Fix PC2 ToolButtonStyle margins"

Browse Source 
This reverts commit 7062c635a9bc7186af5d14037ba74cb527bf6386.

Unfortunately, 3rd party themes were still broken after this commit was made because it didn't fix the real issue.

The real issue is that toolbutton-hover is supposed to have margins, but it didn't have real margins due to a previous patch to `button.svg`.

3rd party themes depend on hover and toolbutton-hover being used in inconsistent ways because of past behavior.
Unfortunately, they have to be inconsistent again
to not break themes.
This commit is contained in:
Noah Davis 2020-08-13 18:26:44 -04:00
parent 7062c635a9
commit eff71b6650
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/declarativeimports/plasmastyle/ToolButtonStyle.qml
View File

@ -397,10 +397,10 @@ QtQuickControlStyle.ButtonStyle {
]
Component.onCompleted: {
padding.top = control.flat ? surfacePressed.margins.top : surfaceNormal.margins.top
padding.left = control.flat ? surfacePressed.margins.left : surfaceNormal.margins.left
padding.right = control.flat ? surfacePressed.margins.right : surfaceNormal.margins.right
padding.bottom = control.flat ? surfacePressed.margins.bottom : surfaceNormal.margins.bottom
padding.top = surfaceNormal.margins.top
padding.left = surfaceNormal.margins.left
padding.right = surfaceNormal.margins.right
padding.bottom = surfaceNormal.margins.bottom
}
}
}