alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

provide a local rect cache in each Svg object to avoid going through the canonical but slower Theme cache more than once; makes a big difference for performance as these calls are made in painting hot paths

Browse Source 
svn path=/trunk/KDE/kdelibs/; revision=891325
This commit is contained in:
Aaron J. Seigo 2008-12-01 18:07:20 +00:00
parent 48cf523fc4
commit f25e5b82ff
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
svg.cpp
View File

@ -258,19 +258,25 @@ class SvgPrivate
}
renderer = 0;
localRectCache.clear();
}
QRectF elementRect(const QString &elementId)
{
QRectF rect;
if (themed && path.isEmpty()) {
path = Plasma::Theme::defaultTheme()->imagePath(themePath);
}
bool found = Theme::defaultTheme()->findInRectsCache(path, cacheId(elementId), rect);
QString id = cacheId(elementId);
if (localRectCache.contains(id)) {
return localRectCache[id];
}
QRectF rect;
bool found = Theme::defaultTheme()->findInRectsCache(path, id, rect);
if (found) {
localRectCache.insert(id, rect);
return rect;
}
@ -357,6 +363,7 @@ class SvgPrivate
Svg *q;
static QHash<QString, SharedSvgRenderer::Ptr> s_renderers;
QHash<QString, QRectF> localRectCache;
QHash <QString, QPixmap> itemsToSave;
QTimer *saveTimer;
SharedSvgRenderer::Ptr renderer;
@ -516,10 +523,9 @@ bool Svg::containsMultipleImages() const
void Svg::setImagePath(const QString &svgFilePath)
{
if (d->setImagePath(svgFilePath, this)) {
}
d->eraseRenderer();
emit repaintNeeded();
d->setImagePath(svgFilePath, this);
d->eraseRenderer();
emit repaintNeeded();
}
QString Svg::imagePath() const