From f639996becc2fae284d9c83273856dee510b699d Mon Sep 17 00:00:00 2001 From: Martin Klapetek Date: Tue, 29 Dec 2015 15:08:46 -0500 Subject: [PATCH] Use the SkipGrouping flag for the "widget deleted" notification https://git.reviewboard.kde.org/r/126459/ introduced new flag that allows to skip the grouping of notifications. This should fix all bugs caused by checking for appName being "plasma_workspace" which are all default notifications from any plasmoid. CCBUG: 356653 REVIEW: 126461 (this also needs to raise the KF5 dep to 5.18 which is normally done at release time, but in order to use this now, it needs to be bumped now, otherwise build failures will ensue) --- CMakeLists.txt | 2 +- src/plasma/private/applet_p.cpp | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c7f08d14e..3795b89b2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -22,7 +22,7 @@ include(ECMQtDeclareLoggingCategory) include(KDEPackageAppTemplates) set(KF5_VERSION "5.18.0") # handled by release scripts -set(KF5_DEP_VERSION "5.17.0") # handled by release scripts +set(KF5_DEP_VERSION "5.18.0") # handled by release scripts ecm_setup_version(${KF5_VERSION} VARIABLE_PREFIX PLASMA diff --git a/src/plasma/private/applet_p.cpp b/src/plasma/private/applet_p.cpp index 44ecdd919..949c92e00 100644 --- a/src/plasma/private/applet_p.cpp +++ b/src/plasma/private/applet_p.cpp @@ -254,6 +254,7 @@ void AppletPrivate::askDestroy() //no parent, but it won't leak, since it will be closed both in case of timeout //or direct action deleteNotification = new KNotification("plasmoidDeleted", KNotification::Persistent, 0); + deleteNotification->setFlags(KNotification::SkipGrouping); deleteNotification->setComponentName("plasma_workspace"); QStringList actions;