Fix segfault at plasma_applet_animation_example from kdeexamples

Patch-by: Andre L. V. Loureiro <loureiro.andrew@gmail.com>

svn path=/trunk/KDE/kdelibs/; revision=1082144
This commit is contained in:
Bruno de Oliveira Abinader 2010-01-29 20:36:32 +00:00
parent 54eeaa5f91
commit f820ea872d
4 changed files with 22 additions and 13 deletions

View File

@ -34,12 +34,12 @@ RotationStackedAnimation::RotationStackedAnimation(QObject *parent)
{ {
m_backRotation = new QGraphicsRotation(this); m_backRotation = new QGraphicsRotation(this);
m_frontRotation = new QGraphicsRotation(this); m_frontRotation = new QGraphicsRotation(this);
m_sLayout = new StackedLayout; m_wLayout = new StackedLayout;
} }
RotationStackedAnimation::~RotationStackedAnimation() RotationStackedAnimation::~RotationStackedAnimation()
{ {
delete m_sLayout; delete m_wLayout.data();
} }
void RotationStackedAnimation::setMovementDirection(const qint8 &direction) void RotationStackedAnimation::setMovementDirection(const qint8 &direction)
@ -147,15 +147,17 @@ void RotationStackedAnimation::setBackWidget(QGraphicsWidget *backWidget)
{ {
m_backWidget = backWidget; m_backWidget = backWidget;
if(targetWidget()) { StackedLayout *layout = m_wLayout.data();
m_sLayout->addWidget(targetWidget());
m_sLayout->addWidget(m_backWidget.data()); if(targetWidget() && backWidget && layout) {
layout->addWidget(targetWidget());
layout->addWidget(backWidget);
} }
} }
QGraphicsLayoutItem *RotationStackedAnimation::layout() QGraphicsLayoutItem *RotationStackedAnimation::layout()
{ {
return m_sLayout; return m_wLayout.data();
} }
void RotationStackedAnimation::updateState(QAbstractAnimation::State newState, void RotationStackedAnimation::updateState(QAbstractAnimation::State newState,
@ -172,14 +174,19 @@ void RotationStackedAnimation::updateCurrentTime(int currentTime)
return; return;
} }
StackedLayout *layout = m_wLayout.data();
if (!layout) {
return;
}
qreal delta; qreal delta;
if (currentTime <= duration()/2) { if (currentTime <= duration()/2) {
m_sLayout->setCurrentWidgetIndex(0); layout->setCurrentWidgetIndex(0);
delta = easingCurve().valueForProgress((currentTime*2) / qreal(duration())); delta = easingCurve().valueForProgress((currentTime*2) / qreal(duration()));
delta *= sideAngle; delta *= sideAngle;
m_frontRotation->setAngle(delta); m_frontRotation->setAngle(delta);
} else { } else {
m_sLayout->setCurrentWidgetIndex(1); layout->setCurrentWidgetIndex(1);
delta = 1 - easingCurve().valueForProgress(((currentTime*2) - duration()) / qreal(duration())); delta = 1 - easingCurve().valueForProgress(((currentTime*2) - duration()) / qreal(duration()));
delta = -delta; delta = -delta;
delta *= sideAngle; delta *= sideAngle;

View File

@ -112,13 +112,12 @@ private:
MovementDirection m_animDirection; MovementDirection m_animDirection;
/** Object the animation(s) should act upon. */ /** Object the animation(s) should act upon. */
QWeakPointer<QGraphicsWidget> m_backWidget; QWeakPointer<QGraphicsWidget> m_backWidget;
/** Layout where widget would be added */
QWeakPointer<StackedLayout> m_wLayout;
/** Back Widget Rotation transform object */ /** Back Widget Rotation transform object */
QGraphicsRotation *m_backRotation; QGraphicsRotation *m_backRotation;
/** Front Widget Rotation transform object */ /** Front Widget Rotation transform object */
QGraphicsRotation *m_frontRotation; QGraphicsRotation *m_frontRotation;
/** rotation stacked layout where the widget would be added */
StackedLayout *m_sLayout;
}; };
} // Plasma } // Plasma

View File

@ -21,7 +21,7 @@
#include <QDebug> #include <QDebug>
StackedLayout::StackedLayout(QGraphicsLayoutItem *parent) StackedLayout::StackedLayout(QGraphicsLayoutItem *parent)
: QGraphicsLayout(parent), m_currentWidgetIndex(-1) : QObject(0), m_currentWidgetIndex(-1), QGraphicsLayout(parent)
{ {
} }

View File

@ -20,8 +20,11 @@
#include <QGraphicsLayout> #include <QGraphicsLayout>
#include <QList> #include <QList>
#include <QObject>
class StackedLayout : public QGraphicsLayout { class StackedLayout : public QObject, public QGraphicsLayout
{
Q_OBJECT
public: public:
explicit StackedLayout(QGraphicsLayoutItem *parent = 0); explicit StackedLayout(QGraphicsLayoutItem *parent = 0);
~StackedLayout(); ~StackedLayout();