alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[IconItem] Use ItemSceneHasChanged rather than connect on windowChanged

Browse Source 
Saves a connection and also only schedule if we actually have a window.

Differential Revision: https://phabricator.kde.org/D9111
This commit is contained in:
Kai Uwe Broulik 2017-12-02 18:12:31 +01:00
parent da2b6e270f
commit f8e3a16040
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/declarativeimports/core/iconitem.cpp
View File

@ -70,9 +70,6 @@ IconItem::IconItem(QQuickItem *parent)
connect(this, &QQuickItem::enabledChanged, connect(this, &QQuickItem::enabledChanged,
this, &IconItem::onEnabledChanged); this, &IconItem::onEnabledChanged);
connect(this, &QQuickItem::windowChanged,
this, &IconItem::schedulePixmapUpdate);
connect(this, &IconItem::implicitWidthChanged, this, &IconItem::implicitWidthChanged2); connect(this, &IconItem::implicitWidthChanged, this, &IconItem::implicitWidthChanged2);
connect(this, &IconItem::implicitHeightChanged, this, &IconItem::implicitHeightChanged2); connect(this, &IconItem::implicitHeightChanged, this, &IconItem::implicitHeightChanged2);
@ -648,6 +645,8 @@ void IconItem::itemChange(ItemChange change, const ItemChangeData &value)
{ {
if (change == ItemVisibleHasChanged && value.boolValue) { if (change == ItemVisibleHasChanged && value.boolValue) {
m_blockNextAnimation = true; m_blockNextAnimation = true;
} else if (change == ItemSceneChange && value.window) {
schedulePixmapUpdate();
} }
QQuickItem::itemChange(change, value); QQuickItem::itemChange(change, value);