alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

give package a cache for found items; make the dptr implicitly shared

Browse Source 
this drops a 100k loop of copies from ~2700ms to ~37ms and a 100k loop
of copy-n-find from ~3900ms to ~40ms.

the cache addition is predicated on the idea that lookups of the same files will be frequent enough to warrant the small amount of extra memory usage for the cache. if that does not hold in practice (though it appears to) then this will not be a gain and in fact be a small net loss for memory footprint

the dptr change is predicated on the assumption that copies of Package will be frequent, and so must be low cost. this is known to be true. even if it wasn't, there is no down-side to this change. the upside are significant time and memory savings.
This commit is contained in:
Aaron Seigo 2011-07-22 17:24:40 +02:00
parent c0a60951a5
commit fbde93c64f
3 changed files with 57 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

74
package.cpp
View File

@ -126,19 +126,18 @@ Package::Package(PackageStructure *structure)
}
Package::Package(const Package &other)
: d(new PackagePrivate(*other.d))
: d(other.d)
{
}
Package::~Package()
{
delete d;
}
Package &Package::operator=(const Package &rhs)
{
if (&rhs != this) {
*d = *rhs.d;
d = rhs.d;
}
return *this;
@ -153,7 +152,7 @@ bool Package::isValid() const
//search for the file in all prefixes and in all possible paths for each prefix
//even if it's a big nested loop, usually there is one prefix and one location
//so shouldn't cause too much disk access
QMapIterator<QByteArray, ContentStructure> it(d->contents);
QHashIterator<QByteArray, ContentStructure> it(d->contents);
while (it.hasNext()) {
it.next();
if (!it.value().required) {
@ -186,7 +185,7 @@ bool Package::isValid() const
QString Package::name(const char *key) const
{
#ifndef PLASMA_NO_PACKAGE_EXTRADATA
QMap<QByteArray, ContentStructure>::const_iterator it = d->contents.constFind(key);
QHash<QByteArray, ContentStructure>::const_iterator it = d->contents.constFind(key);
if (it == d->contents.constEnd()) {
return QString();
}
@ -200,7 +199,7 @@ QString Package::name(const char *key) const
bool Package::isRequired(const char *key) const
{
QMap<QByteArray, ContentStructure>::const_iterator it = d->contents.constFind(key);
QHash<QByteArray, ContentStructure>::const_iterator it = d->contents.constFind(key);
if (it == d->contents.constEnd()) {
return false;
}
@ -211,7 +210,7 @@ bool Package::isRequired(const char *key) const
QStringList Package::mimeTypes(const char *key) const
{
#ifndef PLASMA_NO_PACKAGE_EXTRADATA
QMap<QByteArray, ContentStructure>::const_iterator it = d->contents.constFind(key);
QHash<QByteArray, ContentStructure>::const_iterator it = d->contents.constFind(key);
if (it == d->contents.constEnd()) {
return QStringList();
}
@ -233,6 +232,7 @@ QString Package::defaultPackageRoot() const
void Package::setDefaultPackageRoot(const QString &packageRoot)
{
d.detach();
d->defaultPackageRoot = packageRoot;
if (!d->defaultPackageRoot.isEmpty() && !d->defaultPackageRoot.endsWith('/')) {
d->defaultPackageRoot.append('/');
@ -246,6 +246,7 @@ QString Package::servicePrefix() const
void Package::setServicePrefix(const QString &servicePrefix)
{
d.detach();
d->servicePrefix = servicePrefix;
}
@ -256,6 +257,7 @@ bool Package::allowExternalPaths() const
void Package::setAllowExternalPaths(bool allow)
{
d.detach();
d->externalPaths = allow;
}
@ -311,6 +313,12 @@ QString Package::filePath(const char *fileType, const QString &filename) const
return QString();
}
const QString discoveryKey(fileType + filename);
if (d->discoveries.contains(discoveryKey)) {
//qDebug() << "looking for" << discoveryKey << d->discoveries.value(discoveryKey);
return d->discoveries[discoveryKey];
}
QStringList paths;
if (qstrlen(fileType) != 0) {
@ -323,6 +331,7 @@ QString Package::filePath(const char *fileType, const QString &filename) const
if (paths.isEmpty()) {
//kDebug() << "no matching path came of it, while looking for" << fileType << filename;
d->discoveries.insert(discoveryKey, QString());
return QString();
}
} else {
@ -346,6 +355,7 @@ QString Package::filePath(const char *fileType, const QString &filename) const
if (QFile::exists(file)) {
if (d->externalPaths) {
//kDebug() << "found" << file;
d->discoveries.insert(discoveryKey, file);
return file;
}
@ -357,6 +367,7 @@ QString Package::filePath(const char *fileType, const QString &filename) const
//kDebug() << "testing that" << canonicalized << "is in" << d->path;
if (canonicalized.startsWith(d->path)) {
//kDebug() << "found" << file;
d->discoveries.insert(discoveryKey, file);
return file;
}
}
@ -373,7 +384,7 @@ QStringList Package::entryList(const char *key) const
return QStringList();
}
QMap<QByteArray, ContentStructure>::const_iterator it = d->contents.constFind(key);
QHash<QByteArray, ContentStructure>::const_iterator it = d->contents.constFind(key);
if (it == d->contents.constEnd()) {
//kDebug() << "couldn't find" << key;
return QStringList();
@ -426,9 +437,20 @@ QStringList Package::entryList(const char *key) const
void Package::setPath(const QString &path)
{
if (path == d->path) {
return;
}
d.detach();
d->discoveries.clear();
if (path.isEmpty()) {
d->path.clear();
d->valid = false;
if (d->structure) {
d->structure.data()->pathChanged(this);
}
return;
}
@ -478,8 +500,11 @@ void Package::setPath(const QString &path)
d->path = basePath;
delete d->metadata;
d->metadata = 0;
pathChanged();
d->valid = !d->path.isEmpty();
if (d->structure) {
d->structure.data()->pathChanged(this);
}
}
const QString Package::path() const
@ -487,13 +512,6 @@ const QString Package::path() const
return d->path;
}
void Package::pathChanged()
{
if (d->structure) {
d->structure.data()->pathChanged(this);
}
}
QStringList Package::contentsPrefixPaths() const
{
return d->contentsPrefixPaths;
@ -501,6 +519,7 @@ QStringList Package::contentsPrefixPaths() const
void Package::setContentsPrefixPaths(const QStringList &prefixPaths)
{
d.detach();
d->contentsPrefixPaths = prefixPaths;
if (d->contentsPrefixPaths.isEmpty()) {
d->contentsPrefixPaths << QString();
@ -594,17 +613,19 @@ void Package::removeDefinition(const char *key)
void Package::setRequired(const char *key, bool required)
{
QMap<QByteArray, ContentStructure>::iterator it = d->contents.find(key);
QHash<QByteArray, ContentStructure>::iterator it = d->contents.find(key);
if (it == d->contents.end()) {
return;
}
d.detach();
it.value().required = required;
}
void Package::setDefaultMimeTypes(QStringList mimeTypes)
{
#ifndef PLASMA_NO_PACKAGE_EXTRADATA
d.detach();
d->mimeTypes = mimeTypes;
#endif
}
@ -612,11 +633,12 @@ void Package::setDefaultMimeTypes(QStringList mimeTypes)
void Package::setMimeTypes(const char *key, QStringList mimeTypes)
{
#ifndef PLASMA_NO_PACKAGE_EXTRADATA
QMap<QByteArray, ContentStructure>::iterator it = d->contents.find(key);
QHash<QByteArray, ContentStructure>::iterator it = d->contents.find(key);
if (it == d->contents.end()) {
return;
}
d.detach();
it.value().mimeTypes = mimeTypes;
#endif
}
@ -624,7 +646,7 @@ void Package::setMimeTypes(const char *key, QStringList mimeTypes)
QList<const char*> Package::directories() const
{
QList<const char*> dirs;
QMap<QByteArray, ContentStructure>::const_iterator it = d->contents.constBegin();
QHash<QByteArray, ContentStructure>::const_iterator it = d->contents.constBegin();
while (it != d->contents.constEnd()) {
if (it.value().directory) {
dirs << it.key();
@ -637,7 +659,7 @@ QList<const char*> Package::directories() const
QList<const char*> Package::requiredDirectories() const
{
QList<const char*> dirs;
QMap<QByteArray, ContentStructure>::const_iterator it = d->contents.constBegin();
QHash<QByteArray, ContentStructure>::const_iterator it = d->contents.constBegin();
while (it != d->contents.constEnd()) {
if (it.value().directory &&
it.value().required) {
@ -651,7 +673,7 @@ QList<const char*> Package::requiredDirectories() const
QList<const char*> Package::files() const
{
QList<const char*> files;
QMap<QByteArray, ContentStructure>::const_iterator it = d->contents.constBegin();
QHash<QByteArray, ContentStructure>::const_iterator it = d->contents.constBegin();
while (it != d->contents.constEnd()) {
if (!it.value().directory) {
files << it.key();
@ -664,7 +686,7 @@ QList<const char*> Package::files() const
QList<const char*> Package::requiredFiles() const
{
QList<const char*> files;
QMap<QByteArray, ContentStructure>::const_iterator it = d->contents.constBegin();
QHash<QByteArray, ContentStructure>::const_iterator it = d->contents.constBegin();
while (it != d->contents.constEnd()) {
if (!it.value().directory && it.value().required) {
files << it.key();
@ -905,7 +927,8 @@ bool PackagePrivate::uninstallPackage(const QString &packageName, const QString
}
PackagePrivate::PackagePrivate()
: servicePrefix("plasma-applet-"),
: QSharedData(),
servicePrefix("plasma-applet-"),
metadata(0),
externalPaths(false),
valid(false)
@ -914,6 +937,7 @@ PackagePrivate::PackagePrivate()
}
PackagePrivate::PackagePrivate(const PackagePrivate &other)
: QSharedData()
{
*this = other;
metadata = 0;
@ -926,6 +950,10 @@ PackagePrivate::~PackagePrivate()
PackagePrivate &PackagePrivate::operator=(const PackagePrivate &rhs)
{
if (&rhs == this) {
return *this;
}
structure = rhs.structure;
path = rhs.path;
contentsPrefixPaths = rhs.contentsPrefixPaths;

8
package.h
View File

@ -280,12 +280,6 @@ public:
*/
void setDefaultPackageRoot(const QString &packageRoot);
/**
* Called whenever the path changes so that subclasses may take
* package specific actions.
*/
void pathChanged();
// Content structure description methods
/**
* @return all directories registered as part of this Package's structure
@ -328,7 +322,7 @@ public:
bool uninstallPackage(const QString &packageName, const QString &packageRoot);
private:
PackagePrivate * const d;
QExplicitlySharedDataPointer<PackagePrivate> d;
};
}

7
private/package_p.h
View File

@ -26,6 +26,7 @@
#include <QCryptographicHash>
#include <QDir>
#include <QString>
#include <QSharedData>
namespace Plasma
{
@ -50,6 +51,7 @@ class ContentStructure
required = other.required;
}
QString found;
QStringList paths;
#ifndef PLASMA_NO_PACKAGE_EXTRADATA
QString name;
@ -59,7 +61,7 @@ class ContentStructure
bool required : 1;
};
class PackagePrivate
class PackagePrivate : public QSharedData
{
public:
PackagePrivate();
@ -78,7 +80,8 @@ public:
QStringList contentsPrefixPaths;
QString defaultPackageRoot;
QString servicePrefix;
QMap<QByteArray, ContentStructure> contents;
QHash<QString, QString> discoveries;
QHash<QByteArray, ContentStructure> contents;
#ifndef PLASMA_NO_PACKAGE_EXTRADATA
QStringList mimeTypes;
#endif