alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Containment Interface] No need for values() as contains() looks up keys

Browse Source 
Avoids creating a temporary list for no reason.
Also use value() which is always const compared to operator[]

Differential Revision: https://phabricator.kde.org/D4348
This commit is contained in:
Kai Uwe Broulik 2017-01-30 15:07:30 +01:00
parent 8d60a8f1f5
commit fe39905560
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/scriptengines/qml/plasmoid/containmentinterface.cpp
View File

@ -562,8 +562,8 @@ void ContainmentInterface::mimeTypeRetrieved(KIO::Job *job, const QString &mimet
} else {
QPoint posi; // will be overwritten with the event's position
if (m_dropPoints.keys().contains(tjob)) {
posi = m_dropPoints[tjob];
if (m_dropPoints.contains(tjob)) {
posi = m_dropPoints.value(tjob);
qDebug() << "Received a suitable dropEvent at" << posi;
} else {
qDebug() << "Bailing out. Cannot find associated dropEvent related to the TransferJob";