Commit Graph

13243 Commits

Author SHA1 Message Date
Aaron Seigo
928d5e63a5 bool Package::hasValidStructure() const
needed to differentiate between packages with structures and without
before path is set
2014-08-08 14:12:22 +02:00
Aaron Seigo
3e61b26178 better variable naming for clarity 2014-08-08 14:12:22 +02:00
Marco Martin
0d3a814e20 Don't leak
we were creating new packagestructures on each package creation
and never deleting them, causing a pretty big leak.

now keep a single instance of the structures, with prototype packages.
members are static for binary compatibility.
i would go for max one bic change in this library that's when and if
this library will be made pubic.

Patch by Aaron Seigo
2014-08-08 14:04:46 +02:00
Marco Martin
f608e85294 extract the app name and icon we'll be open with 2014-08-08 13:40:34 +02:00
Marco Martin
5f1abfbbe3 add definition for a screenshot 2014-08-08 13:29:46 +02:00
Marco Martin
d266a9594b valid package internalload even if just structure
consider a loaded package valid even if !isvalid() but does have some file
that indicates it has a valid packagestructure.
for how packages are loaded now, a package is never valid at first if has a required file:
because the path gets set only after the package is loaded
this fixes wallpaper loading
2014-08-08 11:29:23 +02:00
Aaron Seigo
b99001ace4 typos in comments 2014-08-08 08:25:27 +02:00
Aaron Seigo
c8c342abd3 test removing a defintion on a copy 2014-08-08 08:25:27 +02:00
Aaron Seigo
b4f4515d2a detach on file/directory definition add 2014-08-08 08:25:27 +02:00
Aaron Seigo
bc571d98e2 test adding files/directories to copied Package object 2014-08-08 08:25:27 +02:00
Aaron Seigo
cbec4fda2d test more mutators 2014-08-08 08:25:27 +02:00
Aaron Seigo
d376a9ac28 test for mutating after copying Package objects
required and mimetype were not working, and this tests to ensure
that doesn't break again
2014-08-08 08:25:27 +02:00
Aaron Seigo
9ee252475f setRequired actually works now 2014-08-08 08:25:26 +02:00
Aaron Seigo
402825b301 after detaching, fetch the item from the collection again
fixes setting these values on a copy of the package
2014-08-08 08:25:26 +02:00
Marco Martin
fad59eb01a bind setAssociatedApplicationUrls
add notify signal for setAssociatedApplication
Reviewed-by: Eike Hein
2014-08-07 19:34:57 +02:00
Marco Martin
1585c9b26a be aware of dpi changes
BUG:338093
2014-08-07 17:05:55 +02:00
Marco Martin
2482eb193c allow applets specify a different root than pluginname
introduce X-Plasma-RootPath: it would be used instead of
the plugin name for package root path if present
2014-08-07 16:26:51 +02:00
Marco Martin
419d97cfe0 Merge branch 'mart/QtControlsTextField'
REVIEW:119523
2014-08-07 15:42:21 +02:00
Marco Martin
11b2da667d fix logic of install/remove eventfilter 2014-08-07 13:28:37 +02:00
Marco Martin
1baddcc004 port plasma1 popupapplet event filter logic
use an event filter to open popup menus inside popups.
requires a recent 5.3 revision and a small change in the shell package
2014-08-06 19:45:31 +02:00
Marco Martin
120132879a contextualActionsAboutToShow signal
emitted just before showing a context menu
gives the plasmoid the time to fiddle with the actions beforehand
reviewd by:Eike Hein
BUG:337959
2014-08-06 11:43:55 +02:00
Aleix Pol
d7a7a4fb83 Use Qt API for figuring out the dialog screen
At the moment it's trying to translate the item position and iterating
through all screens, but we can get the screen through the item's window.

REVIEW: 119603
2014-08-05 19:48:28 +02:00
l10n daemon script
6aefc544d8 Upgrade ECM and KF5 version requirements for 5.1.0 release. 2014-08-04 19:53:36 +02:00
l10n daemon script
61fcfe6e9c Upgrade KF5 version. 2014-08-04 19:53:35 +02:00
Aleix Pol
ebe9011253 Have separate texture hashes for each window
Apparently in nvidia we get corruptions when a texture created for a window
is used in another one.
With this patch we tell the texture has changed when we move it from a
window to another, so it's re-created and we keep textures for all windows
separately. This way we ensure they don't mix.

REVIEW: 119465
2014-08-04 19:53:35 +02:00
Marco Martin
712de91021 leave space for the clear button 2014-08-04 19:44:34 +02:00
Marco Martin
d66e62116b reintroduce all removed properties and methods
reintroduced as dummy, so existing stuff doesn't break but gets a warning
2014-08-04 19:28:30 +02:00
l10n daemon script
3db176041b Upgrade ECM and KF5 version requirements for 5.1.0 release. 2014-08-02 08:21:59 +00:00
l10n daemon script
6e1263c5f8 Upgrade KF5 version. 2014-08-01 17:12:11 +00:00
Marco Martin
b93132fca7 use QtControls for the textField 2014-07-28 19:55:32 +02:00
Aleix Pol
b6f5335cd8 Have separate texture hashes for each window
Apparently in nvidia we get corruptions when a texture created for a window
is used in another one.
With this patch we tell the texture has changed when we move it from a
window to another, so it's re-created and we keep textures for all windows
separately. This way we ensure they don't mix.

REVIEW: 119465
2014-07-28 19:48:08 +02:00
Marco Martin
f040238d82 Merge branch 'mart/QtControlsToolButton'
REVIEW:119464
2014-07-28 17:48:31 +02:00
Marco Martin
546ffbc791 reintroduce containmentForScreen with defaultPlugin
reintroduces an api call from plasma1:
its the only way to solve
https://bugs.kde.org/show_bug.cgi?id=337200
basically to avoid a crash when plasma starts with missing containments in the appletsrc and a locked corona, or a screen added with locked widgets.

it's the only entry point that allows a creation of a containment when widgets are locked
REVIEW:119513
CCBUG:337200
2014-07-28 13:43:23 +02:00
Àlex Fiestas
af2a44784f Add an option to build Plasma with coverage
At this moment we only add some flags to linker and compiler, lets hope
it is enough.
2014-07-26 23:18:37 +02:00
Marco Martin
0aaf7db0e4 use QtControls.ToolButton 2014-07-25 18:51:12 +02:00
Marco Martin
f2a1824c31 proper colors for the labels and icons 2014-07-25 15:43:17 +02:00
Marco Martin
957eab570e support for attached buttons 2014-07-25 15:36:14 +02:00
Marco Martin
c8cb89faa9 support for round buttons 2014-07-25 14:40:13 +02:00
Marco Martin
a3266857ad initial port of ToolButton
wonder if will be possible to share something with Button,
but ToolButton is way more complicated
2014-07-25 14:21:05 +02:00
Marco Martin
a059748fbc Merge branch 'mart/QtControlsButton'
REVIEW:119455
2014-07-25 13:05:00 +02:00
Aleix Pol
daf7981820 Just pass the bigger textures from the !m_fastPath to the textures cache
It's a really cheap lookup, and maybe we get to skip some textures
uploading

Reviewed by David Edmundson
2014-07-25 12:57:16 +02:00
Marco Martin
05f4a44059 use implicitWidth as label minimum width 2014-07-25 12:54:27 +02:00
Aleix Pol
ab0740228c Remove hint-stretch-over-borders from lineedit
This way the line edit can go through the fast path as well
2014-07-25 12:53:24 +02:00
Aleix Pol
6641285d3b Remove deprecated code-path
hint-compose-over-border is now treated by the !m_fastPath
2014-07-25 12:42:31 +02:00
Aleix Pol
bc425f1809 Cache the textures created for the fast path
Create a cache that has pointers to all the textures that we've generated,
so in case we have one already created, we can re-use it.

REVIEW: 119425
2014-07-25 12:41:53 +02:00
Marco Martin
dbbb8056f5 use the minimumWidth gave by the Layout 2014-07-25 11:26:41 +02:00
Marco Martin
d29b3f051d don't mix anchors and layouts 2014-07-25 11:20:26 +02:00
Marco Martin
7538c3292c don't compute two times the same thing 2014-07-24 20:16:46 +02:00
Marco Martin
0c2138916e use RowLayout 2014-07-24 20:11:31 +02:00
Marco Martin
b538a1dca9 override iconSource for compatibility 2014-07-24 19:19:26 +02:00