7 Commits

Author SHA1 Message Date
Nate Graham
46b46c8135 Port to singleton Theme
We ported units to use the PlasmaCore.Units singleton earlier; now it's
time to do the same thing for PlasmaCore.Theme.

There are no UI changes or regressions detected.
2021-04-08 09:20:52 -06:00
Nate Graham
5447cef2d8 Port to singleton Units
The context property version is slower to access and won't be supported
in Qt6. Let's port away from it and use the singleton version instead.

Here was my full process for making this change:

1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
2. Verified no more occurrences with `grep -r " units."`
3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+   " | grep "//"`
4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done` (one needed the import)
2021-03-07 13:34:47 +00:00
Andreas Cord-Landwehr
d10afb5d2a plasma-framework: Convert copyright statements to SPDX expressions 2020-08-13 19:08:54 +00:00
Nate Graham
5ef8b1a189 Use font: instead of font.pointSize: where possible
Summary:
Otherwise we're discarding style information possibly set in
the user's small font choices when we want to set a smaller
font.

Test Plan: Stuff that's suposta look small still looks small

Reviewers: #plasma, cblack

Reviewed By: #plasma, cblack

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D29436
2020-05-19 10:18:23 -06:00
Nate Graham
6b8f114284 Port away from Title and towards level 1 Heading
Summary: `Title` is deprecated.

Test Plan: No visual changes anywhere; level 1 Heading is identical in appearance

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27350
2020-02-21 08:39:25 -07:00
Sebastian Kügler
993d4e56c0 More refined font tests in testtheme applets 2014-03-26 01:10:41 +01:00
Sebastian Kügler
0b4951c5b7 Add tests for font metrics 2014-03-26 00:11:30 +01:00