Commit Graph

452 Commits

Author SHA1 Message Date
Marco Martin
f4514950f4 reverting the last change, the panel height is still the old one at that
point :)

CCBUG:176280

svn path=/trunk/KDE/kdelibs/; revision=927158
2009-02-16 22:11:24 +00:00
Marco Martin
59a0e9f0e8 theory: the desktop breakage could happen because the panel overlaps the
desktop for a while, making containment()->view() or
corona::containmentfordesktop() fails, leaving the desktop view without
a containment
try to reposition the panel before a vertical movement, it should
prevent the panel to go into the desktop for an instant
CCBUG:176280

svn path=/trunk/KDE/kdelibs/; revision=927141
2009-02-16 21:45:18 +00:00
Artur Duque de Souza
cae61ee4ca Use enums from KIconLoader
Instead of using hardcore numbers, it would be great to use the enums provided by 
KIconLoader whenever we use sizes for icons.

Made the change for the obvious ones replacing "16" by KIconLoader::SizeSmall, 
"22" by KIconLoader::SizeSmallMedium and "32" by KIconLoader::SizeMedium.

svn path=/trunk/KDE/kdelibs/; revision=926544
2009-02-15 16:35:52 +00:00
Rob Scheepmaker
fe805eb338 Massive refactoring of extender drag&drop handling. This should avoid bugs with the old way of doing things (toplevel view on an offscreen widget can lose
mouse events while dragging), and is generally shorter and cleaner. There are still some regressions I'll be working on fixing, but it basically works, avoids 
crashes and is even faster.


svn path=/trunk/KDE/kdelibs/; revision=923915
2009-02-09 18:10:45 +00:00
Alexis Ménard
ef4b6c7187 Add an appletDestroyed signal instead of catching the destruction in containments with qobject destroyed signal.
THis fix errors because we give an invalid pointer to public appletRemoved signal.

svn path=/trunk/KDE/kdelibs/; revision=917619
2009-01-28 07:58:17 +00:00
Christophe Giboudeaux
ae301b3718 kaction.h is already included. Just remove the extra ones
svn path=/trunk/KDE/kdelibs/; revision=917529
2009-01-28 00:12:02 +00:00
Cédric Borgese
1b12af86cc Fix compilation : camel case includes of kdelibs headers are not accessible while building kdelibs.
svn path=/trunk/KDE/kdelibs/; revision=917525
2009-01-28 00:01:15 +00:00
Chani Armitage
958cc6e953 -fix settings shortcut
-QAction->KAction
IMPORTANT: if you need to do things to the keyboard shortcuts of kactions (which means all of plasma's standard actions from now on), make sure you're using a KAction* and not a QAction*

svn path=/trunk/KDE/kdelibs/; revision=917435
2009-01-27 20:50:34 +00:00
Marco Martin
bb8c603060 moved the activate() signal chaining from applet to containment
svn path=/trunk/KDE/kdelibs/; revision=915940
2009-01-24 10:47:35 +00:00
Aaron J. Seigo
a414e32f0b some clean ups
svn path=/trunk/KDE/kdelibs/; revision=915487
2009-01-23 07:32:11 +00:00
Aaron J. Seigo
72d632a234 this started out as a self contained patch just to merge two actions, but rapidly got out of hand ;)
* default to no config interface for containments
* merge the Appearance Settings and Configure actions for containments
* be even more careful with about-to-be-deleted widget (d->transient) including giving them a fake-but-valid scratchpad of a KConfigGroup if requested after deletd
* replace some method calls with direct access to the private members

svn path=/trunk/KDE/kdelibs/; revision=914890
2009-01-22 00:00:16 +00:00
Chani Armitage
0f3f06f024 all plasma shortcuts are emacs-style now, starting with alt-d, to avoid conflicts.
svn path=/trunk/KDE/kdelibs/; revision=914295
2009-01-20 19:38:45 +00:00
Aaron J. Seigo
307f5760c3 * do the input sanitization first
* use newScreen and newDesktop to make the code more understandable; someone already tripped up on d->screen vs screen in a bug report. d->screen vs newScreen should be harder to miss.

svn path=/trunk/KDE/kdelibs/; revision=913111
2009-01-18 19:52:09 +00:00
Aaron J. Seigo
5e41fb8132 don't lose the desktop in the process of swaping contaiment assignments; include desktop assignment in the debug
CCBUG:175697

svn path=/trunk/KDE/kdelibs/; revision=913049
2009-01-18 17:56:06 +00:00
Aaron J. Seigo
4bc508411a neat bug: changing Activity type while widgets are locked caused Appearances settings to be permahidden. chased out a few other ways to trigger this once that one was fixed, works nicely now.
BUG:180887

svn path=/trunk/KDE/kdelibs/; revision=911727
2009-01-16 00:39:07 +00:00
Aaron J. Seigo
dd99751e2b SVN_SILENT: coding style!
svn path=/trunk/KDE/kdelibs/; revision=910608
2009-01-13 19:49:19 +00:00
Beat Wolf
ad56e279e2 Don't create submenu for "unlock widgets" if there is only one action in the submenu
svn path=/trunk/KDE/kdelibs/; revision=910410
2009-01-13 11:03:48 +00:00
Aaron J. Seigo
c5e44c35d2 if the applet is already in another containment, don't re-animate it as if it were new
svn path=/trunk/KDE/kdelibs/; revision=908501
2009-01-09 20:44:53 +00:00
Aaron J. Seigo
e009bc7382 protect access to toolbox, when used with containments that don't create one or turn theirs off
BUG:179909

svn path=/trunk/KDE/kdelibs/; revision=907205
2009-01-07 16:42:12 +00:00
Aaron J. Seigo
d4bb3c790a no need to focus an applet twice
svn path=/trunk/KDE/kdelibs/; revision=905312
2009-01-04 07:59:10 +00:00
Chani Armitage
c0496911af the settings dialog for wallpaper n'stuff needs to respect security
svn path=/trunk/KDE/kdelibs/; revision=902697
2008-12-28 23:45:27 +00:00
Sebastian Sauer
8f12925265 disable conflicting shortcut for now.
BUG:165938


svn path=/trunk/KDE/kdelibs/; revision=897447
2008-12-16 04:34:38 +00:00
Aaron J. Seigo
85161ce13f re-enable some debug needed to work out problems with multiscreen
svn path=/trunk/KDE/kdelibs/; revision=897316
2008-12-15 18:28:28 +00:00
Aaron J. Seigo
6e6cb12b9b delay the saving of new applets so that layouts can do their job
svn path=/trunk/KDE/kdelibs/; revision=897306
2008-12-15 17:48:28 +00:00
Aaron J. Seigo
5c2927870d * consolidate the remove action enabling check into one method
* check the remove action on immutability changes (prevents "Remove" from showing up erroniously when locking then unlocking)

svn path=/trunk/KDE/kdelibs/; revision=897290
2008-12-15 16:54:09 +00:00
Aaron J. Seigo
29b2776ee4 carefully save applets on creation, prevents losing new applets right after adding them
svn path=/trunk/KDE/kdelibs/; revision=895934
2008-12-12 01:05:00 +00:00
Aaron J. Seigo
4ffa080061 SVN_SILENT: quit spamming the output with this one
svn path=/trunk/KDE/kdelibs/; revision=895806
2008-12-11 19:53:35 +00:00
Frederik Gladhorn
f0c5eeea37 put the "Appearance Settings" after "Lock Widgets" in the context menu of the desktop
svn path=/trunk/KDE/kdelibs/; revision=894992
2008-12-09 19:10:30 +00:00
Marco Martin
98b833977b correct some last toolbox annoyances...
svn path=/trunk/KDE/kdelibs/; revision=893011
2008-12-05 18:16:30 +00:00
Aaron J. Seigo
2207ff1dc5 make it possible to remove panels again
svn path=/trunk/KDE/kdelibs/; revision=892648
2008-12-04 20:34:04 +00:00
Marco Martin
b596d894e5 keep remove action enabled on panels
svn path=/trunk/KDE/kdelibs/; revision=892472
2008-12-04 12:55:34 +00:00
Aaron J. Seigo
5055bf7bf0 the margins should be constant; it's a grid.
svn path=/trunk/KDE/kdelibs/; revision=891718
2008-12-02 18:42:06 +00:00
Marco Martin
9fd8a3298d correctly position new activity when adding one
never show text on wider zoom level

svn path=/trunk/KDE/kdelibs/; revision=891258
2008-12-01 13:17:27 +00:00
Marco Martin
d9c14c87ba show the toolbox as an external solid-background toolbar under the
containment, don't show text on icons except add windgets and add
activity
show the remove activity button in the toolbox for non active ones

svn path=/trunk/KDE/kdelibs/; revision=891209
2008-12-01 12:40:08 +00:00
Aaron J. Seigo
509632ff64 a couple of related fixes to make destroying containments work a lot better
svn path=/trunk/KDE/kdelibs/; revision=889816
2008-11-27 18:55:32 +00:00
Aaron J. Seigo
15cc6a0731 disconnect applets from the containment they get moved from
CCBUG:173879

svn path=/trunk/KDE/kdelibs/; revision=888666
2008-11-25 03:07:18 +00:00
Aaron J. Seigo
7b4de980b8 clarify this code a wee bit more and call positionContainments() in all necessary cases
svn path=/trunk/KDE/kdelibs/; revision=888637
2008-11-25 00:23:43 +00:00
Aaron J. Seigo
323c6a7232 * catch CustomPanelContainment as well on immutability settings
* immobilize the desktop toolbox on immutability

svn path=/trunk/KDE/kdelibs/; revision=886372
2008-11-19 03:28:15 +00:00
Aaron J. Seigo
8a68d06f0d grant minimal access to the toolbox so we can avoid nasty hacks in containments. see next commit to PanelContainment for what i meant ;)
svn path=/trunk/KDE/kdelibs/; revision=886223
2008-11-18 20:49:42 +00:00
Aaron J. Seigo
d6bd085b75 cover a few more cases where we should position the toolbox
svn path=/trunk/KDE/kdelibs/; revision=885841
2008-11-18 00:16:45 +00:00
Aaron J. Seigo
e1c9aadb93 save/restore the desktop setting
svn path=/trunk/KDE/kdelibs/; revision=885338
2008-11-17 05:16:33 +00:00
Aaron J. Seigo
160e70ccd0 add proper support for virtual desktops, which really requires more than just the View being aware of it; given the default parameters, it's a detail most plasma based apps can ignore (just like screens in general, actually =)
svn path=/trunk/KDE/kdelibs/; revision=885330
2008-11-17 04:34:55 +00:00
Aaron J. Seigo
d0c7968b18 load and save toolbox position between restarts!
still to come:

* don't paint when zoomed, replace with tool strip instead
* respect available area during drag
* smarter positioning (right now it just loads the saved position whenever it needs to reposition)

svn path=/trunk/KDE/kdelibs/; revision=884072
2008-11-14 07:28:02 +00:00
Aaron J. Seigo
a65daf42b2 more accurate sorting, based on a patch by zhangqiang
CCMAIL:zhangqiang@redflag-linux.com

svn path=/trunk/KDE/kdelibs/; revision=884048
2008-11-14 04:01:01 +00:00
Beat Wolf
675b4b59b8 add general way to add context menus to containments. Reviewed by aseigo
svn path=/trunk/KDE/kdelibs/; revision=884003
2008-11-13 23:08:58 +00:00
Aaron J. Seigo
f709ce0d05 ok, that was too long. Activity is a bit of a detail as well..
svn path=/trunk/KDE/kdelibs/; revision=883457
2008-11-12 23:10:57 +00:00
Aaron J. Seigo
cdf562df11 simplify toolbox positioining and drawing
svn path=/trunk/KDE/kdelibs/; revision=882672
2008-11-11 08:12:20 +00:00
Aaron J. Seigo
aec4445dec grrrrr.. eventualy i'll find a phrase that doesnt' suck; not sure this is it yet though =P
svn path=/trunk/KDE/kdelibs/; revision=882614
2008-11-11 01:07:35 +00:00
Aaron J. Seigo
4e964a2ec8 update the hover pos to make the entry point the last hovered location
BUG:172075

svn path=/trunk/KDE/kdelibs/; revision=882611
2008-11-11 00:57:08 +00:00
Aaron J. Seigo
86e88a2be2 SVN_SILENT: remove some out of date TODOs
svn path=/trunk/KDE/kdelibs/; revision=882216
2008-11-10 03:52:45 +00:00
Aaron J. Seigo
249a44ab8d don't overload the meaning of hasConfigurationInterface for containments, since that makes things difficult for applets-that-are-containments, e.g. folderview
svn path=/trunk/KDE/kdelibs/; revision=882205
2008-11-10 01:26:27 +00:00
Aaron J. Seigo
daf6fa87b5 avoid making a copy of the config group in the loop, and switch to a mutable iterator to avoid a const_cast (which are ugly); should make krazy happier
svn path=/trunk/KDE/kdelibs/; revision=880617
2008-11-05 23:14:47 +00:00
Aaron J. Seigo
1a86e5cf41 no longer needed as there are unix/win/mac impls of kwindowsystem now
svn path=/trunk/KDE/kdelibs/; revision=880604
2008-11-05 22:57:45 +00:00
Aaron J. Seigo
4b08c03726 change KDE includes to use the .h style now that we're in libs
svn path=/trunk/KDE/kdelibs/; revision=879795
2008-11-04 02:04:34 +00:00
Aaron J. Seigo
1b523b9054 ok, this time JUST the plasma dir ;)
svn path=/trunk/KDE/kdelibs/; revision=879759
2008-11-03 23:08:39 +00:00
Aaron J. Seigo
fa5a2d87d9 bum-de-dum! plasma to kdelibs.
svn path=/trunk/KDE/kdelibs/; revision=879757
2008-11-03 23:03:26 +00:00
Albert Astals Cid
45edd84dfc add context
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=879206
2008-11-02 17:38:52 +00:00
Aaron J. Seigo
60ab332312 don't assert, just check. over the next month or two we need to keep an eye on which asserts around corona() get triggered and try and make as many of those calls happen only post-load
CCMAIL:faure@kde.org

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=878025
2008-10-31 04:37:56 +00:00
Kevin Ottens
f66b4d819b API changes as announced:
* ConfigXml becomes ConfigLoader
  * Containment::(add|remove)ToolBoxTool(QAction *action) becomes
    Containment::(add|remove)ToolBoxAction(QAction *action)
  * Flash becomes FlashingLabel
  * Icon becomes IconWidget
  * PanelSvg becomes FrameSvg

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=877504
2008-10-29 17:46:33 +00:00
Guillaume Pothier
bd7e7b10c9 Added screen management methods to Corona and removed usage of QDesktopWidget in plasmalibs.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=877451
2008-10-29 15:22:38 +00:00
Beat Wolf
df65542e6a Position the toolbox in the right place after moving the panel
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=875532
2008-10-24 18:57:59 +00:00
Aaron J. Seigo
5c8d95bade so that's why we do it for every containment, regardless of screen =P
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=874224
2008-10-21 00:03:06 +00:00
Marco Martin
63a8fba67c show an empty area when dropping applets from applet browser to the
panel, making easier to add applets

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=874087
2008-10-20 18:51:15 +00:00
Aaron J. Seigo
6ef3b851ac update some of these todos
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=873711
2008-10-20 01:41:15 +00:00
Aaron J. Seigo
b31b4da0ba ok, this is a much, much easier way to approach the grouping and doesn't require QDesktopWidget either
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=873703
2008-10-20 00:42:50 +00:00
Aaron J. Seigo
8005bf4a73 nothing actually used this, and it breaks with the whole view/model thing and brings one more dep on QDesktopWidget with it, so good riddence
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=873691
2008-10-19 23:27:58 +00:00
Aaron J. Seigo
3fb4975896 swap the magic number for a constant
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=873689
2008-10-19 23:21:03 +00:00
Aaron J. Seigo
b5df90348f don't load the wallpaper config until we paint. this means that if we have off-screen containments, even with complex wallpapers, they don't take up unecessary memory or delay start up because they won't render the wallpaper until the first paint event.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872755
2008-10-18 01:31:52 +00:00
Aaron J. Seigo
d725fd9413 swap screens with the containment we kick off our screen if we have a screen of our own to trade them
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872382
2008-10-17 05:16:26 +00:00
Aaron J. Seigo
5e987c6ba8 send the containment along with the signal for consitency with similar signals
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872308
2008-10-16 20:54:15 +00:00
Aaron J. Seigo
11536c679b this was a hack, albeit a mildly useful one, but it's in the way now; need to find a better solution for the keyboard shortcuts madness (or just switch to qt 4.5)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872302
2008-10-16 20:30:34 +00:00
Guillaume Pothier
7b201201b0 Fixed positioning of desktop containments' toolbox
BUG: 166770

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872129
2008-10-16 11:47:03 +00:00
Aaron J. Seigo
2118460d27 applet -> widget
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=871125
2008-10-13 23:16:22 +00:00
Allen Winter
a7aebfa60a a bunch more coding style fixes. still some lines longer than 100 chars.
this is definitely helping me find false positives in the Krazy style checker.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870161
2008-10-11 22:48:38 +00:00
Allen Winter
e88e2faa63 first batch of small coding style fixes.
these were found while testing the Krazy style checker, which I'm adapting
for the kdelibs style.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870051
2008-10-11 16:19:04 +00:00
Aaron J. Seigo
06e71be8c3 we no longer need to check for spontaneity; move the trick up to Applet as well to avoid repaints where possible
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=868200
2008-10-05 17:48:44 +00:00
Konstantin Heil
a99aee5e8d Scrolling on desktop travels the virtual desktop in reverge direction than scrolling on the pager. Because scolling on desktop was a little bit confusing: changed scoll direction.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=867906
2008-10-04 22:09:15 +00:00
Aaron J. Seigo
367936cc09 * remove the check for layout() in setFormFactor; that's no longer valid
* emit config needs saving signals when these things change
* only write the changes if the values actually do change

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=865206
2008-09-27 01:54:24 +00:00
Aaron J. Seigo
d732923026 save changes as they happen
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=865205
2008-09-27 01:51:52 +00:00
Aaron J. Seigo
cd7e48a164 a bit less convoluted and does the same thing
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=863697
2008-09-22 21:50:01 +00:00
Aaron J. Seigo
a90457d7a1 only care about mucking about with the focus item if it isn't null
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=863641
2008-09-22 18:35:24 +00:00
Aaron J. Seigo
56a9ad52ce make it harder for people to fall into the temptation of nesting containments
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=863619
2008-09-22 17:50:23 +00:00
Aaron J. Seigo
f505d063e7 and if it isn't acting as a containment, but an applet, then use the standard configuration mechanism as provided by Applet
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=862308
2008-09-18 14:58:06 +00:00
Aaron J. Seigo
c633c8ac57 hook up the containment configuration interface to the generic containment configuration mechanism; now it shows in the toolbox too! whee!
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=859593
2008-09-10 18:51:30 +00:00
Aaron J. Seigo
bf942582e8 support adding the configuration entry to the toolbox
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=859589
2008-09-10 18:42:52 +00:00
Aaron J. Seigo
4ae5e8bdf7 respect "null" as a containment request: no wallpaper
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=858909
2008-09-09 01:16:10 +00:00
Aaron J. Seigo
d404d951f2 one more call using geometry rather than boundingRect
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=858894
2008-09-08 23:08:25 +00:00
Aaron J. Seigo
eed04daf07 should be boundingrect; wallpapers paint relative to the containment at all times
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=858893
2008-09-08 22:56:55 +00:00
Marco Martin
2c2e7ecf3b set a default wallpaper when the user creates a new containment from the
ui

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=858793
2008-09-08 18:38:14 +00:00
Aaron J. Seigo
329b1782f1 better ...
CCMAIL:kossebau@kde.org

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=858370
2008-09-07 21:47:55 +00:00
Aaron J. Seigo
8ef4eaa1d4 don't duplicate this over and over again
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=858359
2008-09-07 21:07:30 +00:00
Aaron J. Seigo
f5168c65de put notmart out of his misery on this one =) let containment tell the world when it's context changes
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=857852
2008-09-06 16:29:47 +00:00
Aaron J. Seigo
99e664d0c5 make is possible to ask for the containment's own context menu
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=857605
2008-09-05 20:06:30 +00:00
Aaron J. Seigo
b244d65ec5 let's keep each paper's config separate from each other, so that when you switch between papers your config is actually saved
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=857511
2008-09-05 15:32:55 +00:00
Aaron J. Seigo
90d21e4b31 be a lot more careful about what we save, when and how. leaves us still with an annoying problem with save/restore of papers at runtime though .. working on that now
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=857505
2008-09-05 15:16:49 +00:00
Aaron J. Seigo
3b314b6578 * delete the wallpaper config group when we change plugins
* save the wallpaper config before moving on if the wallpaper remains the same, so that when we restore the paper later on we're all good and safe

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=857500
2008-09-05 15:01:30 +00:00
Aaron J. Seigo
72aff55a52 it's wheelEvent, not mouseWheelEvent
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=857248
2008-09-05 04:33:40 +00:00
Aaron J. Seigo
d89ad4cba0 context API adjustments
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=857207
2008-09-05 00:22:42 +00:00
Aaron J. Seigo
b3b8ac7ee3 ignore the event if we don't care
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=857154
2008-09-04 20:13:23 +00:00
Benoît Jacob
6d24078bc7 Forward wheel events to the wallpaper
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=857101
2008-09-04 18:11:46 +00:00