Commit Graph

223 Commits

Author SHA1 Message Date
Kai Uwe Broulik
c707f6074c Remove unused functions
You can just use mapToItem(null, 0, 0)
2017-09-18 15:12:45 +02:00
Kai Uwe Broulik
7482bef085 Pass item to rootObject() since it's now a singleton
The "parent" used to be resolved by the place where the utils.js was imported from.
However, it was changed into a singleton and now this didn't work.

BUG: 384776
2017-09-18 15:11:09 +02:00
David Edmundson
7141ad1721 Don't list tab names twice
Summary:
The name (with a correct role) is already exported as a tab

By having the static text internally we get the name twice when we do a
flat review of the controls.

Reviewers: #plasma

Subscribers: plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D7815
2017-09-14 14:50:57 +02:00
Kai Uwe Broulik
d8f1d44a49 Declare AppManager.js as pragma library
It doesn't store any state but contains only functions.

Differential Revision: https://phabricator.kde.org/D6676
2017-07-13 14:27:59 +02:00
Kai Uwe Broulik
1d0a0b5cdf [PlasmaComponents] Remove Config.js
It got redundant and since it wasn't declared as "pragma library" an instance
of this script was created for every ListItem, causing quite some memory consumption.

Reviewed-By: notmart
2017-07-13 14:04:05 +02:00
David Edmundson
06410e779b Fix tab bar layout key handling in RTL
Summary:
Current code will, when mirrored, treat all keys like they're the left
key.

BUG: 379894

Test Plan: Ran plasma in RTL

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D6480
2017-07-03 11:31:46 +01:00
Marco Martin
1aea7bbd5e show show password button also if empty text
like happened in KPasswordWidget, show the show password
button also when there is no text, otherwise is impossible
to know what will be typed, a dot or the actual letter
BUG: 378277
2017-06-09 13:15:46 +02:00
Kai Uwe Broulik
edb05ef989 [ModelContextMenu] Silence warnings
When using a regular JavaScript Array as model and omitting certain roles (e.g. not
having a "text" for a separator) it would throw a warning.

Differential Revision: https://phabricator.kde.org/D5247
2017-03-30 15:03:39 +02:00
Kai Uwe Broulik
8d42e0072f [ModelContextMenu] Use Instantiator instead of Repeater-and-reparent-hack
Differential Revision: https://phabricator.kde.org/D5215
2017-03-29 12:11:02 +02:00
Aleix Pol
54e87fe879 Make sure we display enabled ListItem on hover
Summary:
I just realized there was a weird workaround in plasma-nm where it gets
checked so it's shown.
Properly use the declarative API instead of listening to a ton of signals.

Test Plan: Tested with plasma-nm and org.kde.plasma.notifications plasmoids

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: mart, davidedmundson, plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D4214
2017-01-24 15:47:07 +01:00
David Edmundson
17830b10f8 Remove excessive debug in CommonDialog 2017-01-19 02:29:57 +00:00
Marco Martin
859dcc1403 use PlasmaCore.ColorScope for text as the rest 2017-01-18 15:04:08 +01:00
Marco Martin
12a4709b6c portait prop is not relevant when there is no text
this fixes a binding loop on this property
when there is no label

BUG:374815
Change-Id: I71616a6c86cd4acdaff47f141ed5c676358db496
2017-01-09 16:29:32 +01:00
Bhushan Shah
780be6f4ce Fix the renderType properties for various components
To use isMobile one need to import the QtQuickControls as well in
addition to QtQuickControls.Private

This fixes the warning flood at runtime

CCMAIL: faure@kde.org

I think p-f 5.30.0 tars need to be re-done with this.
2017-01-09 14:50:06 +05:30
Bhushan Shah
324232a745 [declarativeimports] Use QtRendering on phone devices
Summary: Ref T4947

Test Plan: works on desktop at least, haven't tested on phone yet

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T4947

Differential Revision: https://phabricator.kde.org/D3789
2016-12-23 16:37:16 +05:30
Kai Uwe Broulik
a7ccca25ba [TextField] Allow disabling reveal password button through KIOSK restriction
This introduces a new lineedit_reveal_password restriction (similar to lineedit_text_completion)
that disables the reveal password button on Plasma text fields, like the lock screen and WiFi password inputs.

Differential Revision: https://phabricator.kde.org/D3654
2016-12-19 14:20:33 +01:00
Eike Hein
db15022686 Fix logic for arrow handling in RTL locales.
Summary: BUG:373749

Reviewers: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3718
2016-12-18 08:32:27 +09:00
Marco Martin
783f26e628 don't flip tabbar layout if vertical
when the tabbar is vertical, on rtl layout the tabs order should
stay as is, as is rtl, not bottom-to-top

Change-Id: Ia5f1722d5e327207cf584a997dc8073c595c905b
REVIEW:129521
2016-11-21 17:27:17 +01:00
Kai Uwe Broulik
3f17e32a92 [PlasmaComponents TextField] Don't bother loading icons for unused buttons
We kept loading the clear button and reveal password icons even when that option was
disabled and the buttons never visible.

REVIEW: 128753
2016-08-25 22:59:46 +02:00
David Edmundson
98cfdf6b45 Don't redeclare property implicitHeight 2016-08-18 12:06:20 +01:00
David Edmundson
cb9ec94625 Add an optional reveal password button to TextField
Similar to KPasswordWidget in kwidgetaddons

Also fixes:
- the clear button still being clickable when not enabled
- RTL icons
- Updating the right margin correctly

REVIEW: 128660
2016-08-15 14:34:15 +01:00
Kai Uwe Broulik
42193ae631 [TextField] Bind to TextField length instead of text
Copying strings in QML is expensive.

REVIEW: 128550
2016-07-29 15:41:40 +02:00
Marco Martin
8c6f95f2ea add a property separatorVisible
REVIEWED-BY: Kai Uwe Broulik
2016-02-05 16:51:38 +01:00
Kai Uwe Broulik
d9719f1037 [Units] Return at least 1ms for durations
Animators do not reliably work with a duration of 0 as can be seen in the linked bug report.

Upstream bug report: QTBUG-39766

BUG: 357532
REVIEW: 126652
2016-01-17 12:59:30 +01:00
Kai Uwe Broulik
606c7f651d [TabBarLayout] Layout sooner
CHANGELOG: Fix TabBar items being cramped together on initial creation, which can be observed in eg. Kickoff after Plasma start

REVIEW: 125978
2015-11-07 13:15:50 +01:00
Aleix Pol
36288df5ac Fix logic (and warnings) in ModelContextMenu
It was checking that a variable existed, then it used it. Now it works like
the rest of the properties.

REVIEW: 125809
2015-10-26 18:14:41 +01:00
Marco Martin
7cafe26fa0 make PageRow work
enum names aren't anymre available in js files
fix scrollToLevel behavior
2015-10-12 18:19:13 +02:00
Marco Martin
dea284f8f3 use a RowLayout for ToolbarLayout
more reliable.
also put the first and last buttons at the extremes, the others in the middle
2015-10-05 11:41:42 +02:00
Marco Martin
c6804b034d consider devicepixelration in standalone scrollbar
Change-Id: I06e55738cde060f7ff372c039be20f5dad72d070
2015-09-18 20:17:07 +02:00
Kai Uwe Broulik
6995193219 Make model param of clicked signal of var type
When using ModelContextMenu with a JS array the "model" param of the clicked
signal is null because QtObject property can only hold QObject but no JS objects.

CHANGELOG: The onClicked signal of PlasmaComponents.ModelContextMenu now works properly
if model is a JS Array of JS objects

REVIEW: 124910
2015-08-26 10:46:43 +02:00
Kai Uwe Broulik
25748ca575 Support sections in ModelContextMenu
CHANGELOG: PlasmaComponents ModelContextMenu can now create Menu sections

REVIEW: 124909
2015-08-24 23:14:31 +02:00
Martin Klapetek
02f124b120 [plasmacomponents] Make SectionScroller follow the ListView.section.criteria
Now it will show first character only if the ListView has FirstCharacter
set

Change-Id: I6d2451d95e36a9a07eed4168402ac5748e87dcb3
Reviewed-by: Marco Martin
2015-05-07 12:56:49 +02:00
Marco Martin
fe9f515bf5 increase maxAllowedSize a bit
Change-Id: I88ca56d1ac687288e8e780ce43506fb45246d23f
2015-04-28 12:43:49 +02:00
Marco Martin
c22bb8c4a8 don't cut away text
Change-Id: I56cf92d0ac6515ec9deb2c8136ef7e2914d1a529
2015-04-21 11:23:11 +02:00
Kai Uwe Broulik
b7e4669db2 Layout children in TabBarLayout right away
When Component.onCompleted is emitted, all the static children have been created,
thus we can call the layout function right away.

CHANGELOG: Fix TabBar not properly laid out initially, which could be observed in eg. Kickoff

REVIEW: 123106
2015-03-25 18:18:38 +01:00
Kai Uwe Broulik
039b808b07 Use Animator for PageStack transitions
This improves animation smoothness, eg. when switching between heavy system tray plasmoids.

CHANGELOG: PageStack transitions now use Animators for smoother animations

REVIEW: 123102
2015-03-22 22:07:05 +01:00
Kai Uwe Broulik
f186b2938f Use Animator for TabGroup transitions
This reduces stuttering when switching between lazyloaded pages

CHANGELOG: TabGroup transitions now use Animators for smoother animations

REVIEW: 123103
2015-03-22 22:06:29 +01:00
Marco Martin
dd46de10ec export correct Layout.minimumWidth
recalculate size when text on a tab changes
BUG:342964

Change-Id: I7fd17557e92de29a7d1b1e897caf17e60bfe101e
2015-03-20 13:45:37 +01:00
Marco Martin
e754f7bf1a pick the color from colorScope
Change-Id: Iff83658b3d91ffc9ed0f4a9a02db68ade67c82e6
2015-03-13 21:20:39 +01:00
Kai Uwe Broulik
d0c5aa6fc9 Explain magical round ToolButton behavior on the documentation
Reviewed by David Edmundson
2015-02-17 23:21:54 +01:00
Marco Martin
b484b7faf0 document what happens to the page after pop()
Change-Id: I85b6cca525ced119329e1c28807efb6befcb4af3
2015-02-04 13:24:23 +01:00
Marco Martin
c17ed3a107 fix layout in reverse mode
Change-Id: Ib81611f149821fc79669ae191a03daeba840b802
2015-01-27 19:36:58 +01:00
Marco Martin
c1814477fd trigger button switch on mouse wheel
BUG:342778
Change-Id: Idfa06319ac84762040eea07074042061a4bc313c
2015-01-13 12:49:35 +01:00
Marco Martin
bf99d9c03c Merge "move the controls to an independent style" 2014-12-09 13:27:54 +01:00
Marco Martin
7d52397115 move the controls to an independent style
* Adapt the existing controls to be generic enough to work on stock QtQuickControls
* Add missing styles needed for the set to be complete (and applications actually work)

The full list of controls styles is now:
ApplicationWindowStyle
BusyIndicatorStyle
ButtonStyle
CalendarStyle
CheckBoxStyle
ComboBoxStyle
MenuBarStyle
MenuStyle
ProgressBarStyle
RadioButtonStyle
ScrollViewStyle
SliderStyle
SpinBoxStyle
StatusBarStyle
SwitchStyle
TabViewStyle
TableViewStyle
TextAreaStyle
TextFieldStyle
ToolBarStyle
ToolButtonStyle
GroupBoxStyle

Change-Id: Ic5d33bc20c7456d1478c07aca33bda63378d5c05
2014-12-02 15:59:42 +01:00
Sebastian Kügler
b4519bdffb Fix DialogStatus namespace in SelectionDialog
DialogStatus, as in other Dialog variants, can only be accessed through
the PlasmaComponents namespace.

Fixes 3 ReferenceErrors in SelectionDialog and makes it actually work.
2014-12-02 02:05:58 +01:00
David Edmundson
c1b5adf25e Fix documentation linking
Change-Id: I391d1c4c7d0aae63ebf99e19197f20484a78f315
2014-11-27 12:53:14 +01:00
Marco Martin
cb8175f1f6 use PlasmaCore.ColorScope when suitable
It is possible to put a PlasmaCore.ColorScope element, to automatically
change the colors:
if for instance the complementary scope will be set, all labels
descendent of such element would flip their color

Change-Id: I2214aca522eb094cf067d8726c5bf2a7ecbf36b3
2014-11-25 18:27:20 +01:00
Kai Uwe Broulik
f54ff55bc5 Migrate ProgressBar to QtQuick.Controls
Test is enhanced to also cover vertical bars. The ProgressBar does not yet use
the vertical assets since Qt just conveniently rotates the bar for us and
apparently just overriding the entire "panel" component is evil

REVIEW: 121085
2014-11-10 22:09:55 +01:00
Kai Uwe Broulik
65a6861476 Migrate BusyIndicator to QtQuick.Controls
Comes with a test for the seamless pause/resume

REVIEW: 121070
2014-11-09 01:16:30 +01:00