Commit Graph

13515 Commits

Author SHA1 Message Date
Marco Martin
4062a53c9a always have margins in dialogs
always show full margins in dialogs
this is to make things look less cramped with screen and panel edges
since mouse still has to work on screen edges (fitts law)
in that case it forwards mouse events inside the actual content item
so things like menus at the edge of the screen keep working

Change-Id: I4b8a5a5bac92eadbaf7ad5b9b7dc0d5f364888c3
2014-10-21 16:55:38 +02:00
Ivan Čukić
a9262c6fa4 Removed the dead code that used to calculate the direction of a tooltip
The value of the 'dir' variable is quite difficult to calculate,
and it is not used anywhere.

Change-Id: I806a559dde51bdf3b243271fe68ee138faa872f6
2014-10-17 09:31:22 +02:00
Ivan Čukić
e346b50cd8 Removed the call of clearDataForMimeJob on a null pointer
tjob pointer is checked for being null (result of the dynamic_cast)
and then passed to clearDataForMimeJob. The issue can be solved by
replacing tjob with job in the problematic line, but since the
mimeTypeRetrieved method called later already processes jobs that
are not KIO::TransferJob, there is no purpose in doing it here as well.

Change-Id: I863ac41ad66ac3cbceca82adeab85498315a5e42
2014-10-17 09:15:06 +02:00
Marco Martin
adf92d4573 fix css colors
BUG:337317
Change-Id: I5968d6766adbc4678fa94c3d52f6a9674733cfb6
2014-10-16 11:09:59 +02:00
Marco Martin
7f9693746f crash--
BUG:339875
Change-Id: Ic8ab63853fa9b58dd83e1aa868e9599b0e37f09e
2014-10-16 10:45:30 +02:00
Marco Martin
1cb4501a11 remove the old icon when an empty source is set
BUG:339793

reviewer by:Bhushan Shah <bhush94@gmail.com>

Change-Id: I02910e7ec9397c5bb6ca4e5c0ed3793d19aa14e5
2014-10-15 16:11:19 +02:00
Marco Martin
3c860ab43f dd test case
Change-Id: I3af1949b28148652918e28eb76c4733a7bd9650b
2014-10-15 15:45:29 +02:00
Marco Martin
c32d93731d add icon for spacer
BUG:337995
Change-Id: I1c753298f5d2deb43296eaec94d765f1575f47ce
2014-10-15 15:40:27 +02:00
Aleix Pol
7a4998046e Adopt QuickAddons in plasma-framework
Removes the code that was moved to QuickAddons

REVIEW: 120596
2014-10-15 13:22:27 +02:00
l10n daemon script
b65201b735 SVN_SILENT made messages (.desktop file) 2014-10-15 08:33:00 +00:00
Aleix Pol
dc59a397f1 Also check the style for cmake modules 2014-10-14 15:45:15 +02:00
Aleix Pol
8df7801d3b Don't crash if the plasmoid wasn't properly loaded
If d->applet->package().isValid(), then d->qmlObject->mainComponent()
is null.
This makes Plasma crash when a faulty plasmoid is loaded.

REVIEW: 120581
2014-10-14 15:45:14 +02:00
Marco Martin
71444986ee respect stylesheet
Change-Id: Ib865c2097d17f5892b250ad2f013c28eadef3e2a
2014-10-14 15:44:41 +02:00
Eike Hein
d3a9b5bb1f Add margins.horizontal/vertical helpers that return added up margins along one axis.
Adding up margins along the horizontal or vertical axis is often
done to calculate sizing or spacing. This tends to result in scary-
long and bug-prone expression being bound to props, since nobody
seems to like to blowing them up into a code block with a separate
variable assignment. This aims to increase the readability of com-
plex expressions by summing axis margins into a single operand.

Change-Id: I39a37dde80b9314da0c69f3b33d26d26a9ff54d1
2014-10-13 15:14:56 +02:00
Marco Martin
f5fb0dbc24 consider the case of fallback as well
consider the case of fallback as well when we are searching for a texture

reviewed by: Eike Hein <hein@kde.org>

Change-Id: I1faa119f9b3486d21ebd07a294b5063a896d7af1
2014-10-13 14:19:36 +02:00
Marco Martin
aa7b3ff773 typo
Change-Id: Ia8dd4676cb45166bfc5f5e55b3c30a15f895d39f
2014-10-11 21:04:10 +02:00
Marco Martin
691905b1a1 fix the test
before 419b344b6 the size of the dialog was wrong, making positioning
of it actually different.
the new value, 71 is actually the correct one.

to make sure to catch similar cases, adds a test on the dialog size and margins as well

Change-Id: I035c66a6745e0e9f265f63cee450fec7a645654d
2014-10-11 20:58:34 +02:00
Marco Martin
66a1a497ef add a property to tell if fallback happened
add a property in Svg (and framesvgitem) to tell if the current theme
has this image, or if some fallback did happen
useful for items that are better not displayed than showing the potentially different
default theme

Change-Id: Ib914c0e196c5c941d35d9a600cc7d38818fc754f
2014-10-10 17:36:44 +02:00
Marco Martin
68eadae6c8 never reparent old mainItems
This is not completely correct.
however, when reparenting the mainItem containming window thumbnails
it causes serious graphical artifacts, like the "lost fonts" on
nvidia and fglrx

Change-Id: Id194f5e7863e4ed71792835a9a3cf9c6e4fa70ee
2014-10-08 14:32:52 +02:00
Marco Martin
9796f043b7 Revert "set flags again on QEvent::Expose"
This reverts commit 65ab514a2c.
2014-10-08 14:06:10 +02:00
Marco Martin
65ab514a2c set flags again on QEvent::Expose
is the only event we get we know the window will already be visible
to set the flags to have actually any effect

BUG:335572
Change-Id: Id1b69a894295af59a681946df9d14ff7ed316526
2014-10-08 13:57:37 +02:00
Martin Klapetek
cbe50c408b Add "..." after "<Applet Name> Settings" to comply with HIG
Reviewed-by: Marco Martin

BUG: 339756
2014-10-07 17:45:10 +02:00
Marco Martin
ad03d0bb14 try to restore the original parent if possible
setting a null parent to mainitems seems to screw up with their QQmlContext

the problem can be seen with the taskbar, that after fiddling with tooltips a lot, (like switching between pager and a task) it loses thumbnails and it starts to output on stderr
about ids that aren't accessible anymore.

Change-Id: Ibbb6d270fd2e20b5b6745e228f4010b74d3266c9
2014-10-06 12:33:16 +02:00
Kai Uwe Broulik
7cf9fb93d8 Hide ProgressBar inner item when value is 0
This fixes the situation where an empty progress bar still shows a little spot on the left.

REVIEW: 120489
2014-10-04 22:41:40 +02:00
Kai Uwe Broulik
759b75314d Add indeterminate ProgressBar to test
REVIEW: 120491
2014-10-04 22:40:27 +02:00
l10n daemon script
ab98c3a8c8 Upgrade ECM and KF5 version requirements for 5.3.0 release. 2014-10-03 17:57:55 +00:00
Marco Martin
046a419493 don't tile
buttons have a gradient

Change-Id: Icf279d0a2e32dd4faf587057f584a7c3461a8586
2014-10-03 19:24:21 +02:00
Marco Martin
2a582e6b4a make sure the layout timer isn't running
when maintintem changes

Change-Id: I59d1930caf2686e1fa9a1fb0510e15630898d99f
2014-10-03 19:10:31 +02:00
Marco Martin
1015d51997 adjust margins
Change-Id: If6147f112bdb441f0c678bfa975f687035ec2111
2014-10-03 18:59:23 +02:00
Marco Martin
717153ebb4 lightly less border contrast on dark themes
Change-Id: Ic60ab2ddf6bdb3adace2fe6127c0723d675941bc
2014-10-03 18:52:12 +02:00
Marco Martin
ab69d1029c guard mainItem of resize
crash--

Change-Id: Ifa08f78573d4eed690c23e93f87d1cf0b3c033ef
2014-10-03 13:51:57 +02:00
Marco Martin
419b344b6d make sure the theme is loaded on item sync
Change-Id: Iea920b208c9e84bc9fb3c6c3c39e4362782f0b5f
2014-10-02 16:17:35 +02:00
David Edmundson
094a1c105d Add testcase for textfield
Change-Id: I579ab98a86e674cd1d6bd6c43c9c369259536248
2014-10-02 15:31:34 +02:00
Andrew Lake
98af054c28 add missing tooltip icons used by network manager
BUG:339547
2014-10-01 22:35:24 -07:00
Andrew Lake
0cf3c74a7f fix hardcoded colors 2014-10-01 15:06:21 -07:00
Andrew Lake
69ff7e5281 better 32x32 klipper icon, updated reboot icon to match main icon theme. 2014-10-01 13:58:28 -07:00
Marco Martin
018a7a3c6d smaller corner shadows
lets having a smaller windows without visible glitches

Change-Id: I91661e1f427344d195cc4b98b7588a48a20b36f4
2014-10-01 19:07:43 +02:00
Sebastian Kügler
cccfdf5a9e Proper color for placeholder text in TextFieldStyle
Fixes unreadable placeholder text in TextField with dark themes.

Reviewed-by:Kai Uwe Broulik
2014-10-01 18:04:04 +02:00
Marco Martin
43e3359c68 fix mask for dialogs and tooltips
Change-Id: I3b41f84395fa3e554416193c60167c6df21609c5
2014-10-01 15:05:42 +02:00
Marco Martin
32a0be3d1c remove extra margins
Change-Id: I1212d69583a06871620ccf209ab8fbf766b6033e
2014-10-01 14:20:01 +02:00
David Edmundson
764cd182cc Merge "Floor devicePixelRatio in ProgressBar before use" 2014-10-01 11:45:09 +02:00
Marco Martin
2fcc325abf Merge "Warning --" 2014-10-01 10:04:17 +02:00
Andrew Lake
e5bc62330f Add battery-charging, battery-discharging, battery-100, battery-missing for tooltip icons.
- Note: The code changes are needed to use battery-discharging icon
2014-09-30 20:29:56 -07:00
David Edmundson
4d8f9c55c0 Floor devicePixelRatio in ProgressBar before use
This matches what happens in the C++ SVG code

Change-Id: Ide914751d3ba18d7e4d62c4872651998bc226900
2014-10-01 03:16:07 +02:00
David Edmundson
4233f7f38e Warning --
Change-Id: I7649fc9f9209816be909217f1c71e7bbe60ab10f
2014-10-01 03:04:52 +02:00
Marco Martin
5d639b0a00 dialogtest is valid only on X11
Change-Id: I20fc562d08545a242d36d2e87776be56f8eea52b
2014-09-30 19:03:54 +02:00
Marco Martin
656582eb66 make sure the cache dir is empty
Change-Id: I916bc173fe3b257705b698d1fe66c5b2bdeb8d3e
QStandardPaths::enableTestMode and clean the cache folder
2014-09-30 18:12:26 +02:00
Marco Martin
ff9703aabf consistent border size
make the dialogs borders the same for composite and non composite mode
more consistent behavior -and- fixes a test on openbox

Change-Id: Idd687a1f3b44f89d35886e1f9a86c2543741cbdb
2014-09-30 17:48:53 +02:00
Marco Martin
792c39a9bb Merge "queue change of minimum/maximum size" 2014-09-30 17:02:46 +02:00
Marco Martin
afe0524fa7 queue change of minimum/maximum size
the layout size hints can change all together, in any order possible.
the only way to have a deterministic behavior is to compress them
and do the sync of the size all at once.
also being sure to do a single adjustGeometry (one X call) instead of
separate setWidth/setHeight

a test for the issue is dialog_resizeWithParent.qml

BUG:339478
Change-Id: Ia7c3c55e40ff89971beb734dcd205df05bfba687
2014-09-30 16:34:21 +02:00