Commit Graph

30 Commits

Author SHA1 Message Date
Nate Graham
5447cef2d8 Port to singleton Units
The context property version is slower to access and won't be supported
in Qt6. Let's port away from it and use the singleton version instead.

Here was my full process for making this change:

1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
2. Verified no more occurrences with `grep -r " units."`
3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+   " | grep "//"`
4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done` (one needed the import)
2021-03-07 13:34:47 +00:00
Andreas Cord-Landwehr
d10afb5d2a plasma-framework: Convert copyright statements to SPDX expressions 2020-08-13 19:08:54 +00:00
Nate Graham
1a2e4023b0 Correct QT Bug URL for font rendering hack
This makes it clear which version of Qt (5.14) Frameworks has to be
able to depend on before we can remove the font rendering hack.
2020-07-14 16:35:28 -06:00
Nate Graham
5ef8b1a189 Use font: instead of font.pointSize: where possible
Summary:
Otherwise we're discarding style information possibly set in
the user's small font choices when we want to set a smaller
font.

Test Plan: Stuff that's suposta look small still looks small

Reviewers: #plasma, cblack

Reviewed By: #plasma, cblack

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D29436
2020-05-19 10:18:23 -06:00
Nate Graham
6b8f114284 Port away from Title and towards level 1 Heading
Summary: `Title` is deprecated.

Test Plan: No visual changes anywhere; level 1 Heading is identical in appearance

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27350
2020-02-21 08:39:25 -07:00
Yuri Chornoivan
052a81f755 Fix minor issues found by EBN and typos 2019-11-10 12:06:10 +02:00
Nathaniel Graham
a21bc11fe1 Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set
Summary:
When `PLASMA_USE_QT_SCALING=1` is set, Plasma uses native Qt scaling. This works fine for integer scale factors, and fixes a lot of bugs (see [[https://bugs.kde.org/show_bug.cgi?id=356446|Bug 356446]]) but it introduces a new one: with non-integer scale factors, text becomes blurry and pixellated because of a bug in `Text.NativeRendering`: https://bugreports.qt.io/browse/QTBUG-67007

QQC2-desktop-style forces the use of `Text.QtRendering` rendering for non-integer scale factors, successfully working around the problem. But PlasmaComponents QML objects don't implement the same workaround, so we see the issue in Plasma. This patch fixes that, and gets us one step closer to being able to use Qt scaling in Plasmashell.

There is no effect when `PLASMA_USE_QT_SCALING=1` is not being used.

FIXED-IN 5.13
BUG: 391691
BUG: 384031
CCBUG: 386216
CCBUG: 391695
CCBUG: 391694
CCBUG: 385547
CCBUG: 391692
CCBUG: 356446

Test Plan:
Before: `PLASMA_USE_QT_SCALING=1` set, 1.2 scale factor: Plasma text looks awful:
{F5749797}

After: `PLASMA_USE_QT_SCALING=1` set, 1.2 scale factor: Plasma text looks amazing!
{F5749798}

Note that we still get sub-pixel anti-aliasing and good kerning. There appear to be no layout regressions.

Without both `PLASMA_USE_QT_SCALING=1` and a non-integer scale factor set, there is no visual change compared to the status quo.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: mart, broulik, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D11244
2018-03-16 16:26:38 -06:00
Bhushan Shah
780be6f4ce Fix the renderType properties for various components
To use isMobile one need to import the QtQuickControls as well in
addition to QtQuickControls.Private

This fixes the warning flood at runtime

CCMAIL: faure@kde.org

I think p-f 5.30.0 tars need to be re-done with this.
2017-01-09 14:50:06 +05:30
Bhushan Shah
324232a745 [declarativeimports] Use QtRendering on phone devices
Summary: Ref T4947

Test Plan: works on desktop at least, haven't tested on phone yet

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T4947

Differential Revision: https://phabricator.kde.org/D3789
2016-12-23 16:37:16 +05:30
Sebastian Kügler
993d4e56c0 More refined font tests in testtheme applets 2014-03-26 01:10:41 +01:00
Sebastian Kügler
0b4951c5b7 Add tests for font metrics 2014-03-26 00:11:30 +01:00
Sebastian Kügler
78910dfa66 remove spurious items in theme example 2014-03-25 22:52:12 +01:00
Marco Martin
91642b0868 qtextracomponents->kquickcontrolsaddons 2014-03-25 17:10:25 +01:00
Martin Klapetek
48cc5e9fcd Add missing Layouts import 2014-02-24 11:51:48 +01:00
Marco Martin
3858044d25 Merge branch 'mart/AppletAttached'
Conflicts:
	src/declarativeimports/core/dialog.cpp
	src/scriptengines/qml/plasmoid/containmentinterface.cpp
2014-02-06 13:16:11 +01:00
Marco Martin
308f59bc68 port to new api 2014-02-04 17:29:28 +01:00
Sebastian Kügler
78d14a00c5 Clean removed API from units test 2014-02-03 16:42:29 +01:00
Sebastian Kügler
2a217dff0a Remove unneeded API
- dpi(QQI*) and printScreenInfo(QQI*) goes away, they're mainly useful for
  testing.
- setDevicePixelRatio goes private
- clarify DPI computation
2014-01-28 01:15:38 +01:00
Sebastian Kügler
0928741416 A bit more text, conditional alignment 2014-01-27 18:22:54 +01:00
Sebastian Kügler
dfd1b554ad disable enormous icon for now, it's a bit annoying at high settings :) 2014-01-25 03:41:45 +01:00
Sebastian Kügler
f5d2066e76 Icons to test icon sizing in theme test plasmoid 2014-01-25 02:51:56 +01:00
Sebastian Kügler
2a3a546f80 Play around with devicePixelRatio
This shows how the UI can react when used with different
devicePixelRatios.
2014-01-23 04:07:05 +01:00
Sebastian Kügler
979dc0c25f Add test for devicePixelRatio 2014-01-23 02:18:58 +01:00
Sebastian Kügler
f6e495c76c Spacing moves from theme to units 2014-01-23 01:30:28 +01:00
Sebastian Kügler
b89902c3e7 use units.* in testtheme applet
These calls have moved out of theme.
2014-01-22 01:35:20 +01:00
Sebastian Kügler
53b4608327 Port examples to units.iconSizes 2014-01-22 00:41:02 +01:00
Sebastian Kügler
63cbffeee7 Show units in theme test plasmoid 2014-01-21 23:45:12 +01:00
Sebastian Kügler
13a6a38628 Some debugging for gridUnit 2014-01-21 17:55:47 +01:00
Sebastian Kügler
caa975c7bb Add units.dp and units.gu to testtheme 2014-01-21 17:32:49 +01:00
Sebastian Kügler
2d8841b23f Small applet to test especialy the theme's sizing and DPI
installed as org.kde.example.testtheme, called "Theme Test"
2014-01-21 00:59:59 +01:00