Commit Graph

3736 Commits

Author SHA1 Message Date
Alex Merry
13116aaea9 Don't crash on weirdly invalid SVGs.
The particular problem I was having was that frame->leftWidth was 0 and leftHeight was 0, but
frame->rightWidth was > 0.  And, while trying to paint a 0x0 pixmap is apparently fine
(because QPixmap::isNull() is just (QPixmap::width() == 0)),
QPainter::drawTiledPixmap() tries to do 0 % 0 if you pass it an 8x0 pixmap (which is an
arithmetic error).

And this was happening in KSMServer when displaying the shutdown dialog.
Cue weird behaviour when trying to log out or shut down.


svn path=/trunk/KDE/kdelibs/; revision=909140
2009-01-11 03:48:29 +00:00
Marco Martin
eb7588ae9a forward also editingFinished
patch by Dario Andres
BUG: 180261

svn path=/trunk/KDE/kdelibs/; revision=909009
2009-01-10 19:35:29 +00:00
Chani Armitage
c11707b2ce apparently it's bad to compare to QSize()
svn path=/trunk/KDE/kdelibs/; revision=908661
2009-01-10 04:16:26 +00:00
Chani Armitage
ebfc550c11 a default size for scripted applets, because they aren't allowed to do anything themselves before init (and this is the one thing that *must* be done before init)
svn path=/trunk/KDE/kdelibs/; revision=908612
2009-01-10 00:33:38 +00:00
Aaron J. Seigo
e3745c680a plasmoids -> widgets in this case
svn path=/trunk/KDE/kdelibs/; revision=908605
2009-01-10 00:10:33 +00:00
Alex Merry
9c1570f13e apidocs fixes.
Remember to document ALL parameters to methods.  They may seem obvious to you, but I had to look at the code for at least two of the methods in order to document their parameters correctly.

*waves stick of EBN-ness*


svn path=/trunk/KDE/kdelibs/; revision=908604
2009-01-10 00:08:31 +00:00
Aaron J. Seigo
32d2b4c4c9 small fixes for dragging; i don't think they warrant a backport, though
svn path=/trunk/KDE/kdelibs/; revision=908503
2009-01-09 20:45:28 +00:00
Aaron J. Seigo
c5e44c35d2 if the applet is already in another containment, don't re-animate it as if it were new
svn path=/trunk/KDE/kdelibs/; revision=908501
2009-01-09 20:44:53 +00:00
Alexis Ménard
4e6da919f3 QImage.fill take a uint not a QColor so this color (Qt::transparent enum with 19 as a value) is invalid.
svn path=/trunk/KDE/kdelibs/; revision=908392
2009-01-09 16:50:27 +00:00
Rob Scheepmaker
aea9e0e6d8 Move the QGL resize hacks from extender to extenderapplet. The only applet atm for which this hack is necesarry is actually extenderapplet, in the future we will have better layouts, and it won't be necesarry at all, and for now it avoids breaking panel layouts when removing the last extenderitem from an extenderapplet.
svn path=/trunk/KDE/kdelibs/; revision=908195
2009-01-09 13:13:57 +00:00
Anne-Marie Mahfouf
60fad5ba0b fix test (fix .desktop install path and read() path)
svn path=/trunk/KDE/kdelibs/; revision=908084
2009-01-09 09:23:35 +00:00
Aaron J. Seigo
4e7e534103 * add actions in the order they are added, not alphabetically by name (?!)
* remove actions if they get deleted
CCBUG:30042

svn path=/trunk/KDE/kdelibs/; revision=907996
2009-01-09 02:15:23 +00:00
Aaron J. Seigo
58420aae62 clear the current widget when an widget is unregistered; solves a crash where the task widget disconnects *all* signals to items before deleting them, thus preventing the destroyed(QObject*) signal from getting through. it was calling unregisterWidget, but that wasn't clearing the current widget -> POOF!
CCMAIL:faure@kde.org
BUG:179819

svn path=/trunk/KDE/kdelibs/; revision=907981
2009-01-09 01:15:39 +00:00
Stephan Kulow
f9abcd96e4 anoter case of useless warnings
svn path=/trunk/KDE/kdelibs/; revision=907540
2009-01-08 11:32:55 +00:00
Stephan Kulow
744f3ef721 avoid tons of warnings for empty sizes
svn path=/trunk/KDE/kdelibs/; revision=907537
2009-01-08 11:28:58 +00:00
Stephan Kulow
6e8e615e73 don't create "QEventDispatcherUNIX::unregisterTimer: invalid argument"
svn path=/trunk/KDE/kdelibs/; revision=907536
2009-01-08 11:27:39 +00:00
Aaron J. Seigo
6156b46110 tell the config loader to write its config as well during calls to save()
svn path=/trunk/KDE/kdelibs/; revision=907296
2009-01-07 20:34:34 +00:00
Aaron J. Seigo
b5456b851c bump the minor version number for 4.3
svn path=/trunk/KDE/kdelibs/; revision=907268
2009-01-07 19:15:01 +00:00
Davide Bettio
08104d35ba Added Plasma::SpinBox.
svn path=/trunk/KDE/kdelibs/; revision=907258
2009-01-07 18:54:43 +00:00
Aaron J. Seigo
e009bc7382 protect access to toolbox, when used with containments that don't create one or turn theirs off
BUG:179909

svn path=/trunk/KDE/kdelibs/; revision=907205
2009-01-07 16:42:12 +00:00
Aaron J. Seigo
fe0acf8202 clean this up while we still can. not sure how this one slipped by us, but it's been on my list for a week; no actual logic changes, just cleans out the header of crud that doesn't belong.
svn path=/trunk/KDE/kdelibs/; revision=906780
2009-01-06 21:11:54 +00:00
Aaron J. Seigo
8620f483d8 always make a layout no matter what
svn path=/trunk/KDE/kdelibs/; revision=906713
2009-01-06 18:08:58 +00:00
David Faure
eb686845cb enable-final and compiler warnings fixed
svn path=/trunk/KDE/kdelibs/; revision=906696
2009-01-06 17:06:26 +00:00
Marco Martin
88f9436dbd don't trust size hints, they lie
this makes tooltip sliding a bit more predictable

svn path=/trunk/KDE/kdelibs/; revision=906676
2009-01-06 15:48:54 +00:00
Laurent Montel
eebb6178a5 Fix iterator
svn path=/trunk/KDE/kdelibs/; revision=906617
2009-01-06 13:09:05 +00:00
Script Kiddy
0ced881246 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdelibs/; revision=906578
2009-01-06 12:50:41 +00:00
Aaron J. Seigo
8c8e40c194 if parented to an applet and the appet has a package, use it.
svn path=/trunk/KDE/kdelibs/; revision=906378
2009-01-06 03:45:44 +00:00
Aaron J. Seigo
a9cc2e29b6 provide access to config needs saving
svn path=/trunk/KDE/kdelibs/; revision=906373
2009-01-06 03:02:22 +00:00
Aaron J. Seigo
cf32d4770d make it easy to get at items and values by name
svn path=/trunk/KDE/kdelibs/; revision=906335
2009-01-05 23:27:29 +00:00
Simon Edwards
102cd88d29 BUG: 178354
StyleOption isn't being exported correctly on some versions of gcc.


svn path=/trunk/KDE/kdelibs/; revision=906246
2009-01-05 19:56:30 +00:00
Marco Martin
f3cdd2086b some Q_INVOKABLEs to be used in scripts
svn path=/trunk/KDE/kdelibs/; revision=906199
2009-01-05 19:09:24 +00:00
Aaron J. Seigo
8dd6e79e56 * make it possible to get a list of installed packages by path rather than package name
* allow the basePath to be a symlink

svn path=/trunk/KDE/kdelibs/; revision=906191
2009-01-05 18:49:54 +00:00
Aaron J. Seigo
be4c8c2c5e if an applet overrode configChanged (it is virtual), the keyboard shortcuts wouldn't get picked up; so move that all to a private slot and now configChangedcan be safely used instead of connecting up to the dialog signals yourself as an added bonus
svn path=/trunk/KDE/kdelibs/; revision=906175
2009-01-05 18:08:14 +00:00
Aaron J. Seigo
d8c68f8d5f update the icon when the svg changes
svn path=/trunk/KDE/kdelibs/; revision=906159
2009-01-05 17:34:40 +00:00
Aaron J. Seigo
7648db2c3a remove from build
svn path=/trunk/KDE/kdelibs/; revision=905831
2009-01-05 08:32:27 +00:00
Aaron J. Seigo
22bc5e8a42 no point in having a class with just one consumer (esp now that we require BC)
svn path=/trunk/KDE/kdelibs/; revision=905828
2009-01-05 08:28:23 +00:00
Aaron J. Seigo
0fc67ce435 no point in having a class in the main lib for just one consumer (esp now that we require BC)
svn path=/trunk/KDE/kdelibs/; revision=905827
2009-01-05 08:27:53 +00:00
Aaron J. Seigo
a2ea13a973 bring back ctrl-overrides-aspect-ratio-mode
svn path=/trunk/KDE/kdelibs/; revision=905774
2009-01-05 01:08:40 +00:00
Marco Martin
a2fe3d80af don't call setCurrentIdex a second time by calling
d->tabProxy->native->setCurrentIndex(index) too early

svn path=/trunk/KDE/kdelibs/; revision=905666
2009-01-04 20:04:37 +00:00
Aaron J. Seigo
35304c269d revert #898716 as it regressed bug #167430, fix the problem by not transforming the svg in FrameSvgPrivate::updateSizes
CCBUG:167430

svn path=/trunk/KDE/kdelibs/; revision=905645
2009-01-04 19:07:46 +00:00
Aaron J. Seigo
b40732d7ab don't change the current tab again, otherwise current==old and bad things happen ;)
svn path=/trunk/KDE/kdelibs/; revision=905635
2009-01-04 18:43:30 +00:00
Alexander Neundorf
1daf22596d If the intention was that this can be built as a separate project, this works now.
Alex

CCMAIL: <aseigo@kde.org>


svn path=/trunk/KDE/kdelibs/; revision=905621
2009-01-04 18:15:55 +00:00
Aaron J. Seigo
fd093720ef a bit more helpful debug output for future such problems
svn path=/trunk/KDE/kdelibs/; revision=905618
2009-01-04 18:12:27 +00:00
Aaron J. Seigo
2b8a8ceec4 escape == hide
svn path=/trunk/KDE/kdelibs/; revision=905313
2009-01-04 07:59:55 +00:00
Aaron J. Seigo
d4bb3c790a no need to focus an applet twice
svn path=/trunk/KDE/kdelibs/; revision=905312
2009-01-04 07:59:10 +00:00
Script Kiddy
d282afc3ad SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdelibs/; revision=905052
2009-01-03 16:29:50 +00:00
Marco Martin
7031c9a7c4 make the Wallpaper section of metadata.desktop actually work
svn path=/trunk/KDE/kdelibs/; revision=904433
2009-01-02 10:52:14 +00:00
Marco Martin
47c511c86c build on arm
svn path=/trunk/KDE/kdelibs/; revision=904274
2009-01-01 19:17:53 +00:00
Marco Martin
786bd0be2a draw the black block only is there is no svg background
svn path=/trunk/KDE/kdelibs/; revision=903932
2008-12-31 17:30:52 +00:00
Marco Martin
17bd4d2e99 use the svg background as default
svn path=/trunk/KDE/kdelibs/; revision=903928
2008-12-31 17:19:48 +00:00