Check for QString compares to ""... OOPS! 1 issue found!
./libs/plasma/widgets/lineedit.cpp: line#178 (1)
Do not compare a QString to "". Instead use the .isEmpty() method. For example, if(str == "") becomes if(str.isEmpty())
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=679628
and const don't like me
so i offer you
this apology:
i promise to try
to remember the friend
who prevents us from mucking
things up in the end
all hail const!
my poetry sucks!
the end. <3
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=679514
- add setDrawStandardBackground(bool) to get our common background
- make paint private and introduce paintInterface (with the same params) instead
this should make standardizing looks a bit easier and give us a way to paint the on-hover applet interface. we may need to do the same with boundingRect?
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=679036
obviously this is fairly broken as now applets can't provide right click menus for anything. i have some thoughts on how to fix this but need to consider it more.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=678566
i introduced a new enum in the Plasma namespace, ItemType, so we can keep track of these id's centrally.
however, the right click mechanism is rather broken in its implementation; we need a way to offer a centralized menu on appets no metter where they are clicked.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=678562
and it is empty, the can be "defaultText" that will be displayed. See
dict applet for example.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=678514
* create button applets not icon widgets on drop
honestly, not sure i like the qstringlist of argument approach, but that's what klibloader gives me
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=677941
however, making them items makes it possible to drag children outside of their parents (c.f. the button applet) which causes another set of problems. i'll look into this tomorrow though. it's 01:00 and i was trying not to work on kde tonight.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=677904
the idea is that you register an element animation and get back an id. you can associate a pixmap with that id and off you go. the item gets update() calls whenever the anim changes and you can fetch your precious little pixmap back with a call to animationResult.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=677782
* collapse all the frame rate methods into two (one for element anims and one for whole item anims) which take the Phase enumerations
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=677781
* don't click when moving (either the icon or the mini buttons)
* only show the buttons on hovered states, allowing for proper button/hover/pressed painting
* try and avoid unecessary if/else's and other codedamage
* get rid of some dead code
now it's about ready to be phased =)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=676842
* show the button(s) in .2s rather than the very slow feeling .5s
* don't leak the timeline
* don't connect to the timeline signal more than once
* comment in code that is ifdef'd out anyways
* don't set the svg element for fg and bg unless it exists
* remove some dead code
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=676786
* passing a null or invalid QVariant to DataSource::setData now results in the removal of the entry if it exists
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=676783
