Commit Graph

40 Commits

Author SHA1 Message Date
Martin Klapetek
76186339f6 [libplasma] Add categorized debug output 2015-12-15 16:56:40 -05:00
Marco Martin
ea924b1469 port libplasma away from sycoca as much as possible
this ports most of libplasma away from sycoca, using instead
a combination of KPluginLoader and KPackage::PackageLoader instead
(so eventually using their own little caches instead of the
global sycoca cache)
a kservicetypetrader call is left in the loading of
containmentactions since is the only way to make an older
workspace still work, but is only a fallback, so containmentactions
in plasma-workspace can be ported eventually as well

Change-Id: Ie9579c3e01284f6d97043e22d01bbe63d3c3f45a
REVIEW:123626
2015-05-07 16:26:37 +02:00
Marco Martin
a629fe4d8f migrate to KPackage
Plasma::Package internally uses KPackage, being a pure wrapper.
old client code and old packagestructures still work using the wrapper.
old workspace code that is not directly using kpackage continues to work correctly

Change-Id: I05f95e8d05e3b67759973c4009e3753c61b1dcce
2014-12-29 13:56:52 +01:00
Marco Martin
8c8bd49130 Merge branch 'mart/packageFallback'
REVIEW:120029
2014-09-01 20:59:22 +02:00
Marco Martin
6be2e9d46d use non const pointers 2014-09-01 19:23:18 +02:00
Marco Martin
5db7db4ae2 crash-- 2014-09-01 16:26:34 +02:00
Marco Martin
5ceb8d1197 add an autotest for fallback
correct a couple of problems the test catched
2014-09-01 15:51:05 +02:00
Marco Martin
55a6095138 use Floyd cycle detection 2014-09-01 15:15:54 +02:00
Marco Martin
21cf68dbd2 set directly the fallback package not its path 2014-09-01 14:54:10 +02:00
Marco Martin
aba4dcb915 introduce setFallbackPackagePath
the fallback package would then be decided by the packagestructure
2014-09-01 14:00:06 +02:00
Aaron Seigo
faf75a95e5 ws for readability
REVIEW:119992
2014-08-29 17:24:43 +02:00
Marco Martin
5b9bb128d8 ckeck for loops or too deep fallback chains 2014-08-27 17:39:32 +02:00
Marco Martin
11094417a3 delete the fallback 2014-08-22 19:27:09 +02:00
Marco Martin
e0db15c96d crash--
use a pointer, so we don't do infinite stack recursion

create the fallback in the proper place
2014-08-22 19:25:49 +02:00
Marco Martin
d369782ae1 ntroduce the concept of package fallback 2014-08-22 18:48:26 +02:00
Aaron Seigo
928d5e63a5 bool Package::hasValidStructure() const
needed to differentiate between packages with structures and without
before path is set
2014-08-08 14:12:22 +02:00
Aaron Seigo
3e61b26178 better variable naming for clarity 2014-08-08 14:12:22 +02:00
Aaron Seigo
b99001ace4 typos in comments 2014-08-08 08:25:27 +02:00
Aaron Seigo
b4f4515d2a detach on file/directory definition add 2014-08-08 08:25:27 +02:00
Aaron Seigo
402825b301 after detaching, fetch the item from the collection again
fixes setting these values on a copy of the package
2014-08-08 08:25:26 +02:00
Marco Martin
9ba599e1b9 packages with Hidden=true metadata are invalid
This originates from the request of downstreams to hide packages that are still installed.
why should be easier than not installing them i don't know, *but* semantically I think it makes sense act as if the package was not existing when the metadata says it's hidden

REVIEW:119329
2014-07-17 12:30:43 +02:00
Marco Martin
4fd0af246d make package::uninstall actually work 2014-06-02 16:38:50 +02:00
Sebastian Kügler
249c1e1c93 Less warnings at runtime
It's quite common to try loading a package in order to check if it's
valid. No need to litter the console with that.
2014-05-23 18:41:50 +02:00
Kevin Ottens
72ba7b4146 Apply the astyle-kdelibs script 2014-04-26 01:48:37 +02:00
Sebastian Kügler
1bfbee809e const-ref in foreach, clean up debugging 2014-02-04 02:18:28 +01:00
Sebastian Kügler
9e491920e5 Only search for metadata.desktop when necessary 2014-02-02 02:25:08 +01:00
Sebastian Kügler
fa7ae03867 Catch packages zipped into subdirectory
This is a pretty common thing, as most zipping tools put the contents
into a subdirectory by default.

Fixes theme package installation.
2014-02-02 02:18:54 +01:00
Aleix Pol
6c82a1ee86 Reduce compiler warnings
Remove unused and deprecated headers
Port some K_GLOBAL_STATIC to Q_GLOBAL_STATIC
2013-12-09 16:50:18 +01:00
Marco Martin
d7aa34cc6c implement uninstall() 2013-10-22 11:20:42 +02:00
Sebastian Kügler
8915fd4004 Show package path in warning 2013-09-03 03:25:24 +02:00
Sebastian Kügler
bcbfea3576 Less debug 2013-08-27 04:27:48 +02:00
Kevin Ottens
0e590217f8 Port away from kdebug 2013-07-30 08:05:09 +02:00
Sebastian Kügler
a426264037 fix package root for wallpapers, makes it find the metadata, add debug 2013-04-26 23:48:50 +02:00
Marco Martin
53c161fb58 packages without structure are invalid 2013-03-05 14:23:52 +01:00
Sebastian Kügler
90b022435a Make validation of zipped packages possible
- move the unpack block into its own function
- unzip if necessary, and point validator and metadata loader at this
  function
- manually delete the tempdir, to keep it as long as the Package is
  alive

This patch makes it possible to upgrade packages from .plasmoid files.
2013-02-27 06:46:28 +01:00
Sebastian Kügler
c8202da160 update sycoca after uninstalling, debug-- 2013-02-27 03:36:53 +01:00
Aaron Seigo
dcc4c58bf7 keep the trailing slash as long as the package is a dir
also, use chop :)
2013-02-18 12:22:35 +01:00
Sebastian Kügler
bbf7e910ec Fix loading plugininfo from file
Remove trailing slash from the path as it might point to a file, in
which case the file info lookup will fail.
2013-02-18 04:08:00 +01:00
Aaron Seigo
aea5627ef4 fix packagestructure test 2013-02-15 15:16:54 +01:00
Sebastian Kügler
7dfe957e66 The Big Move
All cpp code moves into the src/ subdirectory, as the Frameworks policy
suggests.

Directory structure should now be in line with other, future frameworks.
2013-02-14 17:17:12 +01:00