Commit Graph

4106 Commits

Author SHA1 Message Date
Marco Martin
af861eb2a4 move backgroundhints managment in Applet
Summary:
Applet is the more proper way to do it (and will make easier porting
to KF6) this also make it possible for the scripting interface to
access userBackgroundHints

Test Plan: everything behaves the same in plasmashell, the background button in the handle works

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25742
2019-12-05 10:41:57 +01:00
Marco Martin
1da69dd751 use the file selector in the interceptor
we still need at least for kf5 lifetime to use PackageUrlInterceptor
so use the selector there
this fixes a regression where old plasmoids with javascript in /code/
did break
2019-12-03 11:05:47 +01:00
Marco Martin
7a301be293 more use of ColorScope 2019-11-29 14:57:21 +01:00
Marco Martin
09e7a5a6bb also monitor window changes
fixes some scopes not finding their parent and
never getting notified when it changes
2019-11-29 13:44:58 +01:00
Marco Martin
57fdb56790 support for user removing background and automatic shadow
Summary:
add the ability for the user to override the background hints anddecide
about applets having background or a shadow
A new handle button will be added to manually enable/disable background for
plasmoids that support it
if they don't, the ImmutableBackground flag is set in the hints.

PlasmaCore.ColorScope has been expanded to work more like Kirigami.Theme (which will be replaced by) even if it's oòld behavior still works. This makes the complementary colorscope in applets with shadow actually work (and at the same time gives a clearer porting path for kf6)

Test Plan: Tested the functionality and correct save/restore

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, ndavis, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25590
2019-11-29 10:45:08 +01:00
Marco Martin
15e3d10ef8 support file selectors 2019-11-26 10:25:32 +01:00
Marco Martin
c79118e907 support qml file selectors 2019-11-25 18:21:26 +01:00
Marco Martin
24702a5353 remove stray qgraphicsview stuff 2019-11-22 16:18:54 +01:00
Marco Martin
4089bba04a remove dead files
fullscreensheet and fullscreenwindow were leftovers from porting to kf5
and have not been built since years, remove them
2019-11-22 16:14:50 +01:00
David Faure
6de88ef932 Port away from deprecated method authorizeKAction, renamed to authorizeAction 2019-11-20 23:51:59 +01:00
l10n daemon script
e0b70205f7 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-13 05:39:52 +01:00
Yuri Chornoivan
052a81f755 Fix minor issues found by EBN and typos 2019-11-10 12:06:10 +02:00
Marco Martin
b58d7c7752 don't delete and recreate wallpaperinterface if not needed
Summary:
the wallpaperinterface instance already reacts to wallpaper package
change and loads the current one.
containemtninterface deleted it every time the wallpaper changed
and recreated, effectively loading the wallpaper two times every time
the plugin was changed

Test Plan: switching plugins still works, but it's actually visible faster on slow hardware

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25217
2019-11-08 16:28:36 +01:00
Méven Car
000022b668 MobileTextActionsToolBar check if controlRoot is undefined before using it
Summary:
Prevents warning such as

qml/org/kde/plasma/components.3/mobiletextselection/MobileTextActionsToolBar.qml:62: TypeError: Cannot read property 'selectedText' of null
qml/org/kde/plasma/components.3/mobiletextselection/MobileTextActionsToolBar.qml:70: TypeError: Cannot read property 'selectedText' of null
qml/org/kde/plasma/components.3/mobiletextselection/MobileTextActionsToolBar.qml:78: TypeError: Cannot read property 'canPaste' of null

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25164
2019-11-06 15:20:31 +01:00
l10n daemon script
876dafaedb SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-06 05:33:56 +01:00
Konrad Materka
96b7fc21f5 Add hideOnWindowDeactivate to PlasmaComponents.Dialog
Summary: When using Dialog or QueryDialog it should be possible to set hideOnWindowDeactivate flag.

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24825
2019-11-04 10:09:16 +01:00
l10n daemon script
29104614ef SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-01 05:25:32 +01:00
l10n daemon script
1928390d1f SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-30 05:30:22 +01:00
Marco Martin
1f6d7591e9 map disabledTextColor to ColorScope 2019-10-29 12:30:15 +01:00
Marco Martin
5f46dd6bd5 add DisabledTextColor to Theme 2019-10-29 11:29:12 +01:00
David Edmundson
12edce87bb [PC3/button] Elide text always
Summary:
We always want the label to have the width managed by the layout to fill
all available space.

Test Plan:
In tests/components/button3.qml the test

"long text but constrained, should be 150px and elided" now is correctly
elided rather than the text spewing past the end of the button. The text
does not overlap the icon.

Reviewers: #plasma, apol, ngraham

Reviewed By: apol, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24909
2019-10-25 15:44:46 +01:00
Friedrich W. H. Kossebau
d70eadb977 API dox: adapt kapidox & ecm_add_qch settings to new deprecation macros
GIT_SILENT
2019-10-22 19:41:15 +02:00
Björn Feber
bbe0148db5 Improve panel options menu entries
Summary:
- Move "Panel Options" context menu items out of submenu
- Rename "Configure Panel..." option

See M144, T10047, T10190. This makes the panel customization options much more discoverable.

Test Plan: Open the panel context menu.

Reviewers: #plasma, #vdg, mart

Reviewed By: #plasma, #vdg, mart

Subscribers: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma

Tags: #frameworks

Maniphest Tasks: T10190, T11094, T10402

Differential Revision: https://phabricator.kde.org/D23951
2019-10-21 19:53:46 +02:00
Marco Martin
acbb200ac2 edit mode action
Summary: needed for the context menu entry

Test Plan: with the p-w- portion the action shows in the context menu

Reviewers: #plasma, #vdg, GB_2, ngraham, davidedmundson

Reviewed By: #plasma, #vdg, ngraham, davidedmundson

Subscribers: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10190, T11094, T10402

Differential Revision: https://phabricator.kde.org/D24263
2019-10-21 13:06:01 +02:00
Friedrich W. H. Kossebau
573b9a439f Enable KF_* group deprecation macros
GIT_SILENT
2019-10-20 03:46:32 +02:00
Friedrich W. H. Kossebau
df7f981890 Use ECMGenerateExportHeader to manage deprecated API better
Summary:
Allows
* projects linking to Plasma to hide deprecated API up to a
  given version or silence deprecation warnings after a given version,
  using
  * -DPLASMA_DISABLE_DEPRECATED_BEFORE_AND_AT
  * -DPLASMA_NO_DEPRECATED
  * -DPLASMA_DEPRECATED_WARNINGS_SINCE
  * -DPLASMA_NO_DEPRECATED_WARNINGS
  * -DPLASMAQUICK_DISABLE_DEPRECATED_BEFORE_AND_AT
  * -DPLASMAQUICK_NO_DEPRECATED
  * -DPLASMAQUICK_DEPRECATED_WARNINGS_SINCE
  * -DPLASMAQUICK_NO_DEPRECATED_WARNINGS

  or
  * -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
  * -DKF_NO_DEPRECATED
  * -DKF_DEPRECATED_WARNINGS_SINCE
  * -DKF_NO_DEPRECATED_WARNINGS

Reviewers: #plasma, mart, davidedmundson, apol, mlaurent

Reviewed By: #plasma, mart, mlaurent

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24678
2019-10-19 00:42:13 +02:00
Friedrich W. H. Kossebau
ab8e63a5a5 Use new INCLUDE_DIRS with ecm_add_qch, to have doxygen see more includes
GIT_SILENT
2019-10-19 00:39:53 +02:00
Noah Davis
15ed55b4cb [icons/media.svg] Add 16 & 32px icons, update style
Summary: Fixes blurry icons in the desktop shell

Test Plan:
{F7593397, size=full}

Examples of fuzzy icons:

task manager {F7593494, size=full}
media player widget {F7593497, size=full}

Fixed:

{F7593493, size=full}
{F7593509, size=full}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24627
2019-10-14 22:28:49 -04:00
Nate Graham
949a26d3fa [PlasmaComponents3] Fix checkable toolbutton background
Summary:
This fixed the background of a checkable PC3 ToolButton not being visible when checked.
The PC3 Button and PC2 ToolButton did not suffer from the issue, but the PC3 one did.

Test Plan:
Checkable PC3 ToolButtons now look checked when checked

No change for non-checkable PC3 ToolButtons

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24402
2019-10-07 07:26:54 -06:00
David Edmundson
982c052025 [pluginloader] Use categorized logging 2019-09-30 09:29:40 +01:00
Marco Martin
c621ebe572 make editMode a corona global property
Summary:
The plans are to switch on/off the whole plasma shell into edit mode.
For this it needs to be a global corona property, rather then just
containmentInterface.
Plasmashell would expose a dbus call to set it from systemsettings

Test Plan: plasmoid.editMode=true still works

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, GB_2, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24239
2019-09-26 19:53:41 +02:00
Kai Uwe Broulik
d5a5d07f0f Honor global animation speed factor
Multiplies the animation speed by the given factor.

Differential Revision: https://phabricator.kde.org/D23857
2019-09-25 15:55:17 +02:00
Marco Martin
455b41bc62 properly install whole plasmacomponent3
Summary:
right now just a subsection of controls are installed under plasmacomponent3
which makes for random missing stuff, especially any new component added.
it was done to avoid to have things like "applicationwindow" which don't make sense
in plasma, tough those are already available anyways as plain qqc2
install the whole folder avoiding many potential headaches

Test Plan: ieverything still works, all the components are available

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24072
2019-09-20 14:02:02 +02:00
Marco Martin
f301c7ea2d we need bigger buttons on mobile
as is an hack, was tried to be removed, but it doesn't work
2019-09-19 11:53:32 +02:00
Kai Uwe Broulik
67811e152a [Dialog] Apply window type after changing flags
Changing flags might override the window type, ensure we set it back properly

Differential Revision: https://phabricator.kde.org/D22569
2019-09-16 08:55:09 +02:00
David Faure
b466a2a211 Port away from deprecated methods in Qt 5.14
Test Plan: Builds with -DQT_DISABLE_DEPRECATED_BEFORE=0x060000 (as of today)

Reviewers: davidedmundson, broulik, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23970
2019-09-16 05:40:34 +02:00
Laurent Montel
d60831d650 Port from delta(); to angleDelta().y(); 2019-09-09 18:52:11 +02:00
Björn Feber
fb18347e4d Change reveal password button logic
Summary:
Indicate state, not the action it will have. When the password field is empty it feels like the password will be shown once I start typing. Dolphin has been doing it this way for the "show hidden files" action forever.
Also only show the button when the field contains text or when revealing the password, like in the PolKit dialog.

Test Plan:
Empty field
{F7326288}

{F5697017}
{F5697018}

Dolphin
Show hidden files, files are currently hidden
{F5697031}
Hide hidden files, files are currently shown
{F5697032}

Reviewers: #plasma, #vdg, ngraham, broulik, ndavis

Reviewed By: #vdg, ngraham, ndavis

Subscribers: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D10362
2019-09-09 17:48:54 +02:00
Friedrich W. H. Kossebau
c88354e0ed API dox: add missing @since
GIT_SILENT
2019-09-08 23:51:04 +02:00
Friedrich W. H. Kossebau
295059675c API dox: use full signatures for autolink on overloaded methods
GIT_SILENT
2019-09-08 23:50:40 +02:00
Friedrich W. H. Kossebau
3b6d9de925 API dox: fix name of item class
GIT_SILENT
2019-09-08 23:43:33 +02:00
Friedrich W. H. Kossebau
f31e4d95fd API dox: use @li for proper list
GIT_SILENT
2019-09-08 23:42:11 +02:00
Friedrich W. H. Kossebau
8ef47b1323 API dox: fix wrong use of @class
GIT_SILENT
2019-09-08 23:34:30 +02:00
Friedrich W. H. Kossebau
5e09728c1b API dox: use @code/@endcode
GIT_SILENT
2019-09-08 23:33:09 +02:00
David Edmundson
5f746ce1c2 Fix crash on teardown with Applet's ConfigLoader
Summary:
Deleting AppletPrivate will delete the ConfigLoader which will cause a
save, which can trigger a configSaved signal.

I think it is correct that the config might emit a signal just before
closing, and not at fault.

AppletPrivate is deleted by this point, but Applet is not so the
connection is still alive.

When we handle the signal, it goes into a Q_PRIVATE_SLOT that crashes.

This disconnect pattern is already used for guarding self config
changes.

BUG: 411221

Test Plan: kquitapp5 plasmashell, no longer crashes

Reviewers: #plasma, alexeymin

Reviewed By: alexeymin

Subscribers: alexeymin, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23707
2019-09-07 23:19:03 +02:00
Noah Davis
db7837d5f5 Make notification icons use outline style
Summary: They didn't quite fit in with the filled style

Test Plan:
Old: {F7304467, size=full}

New: {F7304458, size=full}

Testing stylesheets in Plasma Theme Explorer:
{F7304463, size=full}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, filipf, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23627
2019-09-03 11:15:15 -04:00
Aleix Pol
d3b22f8828 Port trivial connects to the new style 2019-08-30 17:26:54 +02:00
Laurent Montel
f53365633c GIT_SILENT: Use QLatin1String in QString::contains etc. Fix replace
usage
2019-08-29 07:25:48 +02:00
Camilo Higuita
069b4e95c1 make the sizing of the toolbuttons more coherent
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height  if those props are set.

Before patch:

{F7274098}

After patch:

{F7274097}

Reviewers: #plasma, mart, ngraham

Reviewed By: #plasma, mart, ngraham

Subscribers: broulik, apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23367
2019-08-28 08:59:32 -05:00
Marco Martin
86021afdf5 Revert "make button icons follow a reasonable size and layout"
This reverts commit f973619116.
2019-08-28 10:43:22 +02:00
Marco Martin
c6c882521f Revert "make the sizing of the toolbuttons more coherent"
This reverts commit 3887f5ec91.
2019-08-28 10:43:09 +02:00
Camilo Higuita
3887f5ec91 make the sizing of the toolbuttons more coherent
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height  if those props are set.

Before patch:

{F7274098}

After patch:

{F7274097}

Reviewers: #plasma, mart, ngraham

Reviewed By: ngraham

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23367
2019-08-23 16:35:37 -05:00
Camilo Higuita
f973619116 make button icons follow a reasonable size and layout
Summary:
with the Plasma style buttons which have an icon look wrong. The icon size is too big and in consecuence the whole button is drawn way too big.
With this patch the icon is set to a standard size and drawn in the button layout, in a way it looks consistent with other button with no icons.

example:

Before path:

{F7270612}

{F7270611}

With patch:

{F7270610}

{F7270609}

BUG: 399952
FIXED-IN: 5.62

Reviewers: #plasma, mart, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23352
2019-08-22 17:28:27 -05:00
l10n daemon script
9a3351fae5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-20 04:58:25 +02:00
David Edmundson
d62e99460a Allow applets/containments/wallpaper to defer UIReadyConstraint
Summary:
This is needed so that we don't remove the splash till the wallpaper is
loaded, but also allows doing this in a generic way.

Version 2 of the patch using a normal property.

We need to have the virtual so that the containment waits for the
wallpaper.

Test Plan:
Used with wallpaper patch
Added debug to ensure it happened after the stackview in the wallpaper
is pushed

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22852
2019-08-19 10:51:30 +01:00
l10n daemon script
56aa6dee3a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-17 05:07:40 +02:00
l10n daemon script
e454afa352 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-16 05:09:03 +02:00
Noah Davis
134b2ac331 Make notification icons look like bells
Summary: BUG: 384015

Test Plan:
See D23018

{F7178298, size=full}

Reviewers: #vdg, #plasma, broulik, ngraham

Reviewed By: #vdg, #plasma, broulik, ngraham

Subscribers: ngraham, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23019
2019-08-09 07:43:42 -06:00
Konstantin Lisin
144bb90715 Fix incorrect initial tabs position for vertical tab bars
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.

BUG: 395390
FIXED-IN: 5.62

Reviewers: #plasma, ngraham, hein

Reviewed By: #plasma, ngraham, hein

Subscribers: kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10047

Differential Revision: https://phabricator.kde.org/D23036
2019-08-08 20:33:19 -06:00
Nate Graham
d186d5421b Revert "Fix incorrect initial tabs position for vertical tab bars"
I committed this patch without the author's attribution, sorry
This reverts commit e2cd97d822.
2019-08-08 20:32:28 -06:00
Nate Graham
e2cd97d822 Fix incorrect initial tabs position for vertical tab bars
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.

BUG: 395390
FIXED-IN: 5.62

Reviewers: #plasma, ngraham, hein

Reviewed By: #plasma, ngraham, hein

Subscribers: kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10047

Differential Revision: https://phabricator.kde.org/D23036
2019-08-08 20:28:15 -06:00
Laurent Montel
4b427e4f03 Add missing include 2019-08-08 13:02:11 +02:00
l10n daemon script
bbad328bc2 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-05 04:45:06 +02:00
Kai Uwe Broulik
1f0215ebc6 [ToolButtonStyle] Use same color group for hovered state
This is a remnant from when we used a full background on hovered ToolButtons
instead of the frame we have now. It broke icon item appearance when hovered
in a custom ColorScope.

Reviewed-By: notmart
2019-08-02 13:29:51 +02:00
l10n daemon script
781d2f6fff SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-07-31 05:13:30 +02:00
Jonah Brüchert
31cd4f8d8e
Apply busy indicator duration change of D22646 to the QQC2 style
Summary:
Match the duration (2 seconds) that was set in D22630.

This style is mainly used by Plasma Mobile, therefore requesting team review from that project as well.

Reviewers: #vdg, #plasma:_mobile, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22720
2019-07-24 21:13:28 +02:00
David Edmundson
af2a7fbf69 Compile package structure plugins into expected subdirectory
Summary: This means they're found by unit tests pre-installation

Test Plan:
Removed installed files
Ran make (but not make install)
ConfigModelTest now passes

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22682
2019-07-24 17:07:29 +01:00
Noah Davis
b0541ffbff Change Highlight to ButtonFocus
Summary: Changed Highlight to Button focus so that these SVGs wouldn't use the same color as the selection background.

Reviewers: #vdg, #plasma, #breeze, ngraham

Reviewed By: #vdg, #breeze, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22670
2019-07-24 03:34:52 -04:00
l10n daemon script
47281f2a64 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-07-24 05:33:26 +02:00
Aleix Pol
04c0ff5cd7 Make sure we compare paths properly 2019-07-23 19:41:05 +02:00
Marco Martin
0e859870a9 Search for the plugin of the other plasmoid
Summary:
Some applets use completely the code of another one with the key
X-Plasma-RootPath.
At the moment it doesn't work on applets that have a binary plugin portion
This makes pluginloader load the plugin of the original applet we're using

Test Plan:
an applet that falls back to one that has a binary plugin now works.
ones that fall back to applets without binary plugin still work
normal applets as well

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22675
2019-07-23 11:13:13 +02:00
Nate Graham
28bc0f3ea1 [Busy Indicator] Match duration of QQC2-desktop-style version
Summary: Match the duration (2 seconds) that was set in D22630.

Reviewers: broulik, #vdg

Reviewed By: broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22646
2019-07-22 07:58:17 -06:00
Harald Sitter
a965fa4cb8 remove dangling remote widgets code
Summary:
can't be enabled anywhere + not actually doing anything as there is no
backing for it in the cpp + qca isn't even looked for by cmake

Test Plan: none

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22618
2019-07-22 10:02:03 +02:00
Noah Davis
249365e327 Remove hardcoded colors (view.svg, system.svg) 2019-07-21 04:09:26 -04:00
Aleix Pol
f04584d423 Add missing components in org.kde.plasma.components 3.0
Summary:
These were created but never installed. Was looking into porting krunner
to 3.0 and they were missing.

Test Plan: Used them in the WIP port of KRunner

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22546
2019-07-19 16:16:19 +02:00
Nate Graham
4e35b61a83 Update refresh and restart icons to reflect new breeze-icons versions
Summary:
Like D22534, but for the Plasma theme.

CCBUG: 409914

Reviewers: #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22541
2019-07-18 20:40:36 -06:00
Aleix Pol
d721555929 itemMouse isn't defined in plasma.components 3.0 2019-07-19 02:48:00 +02:00
Marco Martin
ccceb83b10 use clearItems when an applet gets deleted
back when this was written KConfigSkeleton didn't have clearItems
and setDefaults can still leave some cruft behind
this ensures all is gone
2019-07-18 17:44:15 +02:00
David Edmundson
03d406770f Fix crash if swtichSize is adjusted during initial setup
This causes us to create components and items during the initial binding
evaluation of the root.

Reviewed-by: Marco Martin
2019-07-17 11:57:40 +02:00
Marco Martin
05daa3e206 react when switchWidth/Height changes
if switchWidth or height changes dinamically,
compactRepresentationCheck has to be ran again, otherwise
it can happen the situation where applets have both rapresentations in
the same view
2019-07-15 13:57:48 +02:00
Aleix Pol
e6cbea39ff Remove unused bits in ContainmentAction 2019-07-10 19:26:50 +02:00
Aleix Pol
21227e0f98 Improve plugin caching
Summary:
Extend the plasmoid startup cache to DataEngines and ContaimentActions.
Include a cache for script engines. In practice it's always the same, we don't
need to check the file system every time.

Reviewers: #plasma, davidedmundson, mart

Reviewed By: #plasma, davidedmundson, mart

Subscribers: davidedmundson, mart, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22258
2019-07-08 13:48:05 +02:00
l10n daemon script
875dbab70c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-07-06 05:15:02 +02:00
Kai Uwe Broulik
214838313d [Svg] Fix porting error from QRegExp::exactMatch
The CACHE_ID_NATURAL_SIZE adds stuff around the argument string, so explicitly move the ^ and $ outside.

Differential Revision: https://phabricator.kde.org/D22275
2019-07-05 08:56:38 +02:00
Aleix Pol
46f0da45c6 ContainmentAction: Fix loading from KPlugin
Summary: At the moment it was enabled in the PluginLoader but we were not using it anywhere.

Test Plan: See patch in plasma-workspace.

Reviewers: #plasma, #frameworks, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22267
2019-07-05 01:04:07 +02:00
Aleix Pol
e3c6c2731e regular expression shouldn't be static 2019-07-04 12:20:42 +02:00
Aleix Pol
6c692309ed Better use of Qt APIs in Plasma::Theme
Summary:
Try not to access hashes repeatedly.
QRegExp -> QRegularExpression.

Reviewers: #plasma, #frameworks, fvogt, mart

Reviewed By: #plasma, mart

Subscribers: bruns, tcanabrava, fvogt, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22147
2019-07-02 16:46:53 +02:00
Filip Fila
97272465a8 [TabBar] Remove exterior margins
Summary: This allows us to glide active tabbar indicators on lines, which we cannot do now in Kickoff due to this limitation in the control.

Test Plan:
Before:
{F6936102}

After:
{F6936103}

Reviewers: #vdg, #plasma, ngraham, ndavis

Reviewed By: #vdg, ngraham, ndavis

Subscribers: ndavis, apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22108
2019-07-01 00:06:17 +02:00
Bhushan Shah
7ae271987c pluginloader: Change behavior of X-KDE-ParentApp
Summary:
X-KDE-ParentApp is the key in desktop file to display that given service
or application is part of the another application or extension of other
application. In KDE4 this key was used to mark applets to be used in the
specific application like plasma-desktop, kdevelop, amarok etc.

In KF5 world, none of this applications have applet loading mechanism
apart from plasma*, and there are likely only Plasma applet, containment
or dataengines.

Previous API, when no/empty parentApp was passed would filter out every
application which had something as parentApp. This was to ensure only
compatible plugins are loaded in Plasma. This resulted in applets
getting excluded if they suggested that org.kde.plasmashell is their
parent application. Refine this API to,

- If no/empty parentApp is provided, provide all applets
- If parentApp is provided, filter by applet

This behavior is more filter like instead of other way around.

CHANGELOG: Applet, DataEngine and containment listing methods in
Plasma::PluginLoader no longer filters the plugins with X-KDE-ParentApp
provided when empty string is passed.

Test Plan:
tested that plasma loads properly, plasmaengineexplorer lists
all engines and plasmawindowed works fine. Neverthless requires more testing

Reviewers: mart, apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22049
2019-06-23 20:39:41 +05:30
Marco Martin
9f04ae48e2 make pinch in calendar work again
work around https://bugreports.qt.io/browse/QTBUG-76569
with an empty mousearea on top
2019-06-21 17:20:06 +02:00
Nicolas Fella
eddc6dec69 Add disk-quota icons
Summary:
Add disk-quota icons to Plasma theme

BUG: 403506

Reviewers: #plasma, #breeze, ngraham, ndavis

Reviewed By: #breeze, ndavis

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21966
2019-06-21 16:28:45 +02:00
Aleix Pol
097f0e83e7 Make Plasma::Svg::elementRect a bit leaner
Summary:
Don't double-access maps
Don't construct ids more times than necessary.
Make regular expression static so it's not compiled on every run.
Remove unused code.

Reviewers: #plasma, #frameworks, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: bruns, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21788
2019-06-21 15:25:42 +02:00
Friedrich W. H. Kossebau
eff37abdcb Automatically set version of desktopthemes packages to KF5_VERSION
Summary:
Should ensure that on a new release any existing theme caches are updated
automatically.

Reviewers: #plasma, ltoscano, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21767
2019-06-13 15:38:23 +02:00
Aleix Pol
52124c663e Don't notify about changing to the same state it was at
Summary:
The object tracker was telling me it's notifying the same value it
already got, and reading the code it seems to be already notifying when it
actually changes.

Test Plan: tests pass, plasma runs fine.

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21481
2019-06-13 01:04:53 +02:00
Dimitris Kardarakos
cd8b6b71ce Fix the alignment of the label of the toolbutton
When only a label exists in a toolbutton, without filling the width of the rowlayout, the label is not properly aligned in the center.

Differential Revision: https://phabricator.kde.org/D21415
2019-06-04 20:45:27 +03:00
Nate Graham
adb9998988 [PlasmaComponents3] Vertically center button text as well
Summary:
The PC3 Button's Label didn't have `Layout.FillHeight: true` set, so button text was not actually
getting vertically centered in certain circumstances. This patch fixes that.

Found while working on D21503.

Test Plan:
Before: {F6860487, size=full}

After: {F6860486, size=full}

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21502
2019-06-03 10:06:47 -06:00
Aleix Pol
09fa87a7b7 Revert "Pass fully-qualified arguments and return values to moc"
This could break old-style connects. Let's keep it as it was until KF6
as discussed in the channel. Thanks frinring for pointing it out.

This reverts commit f631aec33f.
2019-05-30 16:05:36 +02:00
Aleix Pol
0b18d4f0b3 Don't modify a temporary object
Summary: Instead copy the object, operate it and update it into the object.

Test Plan:
just used plasma shell and ran the tests. I'm not sure who uses this.
Issue found with clazy.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21483
2019-05-30 15:38:35 +02:00
Aleix Pol
f631aec33f Pass fully-qualified arguments and return values to moc
Summary: Otherwise it thinks it's different types.

Test Plan: tests pass, plasmashell works

Reviewers: #plasma, #frameworks, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21480
2019-05-30 15:38:09 +02:00
Noah Davis
fb8f02de76 Make Breeze Light/Dark use more system colors
Summary: Closes T8755

Reviewers: #vdg, #plasma, mart, filipf

Reviewed By: #vdg, filipf

Subscribers: filipf, lavender, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T8755

Differential Revision: https://phabricator.kde.org/D21378
2019-05-29 20:46:08 -04:00
Aleix Pol
756a21a6ff Fix warnings
Don't pass objects to lambdas that get unused.
Don't connect to lambdas without specifying the target object, if an object
reference is passed to the lambda.
2019-05-29 16:23:29 +02:00
David Edmundson
39d1db6e49 Export SortFilterModel sort column to QML
Test Plan: Used in model

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21419
2019-05-27 08:03:28 +01:00
Friedrich W. H. Kossebau
e99f653113 plasmacore: fix qmldir, ToolTip.qml no longer part of module
Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21350
2019-05-24 15:08:48 +02:00
Marco Martin
cb8bdb8edd signal availableScreenRectChanged for all applets
if the connect is done in containmentinterface only contaiments
will be able to see the rect changing, while applet would access it but
not be able to detect changes
2019-05-23 13:18:00 +02:00
Friedrich W. H. Kossebau
b0850b1f6f Use simply configure_file to generate the plasmacomponents3 files
Reviewers: #plasma, mart, apol

Reviewed By: apol

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21349
2019-05-23 00:17:52 +02:00
Friedrich W. H. Kossebau
3b950f38cc Update *.qmltypes to current API of QML modules
Reviewers: #plasma, apol, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21001
2019-05-17 18:38:10 +02:00
Friedrich W. H. Kossebau
f008615e37 FrameSvg: also clear mask cache on clearCache()
Summary:
It can be unexpected that those are not reset when clearCache() was called.

With the current logic when a theme changes the mask cache not reset also
results in wrong lookups, as the cacheid used as key does not include the
theme name.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21172
2019-05-14 17:08:29 +02:00
Friedrich W. H. Kossebau
8899389c9f FrameSvg: make hasElementPrefix() also handle prefix with trailing -
Summary:
there are a few places which potentially pass a prefix with a trailing -,
e.g. if using directly the value of FrameSvg::prefix() or
FrameSvg::actualPrefix(). Support the assumption in such code, unbreaking
its currently not working behaviour.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21174
2019-05-14 17:08:00 +02:00
Friedrich W. H. Kossebau
6af447a848 FrameSvgPrivate::generateBackground: generate background also if reqp != p
Summary:
d8a1a9eb08 changed the condition from
hasElementPrefix(q->prefix()) to hasElementPrefix(frame->requestedPrefix)
but it is not clear why, as the background is generated from the prefix
data & the requestedPrefix is no-where in effect.
As a result sometimes the background is not rendered for a given
not-existing requestedPrefix which was mapped to an empty prefix instead.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21175
2019-05-14 17:07:24 +02:00
Friedrich W. H. Kossebau
1bc1994dfe FrameSvgItem: emit maskChanged also from geometryChanged()
Summary:
Needed e.g. to fix the missing update of the mask on changing the size of
the Plasma panel if only listening to mask changes.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21201
2019-05-14 15:10:27 +02:00
Friedrich W. H. Kossebau
193775def6 FrameSvg: prevent crash when calling mask() with no frame yet created
Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21200
2019-05-14 15:10:07 +02:00
Friedrich W. H. Kossebau
084ba0f886 FrameSvgItem: emit maskChanged always from doUpdate()
Summary:
In that method we can assue a high chance that the mask is also affected.
Instead of adding complicated additional code to track if the mask
really changed, we rely on the cached value from FrameSvg.
This method is not too often called in a Plasma session, so that
further optimization work to avoid unneccesary emits seems not yet
worth it.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21179
2019-05-13 23:47:25 +02:00
Friedrich W. H. Kossebau
9142155b5a API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'
Reviewers: #plasma, dhaumann

Reviewed By: dhaumann

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21173
2019-05-13 23:44:58 +02:00
Marco Martin
4498ba9fb9 a kf6 comment 2019-05-13 11:25:22 +02:00
Friedrich W. H. Kossebau
0f65c95771 API dox: point to Plasma5 versions on techbase if avail 2019-05-13 01:09:26 +02:00
Friedrich W. H. Kossebau
fca08ef241 FrameSvg: l & r borders or t & b don't need to have same height resp. width
Summary:
The specification for FrameSvg does not require that all borders exist
or that left & right and top & bottom borders have samples with the same
size in the scalable dimension.
The old assumption in the code broke e.g. themes which had special
variants per screen side for the panel-background and left out elements
for the border side which would not be rendered anyway, but only set a
margin-hint. So e.g. for a panel on the east screen edge, without the
left border element set, leftHeight would be 0 and as result also the
right border not be painted due to an empty size.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21106
2019-05-10 01:13:23 +02:00
l10n daemon script
ff8ac120cb SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-05-08 05:45:12 +02:00
Friedrich W. H. Kossebau
7f4e171ef7 PlatformComponentsPlugin: fix plugin iid to QQmlExtensionInterface
Summary: The Q_PLUGIN_METADATA IID should be the one of the implemented interface.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21000
2019-05-04 01:48:46 +02:00
Friedrich W. H. Kossebau
c8fe7bc5ac IconItem: remove remaining & unused smooth property bits
Summary: fix-up for 18a2ca50ab

Reviewers: #plasma, davidedmundson, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20999
2019-05-04 01:48:12 +02:00
Kai Uwe Broulik
91024027b0 [Dialog] Add CriticalNotification type
Allows to flag a dialog window as critical notification that should be shown even on top of fullscreen windows

Differential Revision: https://phabricator.kde.org/D20630
2019-05-02 10:15:57 +02:00
l10n daemon script
58d8fc6dd5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-04-29 05:32:30 +02:00
Noah Davis
176643f48c Fix wrong group names for 22, 32 px in audio.svg
Summary: Before this fix, the system tray audio widget would try to use the 32px icons where 22px icons should be used.

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20825
2019-04-25 14:01:21 -04:00
Kai Uwe Broulik
1b2424879a [Window Thumbnail] Also monitor scene visibility and clean up
Just because the item is visible doesn't mean the window itself is. Keep track of the window it's in.
Use itemChange instead of connects and move the check for starting to startRedirect so we don't have to check the conditions
for that in every change handler (visible && enabled && window->visible). It also saves three connects in the constructor.
Also, don't unredirect if we didn't redirect in the first place to avoid warnings printed on console.

BUG: 406303

Differential Revision: https://phabricator.kde.org/D20805
2019-04-25 15:04:20 +02:00
Marco Martin
9aeaf7cbb5 make the mobile text toolbar appear only on press 2019-04-24 11:54:53 +02:00
Marco Martin
bdb2783b0d use the new Kirigami.WheelHandler 2019-04-23 10:34:08 +02:00
Noah Davis
b5ec56091e Add more icon sizes for audio, configure, distribute
Summary: The tooltip for the audio system tray widget and panel edit mode had blurry versions of these icons because the icons were being scaled to fit.

Test Plan:
audio.svg: {F6783458, size=full}

configure.svg: {F6783423, size=full}

distribute.svg: {F6783424, size=full}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20695
2019-04-22 08:42:19 -04:00
Friedrich W. H. Kossebau
170ff5668f [FrameSvgItem] Update filtering on smooth changes
Summary:
When just the smooth property is changed, this also results in a call of
QQuickItem::updatePaintNode reimplementations. So always just set the
filtering flag to match the current value of the smooth property.

Reviewers: #plasma, broulik, mart

Reviewed By: #plasma, broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20579
2019-04-18 13:04:17 +02:00
Friedrich W. H. Kossebau
084edba0db Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"
Summary:
During Pre-Plasma5 the hard-coded height of 20 of the progressbar was
changed to instead be taken from the theme via the "hint-bar-size":
commit cee9c928e3

As fallback for old themes in absence of the hint the default height
since some time later has been derived from the sum of the heights of
the elements "bar-inactive-top" & "bar-inactive-bottom".

Which though for the Air and Oxygen themes results in the small heights
of respective 10 & 4. As a result the visual appearance of the theme
differs from what people remember of the time when the themes were
designed.
Ideally the theme designer would tune the actual value to something they
prefer. Until then setting the hint to restore the visual appearance over
the currently pretty slim or even too slim one should improve things
already.

Reviewers: #plasma, #vdg

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20602
2019-04-17 22:16:29 +02:00
Noah Davis
cdad9c38c1 Fix stylesheet support for audio-volume-medium 2019-04-17 14:10:54 -04:00
Noah Davis
bd8264e928 Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons
Test Plan:
media.svg: {F6777018, size=full}

drive.svg: {F6777019, size=full}

plasmavault_error.svg: {F6777022, size=full}

plasmavault: {F6777023, size=full}

list.svg: {F6777025, size=full}

go.svg: {F6777028, size=full}

audio.svg: {F6777029, size=full}

edit.svg: {F6777030, size=full}

Reviewers: #vdg, #plasma, broulik, ngraham

Reviewed By: #vdg, #plasma, broulik, ngraham

Subscribers: broulik, ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20623
2019-04-17 13:52:31 -04:00
Noah Davis
0ff81fe4c7 Align z's to pixel grid in system.svg
Summary: This does the same thing as D20586, but for the Breeze desktop theme. The diff shows a lot of changes because I optimized the SVG.

Test Plan: Looks exactly the same as D20586

Reviewers: #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20597
2019-04-16 08:46:00 -04:00
Marco Martin
8431223542 use the mobiletextcursor from proper namespace 2019-04-16 11:21:34 +02:00
Kai Uwe Broulik
2a636d6671 [FrameSvgItem] Respect smooth property
This ensures the textures are rendered smoothly, especially when rotated.

Differential Revision: https://phabricator.kde.org/D20570
2019-04-15 12:46:12 +02:00
Friedrich W. H. Kossebau
b9ac83d4d7 Oxygen desktoptheme: add padding to hands, against jagged outline on rotation
Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20550
2019-04-15 11:27:29 +02:00
Friedrich W. H. Kossebau
18a2ca50ab SvgItem, IconItem: drop "smooth" property override, update node on change
Summary:
QQuickItem already has a "smooth" property, which was shadowed by the
custom ones with the same name. As the property was not part of public
symbols, but instead is dynamically looked up without the class name part
of the property, we just remove the custom versions and instead switch
all custom code to use the inherited property.

While doing that the code is also fixed to properly update the
textureNodes to the current value of the "smooth" property.
As well as not set the filtering only on the texture, when it is passed
to a texturenode which will set its own filtering state to the texture
right before the bind call and thus wipe any previous direct setting
of the filter mode on the texture.

This also changed the default to smooth=true for SvgItem, though
effectively smooth was always true, as the texturenode was hardcoded
to get a QSGTexture::Linear filtering (which, as said above, is forced
onto its texture, no matter what was otherwise set before).

Reviewers: #plasma, davidedmundson, mart

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20510
2019-04-15 00:03:28 +02:00
Friedrich W. H. Kossebau
78bec83b22 Support gzipping of svgz also on windows, using 7z
Reviewers: #plasma, #windows

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20499
2019-04-12 22:45:16 +02:00
Friedrich W. H. Kossebau
37a1845bc4 Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset
Summary:
The hands of the clocks still relied on the KDE4 times rule that the
position in y-axis relativ to the clock center would define the relative
rotation point for the hands.

With the default in Plasma 5 being (width/2, width/2) from topleft of the
hand shape, using hints of upcoming Plasma 5.16 allows to override that
again to match the original definition, without the need to enlarge
the pixmaps of the hand shapes.

Reviewers: #plasma, mart, ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20496
2019-04-12 19:33:31 +02:00
David Edmundson
83d85dc228 Add invokable public API for emitting contextualActionsAboutToShow
Summary:
This signal is emitted just before showing the context menu to allow
lazy-loading expensive actions like hasAlternatives.

This emitted by our code whenever we show a context menu from an event
filter, however we want to use this code from a tooltip in D17410

Test Plan:
Hovered over some applets, they correctly enabled/disabled the
alternatives button

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20417
2019-04-12 15:46:58 +01:00
Friedrich W. H. Kossebau
417a82b1b9 Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16
Reviewers: #plasma, #vdg, mart, davidedmundson, ngraham

Reviewed By: #plasma, #vdg, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20478
2019-04-12 11:17:40 +02:00
l10n daemon script
f1f4d64576 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-04-12 05:51:51 +02:00
Friedrich W. H. Kossebau
6887d4e736 Port away from deprecated KWindowSystem::windowInfo 2019-04-12 01:40:11 +02:00
Friedrich W. H. Kossebau
38ba8beee3 Keep desktoptheme SVG files uncompressed in repo, install svgz
Summary:
The SVG format being based on plain text, storing the SVG in the repository
not as .svgz, but .svg, helps both VCS tools (patching, showing diffs) as
well as allows some developers to edit the SVG directly in any text editor,
not only those which support automatic conversion from/to gzip format.

While most artists will continue (and which shall be okay) to use GUI
editors like inkscape, which might rewrite the complete structure on saving,
using uncompressed format in the repo still allows the occasional direct
edit of the text, .e.g. to change a colour, which then is also easily seen
in the commit diff.

To still keep the svgz format when deployed, a build step is introduced,
which uses gzip to create svgz files in the build dir. This conversion can
be controlled using the option GZIP_DESKTOPTHEME_SVG (default: ON).

Test Plan: Themes are still working (with & without cache removed).

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20166
2019-04-12 01:37:01 +02:00
Marco Martin
58dd4c5c0f separe mobile text selection to avoid recursive imports
Summary:
the mobile text selection toolbar uses toolbuttons, which in turn use the
private import. This will make the components loading stuck in dependency
resolution

Test Plan: all loads correctly now

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: hein, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20428
2019-04-10 13:53:44 +02:00
Eike Hein
846741f851 Revert "use the right namespace"
This reverts commit 067ec2eafc.
2019-04-10 06:54:30 +09:00
Eike Hein
a280cccfde Revert "mov the mobile text actions in own import"
This reverts commit c72ee78bbb.

Broke PlasmaComponents3. Missing files? Error example:

MenuRepresentation.qml:172:5: Type PlasmaComponents3.TextField unavailable
file:///home/eike/devel/install/lib64/qml/org/kde/plasma/components.3/TextField.qml:27:1: "mobiletextselection": no such directory

CCMAIL:notmart@gmail.com
2019-04-10 06:52:45 +09:00
Marco Martin
067ec2eafc use the right namespace 2019-04-09 15:40:36 +02:00
Nate Graham
7687ffa3da Use more appropriate "Alternatives" icon and text
Summary:
The new icon was just added in D20367. The current icon is semantically and visually incorrect,
and the new one fixes that.

The current text also does not begin with an action verb, and this patch fixes that too.

Test Plan:
Before:
{F6759646, size=full}

After:
{F6759647, size=full}
{F6759649, size=full}

Reviewers: #vdg, #plasma, GB_2, filipf

Reviewed By: #vdg, GB_2, filipf

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20392
2019-04-08 15:04:02 -06:00
Friedrich W. H. Kossebau
f20722fbe1 FrameSvgItem: add "mask" property
Summary:
This property allows e.g. the Plasma shell to query the shape a panel has
when defining the area for BlurBehind.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20202
2019-04-08 15:11:07 +02:00
Marco Martin
c72ee78bbb mov the mobile text actions in own import
this avoids a qml type resolution recurtion which can
in some cases stuck the component to loading forever
this was particularly visible in plasma mobile
2019-04-08 13:32:46 +02:00
Kai Uwe Broulik
c65145bd34 [AppletInterface] Check for corona before accessing it
On plasmashell shutdown when the panels are destroyed, the available screen geometry changes.
When an applet then accesses screenGeometry in response to that change, it crashes because the corona is already gone.

availableScreenRegion() and availableScreenRect() already checked for this but screenGeometry() did not

Differential Revision: https://phabricator.kde.org/D20244
2019-04-05 11:34:07 +02:00