Commit Graph

172 Commits

Author SHA1 Message Date
Aaron J. Seigo
47866f417b List->Set, and try and make the even filter a little more efficient
svn path=/trunk/KDE/kdelibs/; revision=895578
2008-12-11 03:10:36 +00:00
Rob Scheepmaker
c51d9d7d9b Yeah, finally! Fixed a crash that occurs when moving an extenderitem back to its source from an extender that was also the last one to have a spacer inserted because the same item was hovering over it. Phew, that was a mouthfull... With this fix we monitor if previousTargetExtender get's destoryed so we don't accidently try to remove it's spacer.
BUG: 171498


svn path=/trunk/KDE/kdelibs/; revision=895405
2008-12-10 17:29:40 +00:00
Rob Scheepmaker
72eaf8c5f7 No longer use a QGraphicsGridLayout to manage offscreen widgets in corona. Instead position them manually and give each one a spot where they can grow up to QWIDGETSIZEMAX. This has the advantage of not requiring hacks to work around QGL problems, and it avoids having to move all views when one item resizes. It feels snappier and the code looks cleaner.
svn path=/trunk/KDE/kdelibs/; revision=895118
2008-12-10 00:57:42 +00:00
Aaron J. Seigo
a6140d5a27 use isEmpty; a couple minor, minor changes that crept in while debugging things elsewhere
svn path=/trunk/KDE/kdelibs/; revision=895022
2008-12-09 20:37:41 +00:00
Rob Scheepmaker
b321b2f033 Performance optimization: only change the icon if it's actually a different icon. Mainly affects uiserver widgets atm.
Oh, and warning--.


svn path=/trunk/KDE/kdelibs/; revision=894878
2008-12-09 14:04:33 +00:00
Aaron J. Seigo
e42452e847 * update the direction on location changes
* update the dialog, if it exists, when checking the border of the extender
BUG:177113

svn path=/trunk/KDE/kdelibs/; revision=894469
2008-12-08 18:03:23 +00:00
Marco Martin
ba43ebdd06 corrected sizing problem
animation jumps a bit less randomly
BUG: 176672

svn path=/trunk/KDE/kdelibs/; revision=893099
2008-12-05 22:48:58 +00:00
Marco Martin
b47c32869f use elements dimensions to resize the scrollbar
svn path=/trunk/KDE/kdelibs/; revision=893050
2008-12-05 21:04:33 +00:00
Marco Martin
98b833977b correct some last toolbox annoyances...
svn path=/trunk/KDE/kdelibs/; revision=893011
2008-12-05 18:16:30 +00:00
Marco Martin
e22429867b int with a frameSvg when it's not in a corner
svn path=/trunk/KDE/kdelibs/; revision=892649
2008-12-04 20:36:35 +00:00
Marco Martin
c64d38b551 waay more reliable toolbox->toolbar switching, killed the weird
d->needsToolbarBehaviour()

svn path=/trunk/KDE/kdelibs/; revision=892273
2008-12-03 22:44:16 +00:00
Beat Wolf
8eeb660cdd fixing typo. Resolves toolbox that is drawn outside screen
svn path=/trunk/KDE/kdelibs/; revision=891521
2008-12-02 12:44:39 +00:00
Aaron J. Seigo
f8acdb1861 apparently the documentation isn't right and you shouldn't delete the entries
to the report of the bug: please check that this fixes it for you whenever you can get an updated build (e.g. next build, or sooner if using svn); if not, please comment on the report and reopen it. thanks.

BUG:176661

svn path=/trunk/KDE/kdelibs/; revision=891424
2008-12-02 00:08:09 +00:00
Rob Scheepmaker
ab56a3a388 Couple of fixes:
* Close empty extender when clicking in it.
BUG:176545
* Saner size policy for Plasma::Meter. (the height should never be able to be smaller then svg's height because labels could otherwise overlap, actually, the whole current approach doesn't consider font size, I think we should think of a better approach for 4.3)
* Use the same spacer as used in the panel for extenders. I think we would want some svg themable shared spacer widget for 4.3, but at least this adds some consistency.


svn path=/trunk/KDE/kdelibs/; revision=891328
2008-12-01 18:30:42 +00:00
Marco Martin
9fd8a3298d correctly position new activity when adding one
never show text on wider zoom level

svn path=/trunk/KDE/kdelibs/; revision=891258
2008-12-01 13:17:27 +00:00
Marco Martin
d9c14c87ba show the toolbox as an external solid-background toolbar under the
containment, don't show text on icons except add windgets and add
activity
show the remove activity button in the toolbox for non active ones

svn path=/trunk/KDE/kdelibs/; revision=891209
2008-12-01 12:40:08 +00:00
Jesse Lee Zamora
629a3b3789 Polish the rough edges out of the gradient painting code.
svn path=/trunk/KDE/kdelibs/; revision=891051
2008-12-01 01:54:07 +00:00
Aaron J. Seigo
7fca1acbb6 if the applet is destroyed, then returnToSource() the extenders. perhaps we should be watching for extenders being deleted at random (QObject::destroyed signal?). also, seems that returnToSource is broken in general atm, but only for items in the panel, though that seems to be a separate issue. i wonder if that's a PopupApplet bug? will need to investigate.
CCMAIL:r.scheepmaker@student.utwente.nl
BUG:176411

svn path=/trunk/KDE/kdelibs/; revision=891037
2008-12-01 01:08:43 +00:00
Rob Scheepmaker
e1bb614999 Fixed crash when clicking an extenders dragger without actually dragging, and fixed the 'hand problem'.
svn path=/trunk/KDE/kdelibs/; revision=890806
2008-11-30 11:45:23 +00:00
Marco Martin
f4cf4b189b avoid an endless repaint loop
condition is still very convoluted but at least a lot faster

svn path=/trunk/KDE/kdelibs/; revision=890462
2008-11-29 13:06:12 +00:00
Aaron J. Seigo
4a7699ce82 since it leads to confusion for users, breaks occassionally in svn due to its complexity, incurs overhead on every applet paint but especially when dragging, doesn't look nice at all without composite ... just kill the top level view thing and when you drag something it just "pops" into the right containment.
BUG:176298

svn path=/trunk/KDE/kdelibs/; revision=890331
2008-11-28 22:39:29 +00:00
Aaron J. Seigo
766dc8ab60 patch by Andrew Lake to free-resize applets from the corner rather than the center; need to do some work on applet handle right now and i don't want this patch going sideways and he's not online right now, so ...
svn path=/trunk/KDE/kdelibs/; revision=890316
2008-11-28 22:01:39 +00:00
Marco Martin
827876bab0 when the view is zoomed out show all desktop toolboxes as toolbars,
makes the thing way more usable
prettier background
and disable the text on maximum zoom out level

svn path=/trunk/KDE/kdelibs/; revision=890259
2008-11-28 17:32:21 +00:00
Rob Scheepmaker
2d4971eb46 Extender Polishing time! The following problems have been adressed:
* Far more correct spacer implementation. This avoids the spacer jumping around while dragging an item. Also adjustSizeHints is now only called once/spacer move.
* Avoid spacer related memleak.
* Only load extenderItems that are actually detached. This way, attached items won't linger around in case of a plasma crash.
* Use utilities-desktop-extra as icon for items with no saved icon (e.g. items where the icon is set using setIcon(QIcon) instead of setIcon(QString)). Sure beats the questionmark.
* Update mask when offscreen extender items are resized when being dragged to avoid screwed up masks (white borders).
* Start the drag only aften being moved a minimum of QApplication::startDragDistance().
* Correct transformation for calls to showDropZone.
* Use the mouse position for positioning items in extenders or panels, the topleft corner for positioning in a desktop containment. This feels the most natural.
* Move items back to the extender they came from when they're dropped into nowhere.
* Some small code style fixes.



svn path=/trunk/KDE/kdelibs/; revision=890249
2008-11-28 17:06:00 +00:00
Marco Martin
4d962352a9 respect drawBase()
svn path=/trunk/KDE/kdelibs/; revision=889814
2008-11-27 18:36:42 +00:00
Aaron J. Seigo
057d7693fe sshhhh
svn path=/trunk/KDE/kdelibs/; revision=889813
2008-11-27 18:33:11 +00:00
Aaron J. Seigo
4659724790 don't create an unused button
svn path=/trunk/KDE/kdelibs/; revision=889542
2008-11-27 06:03:53 +00:00
Aaron J. Seigo
7b4de980b8 clarify this code a wee bit more and call positionContainments() in all necessary cases
svn path=/trunk/KDE/kdelibs/; revision=888637
2008-11-25 00:23:43 +00:00
Marco Martin
75dcbe9413 initialize this value, that's why toolbox sometimes was going to left in
an unpredictable way
BUG:175796
CCMAIL:release-team@kde.org

svn path=/trunk/KDE/kdelibs/; revision=888589
2008-11-24 22:27:42 +00:00
Adriaan de Groot
5959236882 Match up the declaration of setCorner with its definition (missing const)
svn path=/trunk/KDE/kdelibs/; revision=888512
2008-11-24 17:39:03 +00:00
Rob Scheepmaker
4fe87fcfea Avoid screwing up the panel when dropping extenderitems in it: make extenderapplet a popupapplet! And use pinheiro's nice and amazingly weird icon as popupicon. I think I'm gonna call it 'the snowman'.
svn path=/trunk/KDE/kdelibs/; revision=887651
2008-11-22 14:32:43 +00:00
Aaron J. Seigo
82ab4794bd add file
svn path=/trunk/KDE/kdelibs/; revision=887091
2008-11-21 03:45:03 +00:00
Aaron J. Seigo
23a7c83164 clear the shortcuts editor pointer only when the dialog is actually dead and gone
BUG:175722

svn path=/trunk/KDE/kdelibs/; revision=887090
2008-11-21 03:43:45 +00:00
Rob Scheepmaker
47dcbf47b9 By default, use an empty string as empty extender label, and don't display that label if that string is empty. The idea is that having that label there is weird when the extender is used in a dialog. The case in which the label is useful, is when the extender is embedded in an applet on the desktop, and the applet should only set the label, if this is the case.
svn path=/trunk/KDE/kdelibs/; revision=886937
2008-11-20 16:37:30 +00:00
Aaron J. Seigo
ece148395c make sure screen is valid before asking for i
svn path=/trunk/KDE/kdelibs/; revision=886708
2008-11-19 21:18:37 +00:00
Aaron J. Seigo
4f72717a26 cleanups
svn path=/trunk/KDE/kdelibs/; revision=886707
2008-11-19 21:18:12 +00:00
Aaron J. Seigo
73a23ddf48 keep the tools in the allowed area
svn path=/trunk/KDE/kdelibs/; revision=886384
2008-11-19 05:35:34 +00:00
Aaron J. Seigo
cb4ac7b6ce proper size
BUG:175209

svn path=/trunk/KDE/kdelibs/; revision=886381
2008-11-19 05:08:38 +00:00
Aaron J. Seigo
b4a67cda4b remove some todos, add some debug ... though now i can't reproduce the problem where my cashew scoots over the left randomly. hum hum hum
svn path=/trunk/KDE/kdelibs/; revision=886331
2008-11-19 00:40:38 +00:00
Aaron J. Seigo
c027fb3886 remove some more dead code due to c-n-p from DesktopToolBox
svn path=/trunk/KDE/kdelibs/; revision=886220
2008-11-18 20:47:04 +00:00
Marco Martin
2eb6b3ed9c hide the view on rmb click
BUG: 166902

svn path=/trunk/KDE/kdelibs/; revision=886216
2008-11-18 20:39:05 +00:00
Marco Martin
9cfe6246ec make the tabbar widget stretch also in height (thus umbreaking it in the
panel), with a dirty hack on minimum/maximum sizes, but i think it's the
only way for now, since minimumTabSizeHint() and maximumTabSizeHint()
are private in QTabBar and will be protected probably not before Qt5 O.o

svn path=/trunk/KDE/kdelibs/; revision=886098
2008-11-18 15:27:04 +00:00
Aaron J. Seigo
4f36ceb235 we don't need the timer on this one; it's only useful for the desktop toolbox.
BUG:167782

svn path=/trunk/KDE/kdelibs/; revision=885897
2008-11-18 03:37:43 +00:00
Aaron J. Seigo
1171ef67d8 deleteLater is unecessary in this case and it just screws up some of our use cases such as the screen saver toolbox
svn path=/trunk/KDE/kdelibs/; revision=885859
2008-11-18 00:43:52 +00:00
Aaron J. Seigo
649057791d clean this up a little bit
svn path=/trunk/KDE/kdelibs/; revision=885858
2008-11-18 00:43:11 +00:00
Aaron J. Seigo
1b04d7b8b0 make panel toolboxes position and paint properly; essentially do what i did earlier for the desktop one by caching the colors from the theme and getting rid of the negative coordinates
svn path=/trunk/KDE/kdelibs/; revision=885840
2008-11-18 00:12:05 +00:00
Aaron J. Seigo
160e70ccd0 add proper support for virtual desktops, which really requires more than just the View being aware of it; given the default parameters, it's a detail most plasma based apps can ignore (just like screens in general, actually =)
svn path=/trunk/KDE/kdelibs/; revision=885330
2008-11-17 04:34:55 +00:00
Aaron J. Seigo
34ab711509 global shortcut configuration for all applets =)
svn path=/trunk/KDE/kdelibs/; revision=884810
2008-11-15 21:23:56 +00:00
Aaron J. Seigo
74acdc9534 don't leak the style.
svn path=/trunk/KDE/kdelibs/; revision=884504
2008-11-15 07:08:30 +00:00
Aaron J. Seigo
dfa5462c82 mark the header private and do the moc'ing the way we do the rest
svn path=/trunk/KDE/kdelibs/; revision=884503
2008-11-15 07:08:08 +00:00