Commit Graph

15436 Commits

Author SHA1 Message Date
Marco Martin
86021afdf5 Revert "make button icons follow a reasonable size and layout"
This reverts commit f973619116.
2019-08-28 10:43:22 +02:00
Marco Martin
c6c882521f Revert "make the sizing of the toolbuttons more coherent"
This reverts commit 3887f5ec91.
2019-08-28 10:43:09 +02:00
Camilo Higuita
3887f5ec91 make the sizing of the toolbuttons more coherent
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height  if those props are set.

Before patch:

{F7274098}

After patch:

{F7274097}

Reviewers: #plasma, mart, ngraham

Reviewed By: ngraham

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23367
2019-08-23 16:35:37 -05:00
Camilo Higuita
f973619116 make button icons follow a reasonable size and layout
Summary:
with the Plasma style buttons which have an icon look wrong. The icon size is too big and in consecuence the whole button is drawn way too big.
With this patch the icon is set to a standard size and drawn in the button layout, in a way it looks consistent with other button with no icons.

example:

Before path:

{F7270612}

{F7270611}

With patch:

{F7270610}

{F7270609}

BUG: 399952
FIXED-IN: 5.62

Reviewers: #plasma, mart, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23352
2019-08-22 17:28:27 -05:00
l10n daemon script
9a3351fae5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-20 04:58:25 +02:00
David Edmundson
d62e99460a Allow applets/containments/wallpaper to defer UIReadyConstraint
Summary:
This is needed so that we don't remove the splash till the wallpaper is
loaded, but also allows doing this in a generic way.

Version 2 of the patch using a normal property.

We need to have the virtual so that the containment waits for the
wallpaper.

Test Plan:
Used with wallpaper patch
Added debug to ensure it happened after the stackview in the wallpaper
is pushed

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22852
2019-08-19 10:51:30 +01:00
l10n daemon script
56aa6dee3a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-17 05:07:40 +02:00
l10n daemon script
e454afa352 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-16 05:09:03 +02:00
l10n daemon script
dbe0c8ac73 GIT_SILENT Upgrade KF5 version to 5.62.0. 2019-08-11 07:15:53 +00:00
Noah Davis
134b2ac331 Make notification icons look like bells
Summary: BUG: 384015

Test Plan:
See D23018

{F7178298, size=full}

Reviewers: #vdg, #plasma, broulik, ngraham

Reviewed By: #vdg, #plasma, broulik, ngraham

Subscribers: ngraham, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23019
2019-08-09 07:43:42 -06:00
Konstantin Lisin
144bb90715 Fix incorrect initial tabs position for vertical tab bars
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.

BUG: 395390
FIXED-IN: 5.62

Reviewers: #plasma, ngraham, hein

Reviewed By: #plasma, ngraham, hein

Subscribers: kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10047

Differential Revision: https://phabricator.kde.org/D23036
2019-08-08 20:33:19 -06:00
Nate Graham
d186d5421b Revert "Fix incorrect initial tabs position for vertical tab bars"
I committed this patch without the author's attribution, sorry
This reverts commit e2cd97d822.
2019-08-08 20:32:28 -06:00
Nate Graham
e2cd97d822 Fix incorrect initial tabs position for vertical tab bars
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.

BUG: 395390
FIXED-IN: 5.62

Reviewers: #plasma, ngraham, hein

Reviewed By: #plasma, ngraham, hein

Subscribers: kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10047

Differential Revision: https://phabricator.kde.org/D23036
2019-08-08 20:28:15 -06:00
Laurent Montel
4b427e4f03 Add missing include 2019-08-08 13:02:11 +02:00
l10n daemon script
bbad328bc2 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-05 04:45:06 +02:00
l10n daemon script
2ac6999881 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.61.0 release. 2019-08-03 19:36:41 +00:00
Kai Uwe Broulik
1f0215ebc6 [ToolButtonStyle] Use same color group for hovered state
This is a remnant from when we used a full background on hovered ToolButtons
instead of the frame we have now. It broke icon item appearance when hovered
in a custom ColorScope.

Reviewed-By: notmart
2019-08-02 13:29:51 +02:00
l10n daemon script
781d2f6fff SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-07-31 05:13:30 +02:00
David Edmundson
17d49c0bce Handle colors file in fake plasma theme installer 2019-07-25 00:15:30 +01:00
David Edmundson
08a6a4a7cd Install plasma theme into local XDG_DATA_DIR for icon test
Summary: Relevant code is moved from dialognativetest into a header for sharing

Test Plan: Unit test

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22732
2019-07-24 23:53:39 +01:00
Jonah Brüchert
31cd4f8d8e
Apply busy indicator duration change of D22646 to the QQC2 style
Summary:
Match the duration (2 seconds) that was set in D22630.

This style is mainly used by Plasma Mobile, therefore requesting team review from that project as well.

Reviewers: #vdg, #plasma:_mobile, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22720
2019-07-24 21:13:28 +02:00
David Edmundson
af2a7fbf69 Compile package structure plugins into expected subdirectory
Summary: This means they're found by unit tests pre-installation

Test Plan:
Removed installed files
Ran make (but not make install)
ConfigModelTest now passes

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22682
2019-07-24 17:07:29 +01:00
Noah Davis
b0541ffbff Change Highlight to ButtonFocus
Summary: Changed Highlight to Button focus so that these SVGs wouldn't use the same color as the selection background.

Reviewers: #vdg, #plasma, #breeze, ngraham

Reviewed By: #vdg, #breeze, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22670
2019-07-24 03:34:52 -04:00
l10n daemon script
47281f2a64 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-07-24 05:33:26 +02:00
Aleix Pol
04c0ff5cd7 Make sure we compare paths properly 2019-07-23 19:41:05 +02:00
Aleix Pol
72ff860ef0 Fix running the dialognativetest without installing
Reviewed by David Edmundson
2019-07-23 19:38:23 +02:00
Marco Martin
0e859870a9 Search for the plugin of the other plasmoid
Summary:
Some applets use completely the code of another one with the key
X-Plasma-RootPath.
At the moment it doesn't work on applets that have a binary plugin portion
This makes pluginloader load the plugin of the original applet we're using

Test Plan:
an applet that falls back to one that has a binary plugin now works.
ones that fall back to applets without binary plugin still work
normal applets as well

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22675
2019-07-23 11:13:13 +02:00
Nate Graham
28bc0f3ea1 [Busy Indicator] Match duration of QQC2-desktop-style version
Summary: Match the duration (2 seconds) that was set in D22630.

Reviewers: broulik, #vdg

Reviewed By: broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22646
2019-07-22 07:58:17 -06:00
Harald Sitter
a965fa4cb8 remove dangling remote widgets code
Summary:
can't be enabled anywhere + not actually doing anything as there is no
backing for it in the cpp + qca isn't even looked for by cmake

Test Plan: none

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22618
2019-07-22 10:02:03 +02:00
David Edmundson
0e14ab6eca Remove deprecated tests
Summary:
Plasma::KPackage is deprecated in favour of KPackage.
There are much better tests there.

Storage is completely unused, no point testing it.

Test Plan: Compiles

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22611
2019-07-21 16:11:37 +02:00
Noah Davis
249365e327 Remove hardcoded colors (view.svg, system.svg) 2019-07-21 04:09:26 -04:00
Aleix Pol
f04584d423 Add missing components in org.kde.plasma.components 3.0
Summary:
These were created but never installed. Was looking into porting krunner
to 3.0 and they were missing.

Test Plan: Used them in the WIP port of KRunner

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22546
2019-07-19 16:16:19 +02:00
Nate Graham
4e35b61a83 Update refresh and restart icons to reflect new breeze-icons versions
Summary:
Like D22534, but for the Plasma theme.

CCBUG: 409914

Reviewers: #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22541
2019-07-18 20:40:36 -06:00
Aleix Pol
d721555929 itemMouse isn't defined in plasma.components 3.0 2019-07-19 02:48:00 +02:00
Marco Martin
ccceb83b10 use clearItems when an applet gets deleted
back when this was written KConfigSkeleton didn't have clearItems
and setDefaults can still leave some cruft behind
this ensures all is gone
2019-07-18 17:44:15 +02:00
David Edmundson
03d406770f Fix crash if swtichSize is adjusted during initial setup
This causes us to create components and items during the initial binding
evaluation of the root.

Reviewed-by: Marco Martin
2019-07-17 11:57:40 +02:00
Marco Martin
05daa3e206 react when switchWidth/Height changes
if switchWidth or height changes dinamically,
compactRepresentationCheck has to be ran again, otherwise
it can happen the situation where applets have both rapresentations in
the same view
2019-07-15 13:57:48 +02:00
l10n daemon script
348c578bb9 GIT_SILENT Upgrade KF5 version to 5.61.0. 2019-07-13 08:34:00 +00:00
Aleix Pol
e6cbea39ff Remove unused bits in ContainmentAction 2019-07-10 19:26:50 +02:00
Aleix Pol
21227e0f98 Improve plugin caching
Summary:
Extend the plasmoid startup cache to DataEngines and ContaimentActions.
Include a cache for script engines. In practice it's always the same, we don't
need to check the file system every time.

Reviewers: #plasma, davidedmundson, mart

Reviewed By: #plasma, davidedmundson, mart

Subscribers: davidedmundson, mart, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22258
2019-07-08 13:48:05 +02:00
l10n daemon script
6d53dfad57 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.60.0 release. 2019-07-06 13:18:41 +00:00
l10n daemon script
875dbab70c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-07-06 05:15:02 +02:00
Kai Uwe Broulik
214838313d [Svg] Fix porting error from QRegExp::exactMatch
The CACHE_ID_NATURAL_SIZE adds stuff around the argument string, so explicitly move the ^ and $ outside.

Differential Revision: https://phabricator.kde.org/D22275
2019-07-05 08:56:38 +02:00
Aleix Pol
46f0da45c6 ContainmentAction: Fix loading from KPlugin
Summary: At the moment it was enabled in the PluginLoader but we were not using it anywhere.

Test Plan: See patch in plasma-workspace.

Reviewers: #plasma, #frameworks, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22267
2019-07-05 01:04:07 +02:00
Albert Astals Cid
35862c093d GIT_SILENT Upgrade Qt5 version requirement to 5.11.0. 2019-07-04 19:27:37 +02:00
Aleix Pol
e3c6c2731e regular expression shouldn't be static 2019-07-04 12:20:42 +02:00
Aleix Pol
6c692309ed Better use of Qt APIs in Plasma::Theme
Summary:
Try not to access hashes repeatedly.
QRegExp -> QRegularExpression.

Reviewers: #plasma, #frameworks, fvogt, mart

Reviewed By: #plasma, mart

Subscribers: bruns, tcanabrava, fvogt, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22147
2019-07-02 16:46:53 +02:00
Filip Fila
97272465a8 [TabBar] Remove exterior margins
Summary: This allows us to glide active tabbar indicators on lines, which we cannot do now in Kickoff due to this limitation in the control.

Test Plan:
Before:
{F6936102}

After:
{F6936103}

Reviewers: #vdg, #plasma, ngraham, ndavis

Reviewed By: #vdg, ngraham, ndavis

Subscribers: ndavis, apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22108
2019-07-01 00:06:17 +02:00
Bhushan Shah
7ae271987c pluginloader: Change behavior of X-KDE-ParentApp
Summary:
X-KDE-ParentApp is the key in desktop file to display that given service
or application is part of the another application or extension of other
application. In KDE4 this key was used to mark applets to be used in the
specific application like plasma-desktop, kdevelop, amarok etc.

In KF5 world, none of this applications have applet loading mechanism
apart from plasma*, and there are likely only Plasma applet, containment
or dataengines.

Previous API, when no/empty parentApp was passed would filter out every
application which had something as parentApp. This was to ensure only
compatible plugins are loaded in Plasma. This resulted in applets
getting excluded if they suggested that org.kde.plasmashell is their
parent application. Refine this API to,

- If no/empty parentApp is provided, provide all applets
- If parentApp is provided, filter by applet

This behavior is more filter like instead of other way around.

CHANGELOG: Applet, DataEngine and containment listing methods in
Plasma::PluginLoader no longer filters the plugins with X-KDE-ParentApp
provided when empty string is passed.

Test Plan:
tested that plasma loads properly, plasmaengineexplorer lists
all engines and plasmawindowed works fine. Neverthless requires more testing

Reviewers: mart, apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22049
2019-06-23 20:39:41 +05:30
Marco Martin
9f04ae48e2 make pinch in calendar work again
work around https://bugreports.qt.io/browse/QTBUG-76569
with an empty mousearea on top
2019-06-21 17:20:06 +02:00