54 Commits

Author SHA1 Message Date
Marco Martin
80516dbef0 framework part of the applet alternatives chooser
this is the little part in plasma-framework for the applet alternatives chooser.
works together the branch mart/alternativesConfig of plasma-workspace and plsma-desktop.
for how it looks and why, see the vdg forum thread:
https://forum.kde.org/viewtopic.php?f=285&t=122067&p=315919#p315919

still possible problems:

I'm not sure about using a new desktop file entry X-Plasma-Provides, maybe Categories could be enough, but it may produce many false positives as well

REVIEW:119409
2014-07-23 12:25:32 +02:00
Lukáš Tinkl
cdce8e5445 don't replace ampersands for an underscore
in context menu actions
2014-07-18 22:36:13 +02:00
Marco Martin
188d131d77 make the uiloaded tests pass
work in case of every order the various applets and containments emit uiready
REVIEW:119284
2014-07-15 10:16:10 +02:00
Aleix Pol
dac1d8f265 Figure out why my plasma wasn't notifying the startup
Make sure AppletPrivate::uiReady is set in applet_p.cpp when we report that
the ui is ready.
Make sure that if we loop through all the containments and they're all
ready, we emit that it's done.

So far, Corona::startupCompleted was never emitted.

REVIEW: 119220
2014-07-14 13:23:20 +02:00
Aleix Pol
e008a5d7d4 If a timer is active and we start it, it will restart
No need to check if it's active and stop it first, according to the
documentation.
2014-07-11 19:15:06 +02:00
Aleix Pol
92a8007489 Introduce TimeTracker debugging tool for plasma
TimeTracker is a small class that keeps track of an object the changes in
the properties of an object and relates them to a point in time. This way
we can see how things change and react to each other. Then, this information
is exported into a json file to analyze.

REVIEW: 119199
2014-07-10 19:20:59 +02:00
Aleix Pol
124dc4799a fix build 2014-07-09 18:23:58 +02:00
Aleix Pol
f5f96c1390 Remove unneeded casts
They're all because we're accessing the d-pointer of the parent class (!),
we can access it without casting.
2014-07-09 18:20:32 +02:00
Aleix Pol
8fb62cc0a4 Cleanup
Re-use containment variable instead of keep fetching it every time. It's
not a trivial function, so better reduce the calls.
2014-07-09 12:43:08 +02:00
Aleix Pol
ae996c6666 --deprecated call 2014-07-09 12:36:34 +02:00
Marco Martin
b6ac8ded88 forcefully remove some entries
newly created containments may have some default entries like plugin
or formfactor written in the config group, but not in keyList()
they have to be explicitly removed because wouldn't be removed in
deleteGroup
BUG:335792
2014-06-04 17:28:11 +02:00
Marco Martin
f7e25fe696 don't link to xml and iconthemes 2014-05-19 19:09:09 +02:00
Marco Martin
682bf5f149 if containment gets destroyed, destroy all dialogs
BUG:334977
2014-05-19 11:15:51 +02:00
Marco Martin
9d3344d0a6 close the remove dialog if containment locks
BUG:334978
2014-05-19 11:11:19 +02:00
Eike Hein
1805bb7496 Make sure the args part of Containment::createApplet(..., args) ends up in the applet. 2014-05-06 20:52:42 +02:00
David Edmundson
4ce14a1654 Remove duplicated ConfigLoader
This moved to KConfigGui as KConfigLoader.

Use of private KConfig API in Service had to be ported to use only
public method.

REVIEW: 117784
2014-04-26 17:10:13 +02:00
Kevin Ottens
72ba7b4146 Apply the astyle-kdelibs script 2014-04-26 01:48:37 +02:00
Marco Martin
47dfda75c0 introduce the signal Corona::startupCompleted()
when emitted we are sure all containments *graphics objects*
 have been created
2014-04-22 14:58:12 +02:00
Aleix Pol
9a305de76d Fix activationAction connection
It was connecting to a deprecated signal, use QAction::changed instead.
Since QAction::changed is more generic and modifying the shortcut seems
expensive, actually check that the property is different from the previous
value.

Reviewed by Vishesh Handa.
2014-04-12 20:09:08 +02:00
Marco Martin
614af69f02 never show the dialog on destroy()
the remove action is now hooked to another slot, askDestroy()
it *MAY* solve the "Do you wish to remove this default desktop" bug, or may get it worse
CCBUG:332137
2014-03-20 19:22:27 +01:00
Marco Martin
3bb0e7d3d0 use the config of the applet parent of containment
that's the systray specific hack
2014-02-06 12:12:43 +01:00
Marco Martin
362a5017b6 support a corona child of an applet
this is an ad-hoc thing for the systray, would be better not having something like that
2014-02-03 18:47:51 +01:00
Christophe Giboudeaux
d71f581115 Remove unneeded includes 2013-12-19 15:23:02 +01:00
Àlex Fiestas
cddee3cbf2 Use KActionCollection::addAction instead of add<T>
I'm not sure for what reason this was changed but it is clearly wrong,
we don't want to create a new action but rather re-add (as the hack says)
the action we took before.

Fixes "Empty action" in toolbox.
2013-12-18 21:36:28 +01:00
David Edmundson
ef58fdbf6f Remove Applet::Private::isContainment
Instead determine by introspecting if this inherits from Containment

REVIEW: 114405
2013-12-11 15:50:48 +01:00
Aleix Pol
6c82a1ee86 Reduce compiler warnings
Remove unused and deprecated headers
Port some K_GLOBAL_STATIC to Q_GLOBAL_STATIC
2013-12-09 16:50:18 +01:00
Marco Martin
fab4818c92 allow plasmoids to change icon
changing icon will change the icon of the default compact representation
2013-09-23 16:44:31 +02:00
Marco Martin
786bd7b7af emit uiready also for empty containments 2013-09-13 20:03:25 +02:00
Marco Martin
590cb7baa7 a property in Applet to tell if the user is configuring
pure model, doesn't actually carry the config dialog, but serves as bookkeeping
2013-08-20 18:17:20 +02:00
Marco Martin
04650605e5 don't emit uireadychanged if not changed 2013-08-12 13:38:31 +02:00
Marco Martin
8750d01f40 move the tracking of uiReady into libplasma
doesn't still have nothing about ui, is completely bookkeeping, but is
easier to have it correct there
2013-08-09 21:51:13 +02:00
Chusslove Illich (Часлав Илић)
2e7c58b987 Temporary fix for translations location binding.
insertCatalog calls will not be used either way.
2013-08-05 11:19:11 +02:00
Sebastian Kügler
d9aa851e17 Fix fallout from qDebug -> kDebug porting
* Multi-line debug statements were essentially broken
* There's still a bunch of #include "QDebug" in there, which seems wrong

* It's not necessary to comment most occurrences in src/plasma, since
  they're wrapped wiht #ifdef NDEBUG already.

CCMAIL:ervin@kde.org
2013-08-01 12:15:38 +02:00
Kevin Ottens
0e590217f8 Port away from kdebug 2013-07-30 08:05:09 +02:00
Sebastian Kügler
fc2afcb9a1 Port global applet shortcut from KAction to QAction
- use QAction instead of KAction
- use KGlobalAccel for global shortcut registration and query
2013-07-10 01:45:41 +02:00
Sebastian Kügler
e02925b7b5 Use QAction internally in defaultActions() 2013-07-10 00:15:55 +02:00
Marco Martin
ad2fe77745 get rid of Plasma::Constraint 2013-05-14 18:08:58 +02:00
Marco Martin
e07600a83f Put all Plasma emums in a Types class
This makes possible to use them directly frmo QML
as a minus, is not pretty and requires tons of search and replace in old
c++ code
2013-05-10 19:29:13 +02:00
Marco Martin
e7ca00e534 move the config dialog in the shell
it still doesn't successfully load
2013-04-24 22:54:46 +02:00
Marco Martin
79d5724ef1 always emit Containment::requestConfiguration()
emit that signal when the configure action is treggered for each applet,
the applet pointer to the interested applet is passed

is the first step for moving config ui i the sell
2013-04-20 18:31:57 +02:00
Sebastian Kügler
b1ce94159d KDE::icon becomes QIcon::fromTheme 2013-04-02 12:55:37 +02:00
Sebastian Kügler
58537d36ed setFocus has gone from Applet 2013-03-19 03:33:33 +01:00
Marco Martin
f4de55af67 use KAction from kde4support
it should buld again, usingkaction as type for kactioncollection
2013-03-04 15:46:47 +01:00
Marco Martin
fda16dee08 don't export AppletPrivate 2013-03-01 14:29:14 +01:00
Marco Martin
c3924c75b7 remove createConfigurationInterface
configuration interface stuff is done right now in the ConfigView class, right now in the qml scriptengine (may be moved to the shell eventually)
2013-03-01 11:36:58 +01:00
Aaron Seigo
56d73373ac when reseting the config loader, also make it re-read the config 2013-02-26 14:50:41 +01:00
Aaron Seigo
9478edaa05 lazy create the config loader on demand, reset when appropriate 2013-02-26 14:50:41 +01:00
Aaron Seigo
9ab4acd23a get rid of constructors which take QVariantList args as much as possible
was used to pass in URLs to construct the applet with ... which is
not the nicest of APIs as it is entirely undocumentable
2013-02-25 18:08:12 +01:00
Aaron Seigo
a674a7b894 expose the KActionCollection rather than wrap its API 2013-02-25 16:36:27 +01:00
Marco Martin
3ce3048ad1 Containment::ToolType -> Plasma::ActionType
actions categories are no more Toolbox-specific, but generic properties for actions
2013-02-19 14:04:20 +01:00