Commit Graph

13420 Commits

Author SHA1 Message Date
Marco Martin
ddc08a2d4c another check for valid plugininfo
quite an edge case, but otherwise malformed packages can cause an assert
2014-09-01 18:56:53 +02:00
Marco Martin
c2518b66f9 another valid plugininfo guard 2014-09-01 18:35:09 +02:00
Marco Martin
a54da78ce8 check for plugin validity 2014-09-01 18:17:22 +02:00
Marco Martin
7e73be169c add a timeout, in case the cycle was infinite 2014-09-01 16:40:38 +02:00
Marco Martin
5db7db4ae2 crash-- 2014-09-01 16:26:34 +02:00
Marco Martin
325ea71a2e remove the fallback from the metadata 2014-09-01 16:01:10 +02:00
Marco Martin
36e585d7e7 comments++ 2014-09-01 15:53:58 +02:00
Marco Martin
5ceb8d1197 add an autotest for fallback
correct a couple of problems the test catched
2014-09-01 15:51:05 +02:00
Marco Martin
55a6095138 use Floyd cycle detection 2014-09-01 15:15:54 +02:00
Marco Martin
21cf68dbd2 set directly the fallback package not its path 2014-09-01 14:54:10 +02:00
Marco Martin
aba4dcb915 introduce setFallbackPackagePath
the fallback package would then be decided by the packagestructure
2014-09-01 14:00:06 +02:00
Andrew Lake
763cfefd55 update Breeze plasma theme icons to follow main Breeze icon theme style. 2014-08-31 14:22:06 -07:00
Nicolás Alvarez
51b77bcd59 Don't use QStringLiteral when concatenating string literals.
QStringLiteral("foo" "bar") is documented not to work on MSVC.
2014-08-30 14:46:36 -03:00
Nicolás Alvarez
123d5a6d8b Replace #warning with #pragma message.
MSVC doesn't have #warning.
2014-08-30 14:46:11 -03:00
Nicolás Alvarez
8515d0ef09 Fix reference to Types::ImmutabilityType.
I don't know how Types::Types::ImmutabilityType even worked in gcc...
2014-08-30 14:45:50 -03:00
Nicolás Alvarez
0807dda74f Add missing cstdint include.
Needed for uint32_t.
2014-08-30 14:45:21 -03:00
Marco Martin
f89b86589f almost same order as the context menu
the leave action is still fixed as the last one by the toolbox

CCBUG:338585
2014-08-29 18:01:10 +02:00
Aaron Seigo
faf75a95e5 ws for readability
REVIEW:119992
2014-08-29 17:24:43 +02:00
Aaron Seigo
cd87344d80 make PackageStructure plugins use the json method as with DataEngines 2014-08-29 17:24:43 +02:00
Aaron Seigo
aa99a4f15c tidy up the data engine plugin loading code 2014-08-29 17:24:43 +02:00
Aaron Seigo
67cab00bf3 remove the unused ContainmentPackage 2014-08-29 17:24:43 +02:00
Marco Martin
f934b3b6d6 make sure to cleanup applet pointers on deletion 2014-08-29 14:53:56 +02:00
Vishesh Handa
012e002092 Dialog: Add accidentally removed Q_PRIVATE_SLOT 2014-08-29 14:35:47 +02:00
Marco Martin
727755d28a action order nearer to menu
still catalog actions by type
the order is still not exactly the same, but that's not possible, since the action order is decided in the context menu plugin and there are some actions only in the toolbox

CCBUG:338585
2014-08-29 13:32:19 +02:00
Sebastian Kügler
d8b2ef147f typo-- in comment 2014-08-28 23:30:29 +02:00
Sebastian Kügler
714bb667fc Minor fixes
- Fix encoding in copyright
- compile-time syntax for iconLoaderSettingsChanged slot
- --stray ;
2014-08-28 23:26:12 +02:00
Vishesh Handa
f293888be6 Dialog: Avoid adjusting the geometry twice when with visualparent
We are in a strange cycle when we have a visual parent. In order to
obtain our position, we need to know our size. Our size depends on the
borders visible. The borders visible depend on the size.

When we do not have a visual parent this is not a problem as we do not
have a position where we are supposed to be.

In order to solve this cycle, when we have a visual parent, we typically
assume we have all borders, call popupPosition, move to that position
and then use that new position to figure out the borders, get the new
size (incase any borders have changed) and move again. This double
moving is not good. With that patch, we still do the same but we avoid
moving twice.
2014-08-28 18:25:03 +02:00
Vishesh Handa
e0ea93cb7e Dialog: Use the correct screen for repositioning when overflowing 2014-08-28 17:35:05 +02:00
Vishesh Handa
b403343be5 Dialog Test: Add a test for making the dialog fullscreen
We seem to have code in order to toggle between fullscreen/normal in the
dialog. It's good to have a test since it clearly does not work.
2014-08-28 16:29:00 +02:00
Vishesh Handa
8a3f38511d Dialog: Set the correct popup position on layout width/height change
We seem to have cases where once the dialog is visible and the visible
event is over, then the width/height updates itself, so we need to
reposition the dialog appropriately.
2014-08-28 16:28:56 +02:00
Vishesh Handa
eb6ea04be7 Dialog: Dot not update layout width/height unlesss completed
The functions are often called a number of times before the
component is actually completed. There is no point of this.

Also added a function updateLayoutParameters which update all 4
of these in a more efficient manner. There is a certain amount
of code duplication between those 4 functions and this one, but
that can be fixed in another patch.
2014-08-28 16:15:26 +02:00
Marco Martin
b58a3ef754 add a FIXME comment 2014-08-28 16:15:12 +02:00
Marco Martin
85fa280111 Merge branch 'mart/QtControlsSlider'
REVIEW:119974
2014-08-28 16:14:24 +02:00
Marco Martin
f7eb69f078 comment++ 2014-08-28 16:06:48 +02:00
Marco Martin
60976b67ae more comment&docs 2014-08-28 16:04:02 +02:00
Vishesh Handa
4f622a5158 Dialog: Fix poisitioning and theme rendering
- updateTheme should always be called the frameSvgItem's size has been
  upated. It uses the geometry of the frameSvgItem. Also updated the
  documentation.

- When a dialog has a visualParent, setting the position of the dialog
  is slightly compilcated. In order to set the position we have to give
  the function popupPosition the size of the dialog so that it can
  determine where to place it, however the size of the dialog depends on
  the position as some of the borders are drawn depending on the
  position. We have a circular problem.

  For now we're solving this by tempoarily giving the full size with all
  the borders in the case when there is a visual parent.
2014-08-28 15:49:16 +02:00
Vishesh Handa
a9c5e6d96c Dialog Positioning Test2: Simplify the code 2014-08-28 14:59:10 +02:00
Vishesh Handa
15a993cf67 Dialog: Add another test for testing the positioning
The code has been adapated from the Panel toolbox. This test currently
fails.
2014-08-28 14:47:31 +02:00
Marco Martin
846f740dae fix copyright 2014-08-28 14:25:48 +02:00
Marco Martin
4ac3652d10 some documentation fixes 2014-08-28 14:21:12 +02:00
Vishesh Handa
30174dd367 Dialog: Mark componentComplete as false on creation 2014-08-28 13:17:17 +02:00
Marco Martin
d6b08c303a style tickmarks 2014-08-28 13:15:09 +02:00
Marco Martin
4ec02e7b1d style handle and groove 2014-08-28 13:12:04 +02:00
Aaron Seigo
d5f156e968 add an interactive console QML definition 2014-08-28 11:52:49 +02:00
l10n daemon script
ce814a5285 SVN_SILENT made messages (.desktop file) 2014-08-28 08:49:15 +00:00
Marco Martin
6d6ff41aee start port of Slider 2014-08-27 18:51:52 +02:00
Vishesh Handa
eef71f918e Dialog: Add a test to test visualParent changes 2014-08-27 18:16:24 +02:00
Vishesh Handa
e00b1cab5c Dialog positioning test: Set the correct height 2014-08-27 18:16:24 +02:00
Vishesh Handa
e3c1095d92 Dialog: Remove syncTimer
Remove the timer and call syncToMainItemSize directly whenever it used
to be called. We avoid the extra event loop this way. This probably
breaks somethings, but we can figure that out and add tests for that.
2014-08-27 18:16:24 +02:00
Vishesh Handa
9ddbd93855 Dialog: Remove syncMainItemToSize
The only place it is now used is when the window x/y position changes.
There is now a dedicated function to handle that.

This brings us one step closer to removing the entire sync timer
2014-08-27 18:16:24 +02:00