Commit Graph

2877 Commits

Author SHA1 Message Date
Aaron J. Seigo
9234ac63e9 this method should also be protected
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802289
2008-04-29 02:35:56 +00:00
Aaron J. Seigo
daf3d7a4a2 API REVIEW: needsConfiguring() => configurationRequired
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802288
2008-04-29 02:34:21 +00:00
Aaron J. Seigo
0402391d17 we don't need our own shape() here anymore; it really hardly worked at the best of times and was we move to window decos it'll become irrelevant anyhow
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802287
2008-04-29 02:30:23 +00:00
Aaron J. Seigo
1847d60a1d API REVIEW: launchActivated -> releaseVisualFocus; more generic and a bit more obvious as to its purpose
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802286
2008-04-29 02:28:35 +00:00
Aaron J. Seigo
53a6938a87 schedule a configuration sync upon loading the default setup
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802285
2008-04-29 02:19:12 +00:00
Aaron J. Seigo
5d287cfcbb one more slot pimpl'd
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802282
2008-04-29 01:41:24 +00:00
Aaron J. Seigo
c6f866378d not a slot
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802280
2008-04-29 01:24:00 +00:00
Aaron J. Seigo
13fcca652e move dataengine private details into the pimpl
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802279
2008-04-29 01:17:12 +00:00
Joseph Burns
4b0bc4fb5a API Review: uninstallPackage -> packageName instead of param package
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802278
2008-04-29 00:56:33 +00:00
Aaron J. Seigo
2dd5891029 with some intriguing grotesqueness internal to the library, we can simplify the API and remove location/formFactor from Containment and just use the ones in Applet; externally this is probably rather safer
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802277
2008-04-29 00:49:10 +00:00
Aaron J. Seigo
b94c6913ff small optimization: prevent reconnecting (and likely a delete and new of a SignalObject) when the requested polling interval and the current one are the same
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802273
2008-04-29 00:26:33 +00:00
Aaron J. Seigo
9a156375a3 SVN_SILENT: a bit more useful debug in places
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802271
2008-04-29 00:15:26 +00:00
Aaron J. Seigo
93882feae4 * more debug for when these issues arise
* nicer logic handling (no negation ;)

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802270
2008-04-29 00:10:43 +00:00
Aaron J. Seigo
69524609a3 remove createLayout from Containment. now each containment will need to implement its own layouting. this is not so big a deal since FreeLayout is no longer needed to make applets behave properly. now panels can do whatever the heck they want.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802255
2008-04-28 23:00:08 +00:00
Aaron J. Seigo
fa166c72ef SVN_SILENT: small ws fix that was laying around on disk here
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802253
2008-04-28 22:56:02 +00:00
Davide Bettio
b37d43eafd API REVIEW: showConfigurationInterface() -> nonvirtual
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802232
2008-04-28 21:23:27 +00:00
Rob Scheepmaker
571e8a0db6 ...oops?... Let's also add an implementation...
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802211
2008-04-28 20:37:10 +00:00
Marco Martin
ade65ba938 some fixes to the toolbox:
* the hoverEvent of the PanelToolbox is always accepted
* the hoverEvent of desktopToolbox is always accepted if the desktop is
  zoomed-out
* boundingRect size of PanelToolbox is halved since it does not zoom
  anymore on mouse over

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802195
2008-04-28 19:41:43 +00:00
Rob Scheepmaker
78bfa23fac added setTrackContainmentChanges to view. necesarry for improved drag&drop visualisation.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802187
2008-04-28 19:14:28 +00:00
Davide Bettio
78ef3e466c API REVIEW: createConfigurationInterface() -> virtual protected, not slot
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802169
2008-04-28 18:32:34 +00:00
Marco Martin
3e6877ab4d restored the toolbox mouse over edge detection, so the annoyance is
back.
at least it does wat is supposed to do now. so some discussion still needed
on what it's supposed to behave...

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802161
2008-04-28 17:55:34 +00:00
Davide Bettio
c32f8a4511 Replacing exec() with run(): this change wasn't discussed during the tokamak meeting.
run() method is more obvious than exec() (don't forget that a runner run :) ).
Anyway during the meeting we have decided to replace createMatchOptions() with createRunOptions()
and (set)hasMatchOptions() with (set)hasRunOptions(), now with this commit we have a more coherent naming.
CCMAIL: panel-devel@kde.org

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802143
2008-04-28 17:11:12 +00:00
Marco Martin
f06d25a00c API reviews:
globalName(), instanceName()->pimpl

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802135
2008-04-28 16:22:01 +00:00
Marco Martin
9bee311b96 API reviews:
ThemeChanged()->Q_PRIVATE_SLOT

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802130
2008-04-28 15:55:13 +00:00
Marco Martin
48be92bdab API reviews:
checkImmutability()->Q_PRIVATE_SLOT
added a q-pointer into Applet needed for this and themeChanged the other
Q_PRIVATE_SLOT that will be added

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802124
2008-04-28 15:41:18 +00:00
Anne-Marie Mahfouf
e985e96129 API review: pathChanged() not needed
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802098
2008-04-28 14:41:59 +00:00
Marco Martin
dfa4623a68 don't try to set StandardBackground if FormFactor is Horizontal or
Vertical
this fixes the panel layout on the first load when there is no
plasma-appletsrc

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802089
2008-04-28 14:18:19 +00:00
Robert Knight
cdb840d200 Print warnings if trying to assign invalid sizes to a panel or trying to generate a panel background with an invalid size. Prevents attempts to paint on an invalid pixmap leading to XRender errors.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801852
2008-04-27 22:34:24 +00:00
Robert Knight
ebdd9d4f99 Fix uninitialized variable.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801838
2008-04-27 21:49:09 +00:00
Aaron J. Seigo
b00807cee8 * containments should never have the applet background by default
* always call updateConstraints, not constraintsEvent directly to avoid unecessary multiple calls

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801817
2008-04-27 20:35:23 +00:00
Aaron J. Seigo
85f7ded2b4 SVN_SILENT: get rid of some dead code; with all the api changing happening, no point in keeping stuff around that isn't compiled
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801808
2008-04-27 20:09:20 +00:00
Anne-Marie Mahfouf
26a01ffb64 API review Plasma::Package::knownPackages() -> Plasma::Package::listInstalled()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801796
2008-04-27 19:22:29 +00:00
Aaron J. Seigo
df1ba079e8 go back is isContainment. ActAs is just ugly ugly. i don't think anyone really gets confused over isContainment (e.g. confusing it with IsA ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801792
2008-04-27 19:05:06 +00:00
Marco Martin
7b8860b462 API reviews:
static constants now in pimpl
also, don't make assumptions on icon size

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801766
2008-04-27 17:09:48 +00:00
Davide Bettio
4845197db5 API REVIEW: protected slots -> not slots
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801707
2008-04-27 13:52:59 +00:00
Davide Bettio
3210ad5beb API REVIEW: contructor -> protected
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801701
2008-04-27 13:50:49 +00:00
Davide Bettio
370d6b0b7e protected slots -> not slots
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801699
2008-04-27 13:47:59 +00:00
Davide Bettio
1474ed7cbc API REVIEW: color() --> die
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801697
2008-04-27 13:37:53 +00:00
Davide Bettio
7672b1620c constraintsUpdated() -> constraintsEvent()
Probably it should be protected and we need also updateConstraints() like in applet.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801661
2008-04-27 11:23:09 +00:00
Davide Bettio
8cd95e4ae7 API REVIEW: updated containment to the new API (constraintsUpdated() -> constraintsEvent() + protected)
CCMAIL: aseigo@kde.org

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801659
2008-04-27 11:13:43 +00:00
Davide Bettio
ff16201431 API REVIEW: constraintsUpdated() -> constraintsEvent()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801656
2008-04-27 11:04:43 +00:00
Davide Bettio
5bc429daa9 API REVIEW: topLeft() -> dies
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801647
2008-04-27 10:26:42 +00:00
Davide Bettio
41d2aa43e4 watchForFocus() dies
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801641
2008-04-27 09:53:49 +00:00
Davide Bettio
624f8d0fb3 API REVIEW: needsFocus()->dies
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801640
2008-04-27 09:29:25 +00:00
Davide Bettio
55881aa054 API REVIEW: requestFocus() dies
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801637
2008-04-27 09:18:44 +00:00
Davide Bettio
7e5915f398 API REVIEW: FPS -> Fps
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801635
2008-04-27 09:02:18 +00:00
Script Kiddy
b4e4ff7ecb SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801563
2008-04-26 20:50:45 +00:00
Marco Martin
6989fb4388 adapt to api changes:
Animator::movementComplete() -> Animator movementFinished()

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801556
2008-04-26 20:24:02 +00:00
Marco Martin
311d2bafd2 added toggled() signal in the toolbox emitted upon mouse click.
will be needed for the panel toolbox.
and removing two pure virtual methods already declared in QGraphicsItem

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801445
2008-04-26 17:31:49 +00:00
Marco Martin
694c822bb0 API reviews:
flushUpdatedConstraints()->flushPendingCostraintEvents()

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801443
2008-04-26 17:13:59 +00:00