Summary:
QDate from/to JS Date has unexpected results, so use QDateTime to have a
timezone assigned to prevent conversions. That way the date values are
consistent.
The behaviour got changed with Qt 5.11 (see the linked bug report) which
lead to plasma showing the wrong dates in the calendar.
BUG: 394423
Test Plan:
Tested with and without this patch on Qt 5.10.1 and 5.11.0.
Now the correct date is displayed for -0004 and +0001 timezones.
Reviewers: #plasma, #frameworks, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, Zren, sharvey, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D13222
Summary:
* remove unneeded cmake includes
* consistently use org.kde.plasma.* prefix for names
* fix catalog names to match applet identifier
* bump min cmake version to 3.0
* remove duplicated X-KDE-PluginInfo-Name entries
* remove no longer (Plasma >=5.8) needed i18nd in wallpaper code
* prepare qml extension for ki18n usage
Reviewers: mart
Reviewed By: mart
Subscribers: kde-frameworks-devel, apol
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D10848
Dialogs don't show up in task bar and also don't have window decoration so they're not meant to be minimized.
However, they might still be minimized by external means, such as "Minimize All" plasmoid.
In this case hide the dialog. Also, Qt restores a minimize state when showing again, rendering the dialog inaccessible.
Before showing, always unset the minimized state using new Qt 5.10 API
BUG: 381242
Differential Revision: https://phabricator.kde.org/D12876
This reverts commit 612494e2b2.
This caused a huge regression for some drivers breaking functionality
completely. Better to revert for now, and try again when we have it
fully working.
See 393241
Summary:
Remove outdated calendar.svgz from air & oxygen themes which
still contained only the Plasma4 area calendar elements, but not
the (for now single) Plasma5 one, "event".
Given none of the old elements can be reused for the new element "event",
the complete files are removed for now.
Test Plan:
Selecting Air or Oxygen themes the event markers are now shown on days in
the calendar grid widget.
Reviewers: #plasma, mart, broulik
Reviewed By: #plasma, broulik
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D12680
Summary:
CalendarEvents::EventData (in KDeclarative) has a property isMinor, which is
described as "If set to true, it won't be marked in the calendar grid".
This patch fulfils that promise, by introducing separate roles on the model
which explicitly report the existance of any major or any minor events at a
given day, so that the marker loader can concentrate on the major events.
Test Plan:
Using a plasmacalendar plugin which feeds events with isMinor=true the
widget now only marks days which have major events.
Reviewers: #plasma, broulik, davidedmundson
Reviewed By: #plasma, broulik, davidedmundson
Subscribers: davidedmundson, broulik, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D12438
Summary:
Follows HIG in using verb-based name, also starting the text with the most
important objective first.
As result also consistent with default text for similar action in menu of a
normal app (when using KStandardAction).
Reviewers: #vdg, #plasma, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D12562
Otherwise the Text will never grow below its preferred height as the button grows smaller and will
eventually leak outside at the bottom rather than stay centered.
BUG: 393388
Differential Revision: https://phabricator.kde.org/D12518
Summary:
Dropping some item onto a containment results in a menu which lists widgets
and wallpaper plugins without explicitly telling what will happen onto
activation.
Changing the menu entries into "Add widget" and "Set wallpaper" makes it
more obvious what they will result in.
Reviewers: #vdg, #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D12247
Opening the toolbox when widgets are locked reveals the widget handles but they're empty as all the actions are unavailable.
Just refuse to enter edit mode then.
Differential Revision: https://phabricator.kde.org/D12379
Summary: Otherwise the flat property is ignored
Test Plan: Tested on KDE Connect port to use PlasmaComponents
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: mart, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11652
Summary:
add a version of containmentForScreen which it has the activity.
which is correct as the activity id of containments in in libplasma side.
this ensure the correctness of shellCorona createContainmentForActivity
as now it works also for activities different from the current one.
to make multimonitor a tad safer with it, when creating containments for an activity, initialize their lastScreen to the asked screen.
Test Plan: tried with an old plasmashell and is perfectly retrocompatible
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11361
Summary:
The original owner of a graphics item is the declarative applet script which
is owned and deleted by the applet.
Reparenting the containmentquickitem to the containment doesn't really
solve anything useful, we were originally effectively owned by the
containment(an applet subclass) not the view anyway.
This code also accidentally moves the destruction of the applet from being in
::~Applet to being in ::~QObject of the relevant containment. This
causes a big problem if the AppletQuickItem tries to access the applet
in it's own destructor. The applet object still exists, but use of
Applet member variables is not valid.
The new preloading code does this, leading to a crash.
BUG: 391642
Test Plan:
Changed desktop to folder twice
Changed activities twice
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: rikmills, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D12064
Summary:
To avoid black text on black background and thus confusion if things are
working after the initial generation from the template and first test build
and installation, also set an background with themed color.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11922
