1512 Commits

Author SHA1 Message Date
Albert Astals Cid
39aa628e17 Remove Qt version check
Now that Qt 5.10 is the minimum required version
2019-01-07 00:35:45 +01:00
Chris Holland
e5949866bb [Calendar] Expose firstDayOfWeek in MonthView
This allows for calendar widgets to override the Locale. Users may
want to start the week on a Sunday, Saturday, or Monday without
changing their locale's date formatting.

CCBUG: 390330

Differential Revision: https://phabricator.kde.org/D15321
2019-01-03 16:58:58 -05:00
Laurent Montel
03fbd3318b Add override 2019-01-03 21:42:30 +01:00
Shubham Jangra
e3aa2cf840 Fix comparision between signed and unsigned integer warning 2018-12-12 00:07:21 +05:30
Shubham Jangra
1bba82535c Fix unused parameter warning 2018-12-11 23:47:39 +05:30
Laurent Montel
e7329b95ed Use isEmpty() 2018-11-30 07:58:34 +01:00
Laurent Montel
7931bdccdd Remove virtual keyword 2018-11-30 07:58:34 +01:00
Marco Martin
52ba5871b1 same behavior as qwidgets comboboxes
popup opens on press, moving the cursor over items and releasing
actually triggers it.
Same logic as in the desktop style
2018-11-29 13:57:35 +01:00
Marco Martin
e4c2f65c95 feature parity of Menu with the Desktop style 2018-11-28 16:35:43 +01:00
Marco Martin
2880333aab default values for tooltips
same policy as the tooltips in desktop style
2018-11-28 13:02:38 +01:00
Marco Martin
030159571c make sure flickables are pixelaligned 2018-11-26 14:54:36 +01:00
Marco Martin
3e76176bdd less spacing 2018-11-22 11:00:20 +01:00
Kevin Funk
421e1c0126 ASAN: Fix memory leak in CalendarPlugin
Trace:
Indirect leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x508a17 in __interceptor_malloc (/home/kfunk/devel/install/kf5/bin/plasmashell+0x508a17)
    #1 0x7fcf92aa6230 in QHashData::allocateNode(int) /home/kfunk/devel/src/qt5.11/qtbase/src/corelib/tools/qhash.cpp:479:79
    #2 0x7fcf7a851d10 in QHash<int, QByteArray>::detach() /home/kfunk/devel/build/qt5.11/qtbase/include/QtCore/../../../../../src/qt5.11/qtbase/src/corelib/tools/qhash.h:275:51
    #3 0x7fcf7a8519c9 in QHash<int, QByteArray>::insert(int const&, QByteArray const&) /home/kfunk/devel/build/qt5.11/qtbase/include/QtCore/../../../../../src/qt5.11/qtbase/src/corelib/tools/qhash.h:769:5
    #4 0x7fcf7a859736 in EventPluginsModel::EventPluginsModel(EventPluginsManager*) /home/kfunk/devel/src/kf5/plasma-framework/src/declarativeimports/calendar/eventpluginsmanager.cpp:42:17
    #5 0x7fcf7a854c55 in EventPluginsManager::EventPluginsManager(QObject*) /home/kfunk/devel/src/kf5/plasma-framework/src/declarativeimports/calendar/eventpluginsmanager.cpp:185:19
    ...

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17031
2018-11-20 15:15:59 +01:00
Kevin Funk
fbfc9bdebb ASAN: Fix memory leak in DataSource
Trace:
Direct leak of 216 byte(s) in 27 object(s) allocated from:
    #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
    #1 0x7fb2e9cd77d9 in Plasma::DataSource::setEngine(QString const&) /home/kfunk/devel/src/kf5/plasma-framework/src/declarativeimports/core/datasource.cpp:93:28
    #2 0x7fb2e9d5c8f1 in Plasma::DataSource::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) /home/kfunk/devel/build/kf5/plasma-framework/src/declarativeimports/core/corebindingsplugin_autogen/EWIEGA46WW/moc_datasource.cpp:330:21
2018-11-20 15:15:42 +01:00
Albert Astals Cid
e6f6bf9624 Qt 5.9 is now the minimum required version 2018-11-17 11:24:51 +01:00
Luca Beltrame
17c8927748
Add back (accidentally?) deleted line in CMakeLists.txt
Without this, ToolButton.qml (Plasma Components 3) is not installed and
applets like the mediacontroller do not load because they can't find it.

The line has been removed in 61269548168d5cd08a60826c7d417b002a698723,
and it looks like an unrelated change.

Marco, feel free to revert if the proper solution is different.

CCMAIL: notmart@gmail.com
2018-11-14 23:41:59 +01:00
Marco Martin
02d5c8a19f 100% consistency with kirigami heading sizing
reviewed-by: VDG and Nate
2018-11-13 14:34:00 +01:00
Marco Martin
b34b92346f more homogeneous look with Kirigami headings
tries harder to make the text weight light
2018-11-13 13:14:24 +01:00
Marco Martin
6126954816 install the processed version of private imports 2018-11-13 12:37:26 +01:00
Marco Martin
513923f7b5 Mobile text selection controls
Summary:
in QQC2 the text selection controls depend upon the style, which has to
implement it by itself
this adds touch based draggable cursor and text selection handles,
alongside a tiny toolbar for cut/copy/paste

the desktop style will need the exact same thing
T10023

Test Plan:
works correctly when in tablet mode, none of this is visible
when in desktop mode where the text fields behave normally

Reviewers: #plasma, bshah

Reviewed By: #plasma, bshah

Subscribers: ngraham, abetts, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16841
2018-11-12 17:45:10 +01:00
José Manuel Santamaría Lema
ed1724c63e Summary:
After this commit
https://cgit.kde.org/plasma-framework.git/commit/?id=9f08668147d2e99f8b5069ff50d5c54e672a87af
the iconitemtest started to fail, the reason was just a typo in the initial
"if" so it does exactly the same in the "if" and the "else" part. So let's
correct it to do what it is suposed to do.

Test Plan: Ran test

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16733
2018-11-08 16:23:20 +01:00
Laurent Montel
cbd5abf787 Remove qt include prefixx 2018-11-06 07:23:52 +01:00
Marco Martin
a1269ad059 revert icons scaling on mobile
plasma mobile can't handle that
2018-10-23 12:18:26 +02:00
Yuri Chornoivan
72ca2f79e0 Fix minor EBN issues and typos 2018-10-22 21:05:29 +03:00
Marco Martin
9b6c2cddc7 upport mnemonic labels 2018-10-19 13:43:17 +02:00
Marco Martin
21cd448c38 proper color group for icons 2018-10-17 17:57:32 +02:00
Marco Martin
584f7709e1 center text when no icon 2018-10-17 17:54:41 +02:00
Marco Martin
828ab59eb1 smaller dots 2018-10-17 13:42:44 +02:00
Marco Martin
64c5bfae65 add missing PageIndicator 2018-09-28 13:17:58 +02:00
Marco Martin
df6115193b better sizing for roundbutton
use tabletmode for hoverenabled
2018-09-28 13:05:43 +02:00
Marco Martin
f6008dafc4 follow colorscope 2018-09-24 18:13:50 +02:00
Marco Martin
938b9cc1a1 no hover effects on mobile 2018-09-24 17:58:51 +02:00
Marco Martin
ba3e94aa7f slightly translucent when disabled 2018-09-19 15:54:20 +02:00
Marco Martin
9f08668147 Add missing component: RoundButton 2018-09-19 15:48:27 +02:00
Marco Martin
57fc56acec same fixes as Slider 2018-09-07 15:21:09 +02:00
Marco Martin
86c1e87419 make use of hint-handle-size 2018-09-07 15:15:16 +02:00
Marco Martin
bc1253a918 align the groove in a better way 2018-09-07 14:56:49 +02:00
Marco Martin
764b6e4760 respect color group 2018-09-07 12:54:24 +02:00
Marco Martin
3c48aec7ac don't corrupt the active part
simplify the size hints
reviewed-by: kbroulik
2018-09-06 14:53:45 +02:00
Kai Uwe Broulik
a3e96eb17a [Plasma Components 3 Slider] Fix implicit size of handle
Fixes implicit size of the slider to include the handle
2018-09-06 14:43:38 +02:00
Kai Uwe Broulik
3d078c01ee [Plasma Components 3 ComboBox] Switch entries with mouse wheel 2018-09-06 14:41:55 +02:00
Marco Martin
85cab5772c Support button icons when present
Summary:
support button icons.
if there is no icon or is Qt 5.9, the iconItem will stay invisible

Test Plan: tested with ported mediacontroller to PlasmaComponents3

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15164
2018-09-06 14:06:44 +02:00
Marco Martin
bedd597560 stubs, warning-- 2018-09-06 14:05:14 +02:00
Kai Uwe Broulik
020d3e3ebe [Calendar] Wrap day name index around
Otherwise when the week starts on a day other than Sunday or Monday we access invalid day names.

CHANGELOG: Fixed week names not showing properly in calendar when week starts with a day other than Monday or Sunday

BUG: 390330

Differential Revision: https://phabricator.kde.org/D15309
2018-09-06 12:41:16 +02:00
Yuri Chornoivan
38431eebfa Fix minor typos 2018-09-05 22:22:38 +03:00
David Edmundson
2faa71a55a Workaround bug with native rendering and opacity in TextField text
Summary:
Problem is identified in https://bugreports.qt.io/browse/QTBUG-70138
with a potential patch for upstream.

With native rendering the alpha is pointlessly also set in the
glBlendFunc despite also being used in the uniform of the shader.
Resulting in a visual bug when used on a window with alpha (such as
Dialog)

It sucks, but we were starting to see people work round it by copying
more invasive workarounds everywhere else which I want to avoid.

BUG: 396813

Test Plan: Looked at a text field

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15021
2018-08-28 10:26:58 +01:00
Kai Uwe Broulik
a0ab02c052 [Icon Item] Watch KIconLoader icon change when using QIcon
QIcon is rendered through KIconLoader instead of e.g. Plasma::Svg.
This means we need to recreate the pixmap when the icon theme changes.

CCBUG: 397109

Differential Revision: https://phabricator.kde.org/D14990
2018-08-23 11:31:15 +02:00
Kai Uwe Broulik
e143f7d457 [Icon Item] Use ItemEnabledHasChanged
Preferred over having a connect and it go through meta signal invocation when it's emitted

Differential Revision: https://phabricator.kde.org/D14531
2018-08-17 15:46:29 +02:00
Kai Uwe Broulik
938cef210c Get rid of deprecated QWeakPointer usage
Replace by QPointer

Differential Revision: https://phabricator.kde.org/D14819
2018-08-17 15:44:08 +02:00
David Edmundson
0ae178016a Copy PlasmaCore binary qmldir file structure into bin for unit tests
This way tests pass before installation.

Test Plan:
Before patch

Created a broken env by unsetting QML2_IMPORT_PATH
Ran test. It failed

It passes.

Reviewers: #plasma, dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D14743
2018-08-13 22:42:31 +02:00