Commit Graph

13887 Commits

Author SHA1 Message Date
Marco Martin
22796e978d function to adjust a rect to availableScreenRect
Given a geometry, it adjusts it moving it completely inside of the boundaries
of availableScreenRegion, returning the topLeft point of the adjusted
rectangle

reviewed-by: David Edmundson <david@davidedmundson.co.uk>

Change-Id: Ib58cbf521d5def1cd5bb34fe90366d4b628f8a89
CCBUG:345401
CCBUG:345002
2015-03-26 16:50:10 +01:00
Kai Uwe Broulik
4985a4fe65 Immediately hide tooltip on ToolTipArea destruction or when it becomes empty
When the tooltip is empty (no text, no subtext, and no mainItem) it will not be shown.
However, when it becomes empty while it is already shown, it stays there as a small
rectangle. This hides the tooltip immediately (so KWin's fadeout animation still has
the proper content rather than the empty tooltip) when the TooltipArea that opened
the tooltip has been destroyed or its content becomes empty.

CHANGELOG: Fixed stray tooltips when temporary owner of tooltip disappeared or became empty

REVIEW: 122939
2015-03-26 15:23:46 +01:00
Kai Uwe Broulik
b7e4669db2 Layout children in TabBarLayout right away
When Component.onCompleted is emitted, all the static children have been created,
thus we can call the layout function right away.

CHANGELOG: Fix TabBar not properly laid out initially, which could be observed in eg. Kickoff

REVIEW: 123106
2015-03-25 18:18:38 +01:00
Marco Martin
285224a2ea don't risk to mix up frames with different pixelratio
BUG:345155
Change-Id: I0b2384831d755e02b944a49259ffeacd0d2fb71e
2015-03-25 17:06:47 +01:00
Marco Martin
3516c04006 device pixel ratio applied before generating svg
Change-Id: I22bc343894716cbbebabd5c0633889890ce1da9e
CCBUG:345155
2015-03-25 12:07:41 +01:00
Martin Klapetek
8bebf82fbf Update the documentation page with current informations
Change-Id: Iffe77b6ca173b2c09c74b8928a5412d2ce098a85
2015-03-24 15:32:33 +01:00
David Edmundson
bbd328b957 set m_tooltipTextFormat in both constructors
Change-Id: I37971554121f9de1b3b0ca1b6ff1598c727203ed
2015-03-24 12:18:05 +01:00
David Edmundson
ed558bdd5c Fix order and unitiliased variable warnings in appletinterface
Change-Id: I3fab64384f7cd1fb306c85210a4b3e8ec715732f
2015-03-24 12:16:52 +01:00
David Edmundson
4490a3b868 Initialise member varaibles
Change-Id: I174738b6f684b21c65df53db24bd5c1c71976c6a
2015-03-24 12:11:11 +01:00
David Edmundson
d9dd89890a Save a lookup in containmentActions
Also fixes an (arguably invalid) coverity warning

Change-Id: I1eebd475131b540517a7964c4ea9ec057a18c26f
2015-03-24 12:05:21 +01:00
David Edmundson
fa3cd81597 Initialise bool members of iconitem
Change-Id: I289ab2e2676ea27e1add8b0b4548dd6502cc8adc
2015-03-24 11:50:28 +01:00
David Edmundson
e08302f26b Initialise pointer in constructor
Change-Id: I6b195d1998879cbe13b4ab7660f18d6d26f05bbd
2015-03-24 11:48:13 +01:00
David Edmundson
7b355093d0 Initialise members
Not a real issue as initialize() is always called before they're used
but  it's cleaner and fixes a coverity warning.

Change-Id: Ib1168be7f9d72c7d5765850a7f35d524ea279a75
2015-03-24 11:46:03 +01:00
Kai Uwe Broulik
039b808b07 Use Animator for PageStack transitions
This improves animation smoothness, eg. when switching between heavy system tray plasmoids.

CHANGELOG: PageStack transitions now use Animators for smoother animations

REVIEW: 123102
2015-03-22 22:07:05 +01:00
Kai Uwe Broulik
f186b2938f Use Animator for TabGroup transitions
This reduces stuttering when switching between lazyloaded pages

CHANGELOG: TabGroup transitions now use Animators for smoother animations

REVIEW: 123103
2015-03-22 22:06:29 +01:00
David Edmundson
144a58c746 Disconnect connections to d->mainItem when it has changed
This is needed as otherwise we can have a situation where d->mainItem is
null, yet we still have connections to an object that exists causing a
crash if the old mainItem resizes.

BUG: 343963
Change-Id: Ie398a591915fa02d4d97ce7ad5289e3b24038087
2015-03-22 13:55:20 +01:00
Marco Martin
dd46de10ec export correct Layout.minimumWidth
recalculate size when text on a tab changes
BUG:342964

Change-Id: I7fd17557e92de29a7d1b1e897caf17e60bfe101e
2015-03-20 13:45:37 +01:00
Marco Martin
ecbd619566 make PlasmaCore.ColorScope work better as advertised
Since attached properties cannot ever change during the lifetime of the object,
a colorscope needs to be created for each obect that asks for the
attached property. now each instance if (internal) has m_inherit
(only those created as an attached property), will search for the property
of the proper ancestor. Not super efficient, but the proeprties should be
actually asked for rarely enough.

doesn't look much nice, but seems to work pretty reliably and the only way to.

Change-Id: I735da5551dbb8c2641be88d245f998d00ed977ac
REVIEW:122988
2015-03-19 11:20:01 +01:00
l10n daemon script
b7e5392a7b SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2015-03-19 09:50:52 +00:00
Hrvoje Senjan
ca1e2377fb Search for KF5Service in cmake config
It's a public dep, so make sure it's pulled in for p-f consumers

REVIEW: 123034
2015-03-18 21:29:09 +01:00
Marco Martin
fac1100fff make sure to not emit immutabilityChanged at startup
if the immutability doesn't actuall change at startup,
don't emit immutabilityChanged even tough each applet needs
one ImmutableConstraint at start to correctly initialize
stuff

Change-Id: Id1fd40ffd62c09a2b092d13d7fb4c556cfb34994
2015-03-17 19:13:28 +01:00
Marco Martin
117898f4ed don't install notifyrc
the plasmashell notifyrc is unfortunately installed by frameworksintegration

Change-Id: I50aba5bef79150c3d8d92e9c2c94965daabd5e38
2015-03-17 18:30:45 +01:00
l10n daemon script
104f37b8c8 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2015-03-16 10:11:21 +00:00
l10n daemon script
5265842028 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2015-03-14 10:19:38 +00:00
Marco Martin
e754f7bf1a pick the color from colorScope
Change-Id: Iff83658b3d91ffc9ed0f4a9a02db68ade67c82e6
2015-03-13 21:20:39 +01:00
Aleix Pol
644b93830a Don't try to infer sizes when the dialog is not visible
It suggests weird sizes and often resizes dialogs into -1x-1 size.

Reviewed by David Edmundson and Vishesh Handa
2015-03-12 18:00:54 +01:00
David Edmundson
79a30ab7a3 Check for object existing when timer expiers not when starting timer
Otherwise if it gets deleted in the meantime you'll still crash

Change-Id: If6dcf329eb5e43cff3b047f77c240d19427170ff
2015-03-12 17:03:41 +01:00
Marco Martin
01590d8fbc mainItemLayout needed for updateLayoutParameters()
Change-Id: Ic1d53f2dc479b36097b39f550d52e20810e44307
CCBUG:345089
2015-03-12 16:46:41 +01:00
Marco Martin
80d5a6fdda start timer with invokeMethod
rectSaveTimer is used to event compress the save and sync of the
configuration file that is used as a cache of the rectangles of
svg items (in order to avoid svg renderers creation when possible)
there is exactly one situation where it seems to not work: during
creation of svgitems/framesvgitems, insertintorectcache ends up
being called by another thread than the Theme's qobject thread,
and that is not allowed.

with invokeMethod the timer will be started by the correct thread
REVIEW:122915

Change-Id: I3ff4a4ebd1dfdba4b9b830fe6c08feece19b903e
2015-03-12 15:15:45 +01:00
Marco Martin
082ee9aad3 don't show shadow for flat toolbuttons
fixes the look of all themes that actually provide a separed button shadow

Change-Id: I24fde6437e2cdd2949d629ddb53138ace0a883f3
2015-03-12 11:37:33 +01:00
Marco Martin
d3dd3d58e1 Revert "don't check for X11 on OSX"
This reverts commit fd01ee364b.
2015-03-12 10:52:09 +01:00
Marco Martin
fd01ee364b don't check for X11 on OSX
patch by Hanspeter Niederstrasser
BUG:342963

Change-Id: I15e30bfc29cc4e85b912a1e3415f8e499ed11ad0
2015-03-12 10:39:45 +01:00
Marco Martin
bd1d632da0 bring config view to fron if already existing
Change-Id: I47bfed3ee8e327e78e046428abececd90c070df8
2015-03-11 14:39:00 +01:00
Marco Martin
148e0022f6 Make Svg,FrameSvg work qith QT_DEVICE_PIXELRATIO
when QT_DEVICE_PIXELRATIO is something different from 1,
the pixmaps generated by Svg will be scaled up to give a proper texture.

This is complementary but not replacing our current approach:
the pixelratio that can be accessed by units is now in relation to the qt pixel ratio,
spacings are also adjusted accordingly (therefore, spaces and sizes won't
need an integer value like pixelratio)

svg introduces also a scaleFactor property (that is pretty much like its old pixelRatio)
basically, scalefactor, will scale both the textures and all the reported sizes,
(old method) pixelratio just scales textures without altering measures
(like qt pixelratio likes)

Change-Id: I304aa0d80abf76abafac239be185dd3b2ab741b7
REVIEW:122673
2015-03-10 18:02:15 +01:00
Kai Uwe Broulik
c9fd8fc1e5 When changing "active" load pixmap right away
The active property is usualy set in response to a hover event.
Loading the new pixmap right away, starting the fade animation immediately, provides
a more responsive user experience.

REVIEW: 122857
2015-03-08 19:57:25 +01:00
Sebastian Kügler
afc3cf2f34 Use semantically more correct units.largeSpacing
Also saves an evaluation of an expression, so should be slightly faster.

Suggested by Martin Klapetek.

REVIEW:122717
2015-03-05 23:40:25 +01:00
Sebastian Kügler
a2dd646a17 fix tooltip's horizontal sizing
This is Martin Klapetek's version of the fix, it also works nicely on my
machine, and seems otherwise logical.

CCMAIL:mklapetek@kde.org
REVIEW:122717
2015-03-05 23:40:25 +01:00
Martin Klapetek
9a41afb29b Add another tooltip test mimicking the notifications applet
Change-Id: I3900c02c16c8c4c0a98f058e55681ec05006a360
2015-03-05 15:09:29 +01:00
David Edmundson
1ce575cf5a Simple fix for huge icon sizes
Currently units is based on font metrics except icon size and some SVG
parts which use DPI directly.

Instead of taking the physical DPI we take the logical DPI which is used
for working out font point -> pixel sizes.

We can rely on this being correct as otherwise every other app would
appear broken.

REVIEW: 122799
BUG: 338308

Change-Id: I22f668ccea7d6d15ff475e1368c82964bdde1e60
2015-03-04 11:25:59 +01:00
Marco Martin
993301c80b add missing K_EXPORT_PLASMA_APPLET_WITH_JSON
both old and new notation for compatibility:
same as DataEngine

Change-Id: I96af8f2255a94e1c0bc86e55ebb420de721444eb
2015-03-03 16:35:15 +01:00
Eike Hein
e090c77b10 Add a KF6 TODO note. 2015-02-27 19:05:06 +01:00
Eike Hein
6cc17ea25e Add a 'visible' property/role to ConfigCategory/ConfigModel.
This gives users a bit to conditionally hide categories in
combination with a filter model.
2015-02-27 19:00:32 +01:00
Eike Hein
80c32e6d51 Add a 'filterCallback' property to SortFilterModel.
Allows setting a callback function from QML to replace the
default filter implementation.
2015-02-27 19:00:32 +01:00
Martin Klapetek
54899c56ba Make the import 2.1 work
Change-Id: I12b6557a7a0e64dc4d55410da143d3d8d278bc94
Reviewed-by: Marco Martin
2015-02-27 18:37:41 +01:00
l10n daemon script
e44eb9edec SVN_SILENT made messages (.desktop file) 2015-02-27 11:41:25 +00:00
Sebastian Kügler
d285b818f6 Improve tooltip layouting
This patch ports the default tooltip away from custom spacing,
positioning and Row/Column to QtQuick.Layouts. It makes the sizing more
predictable, and the code more modern and readable. Tooltips feel to
behave a bit smoother with this patch.

In the process, this...
- fixes spacing when no icon or image is set
- limits the maximum height of the subtext to 8 lines (this prevents the
  klipper tooltip for example from growing super-high)
- Makes the icon on the LHS proportional to the text
- Limits the width a bit more to prevent super-wide tooltips
- makes it use units.gridUnit throughout

Changelog: Improve tooltip layout
REVIEW:122717
2015-02-26 16:25:52 +01:00
Marco Martin
adfc3a7752 shadow frames with center element
so they can be loaded as a full framesvg too

Change-Id: I7a16da765a530420ad050401a5b8215403b8ace0
2015-02-26 15:44:30 +01:00
Aleix Pol
e9bddef8ee Make it possible to let plasmoids to load scripts outside the plasma package
Adds a X-Plasma-Requires property for the plasmoid metadata files that will
specify the features.
Furthermore, adds a feature called ExternalScripts so that a plasmoid can
request to load files that are outside of the import directories.

REVIEW: 122595
2015-02-25 16:26:23 +01:00
l10n daemon script
f752138302 Upgrade ECM and KF5 version requirements for 5.8.0 release. 2015-02-25 14:23:39 +00:00
David Edmundson
8022adb399 Add icons and images to the tooltip test
Change-Id: Idbcac97bb3e5b8e2349d384c94734a312f177954
2015-02-25 11:24:18 +01:00