Commit Graph

213 Commits

Author SHA1 Message Date
Friedrich W. H. Kossebau
aba253217d Avoid intermediate variable, pass sources directly to ecm_add_test
NO_CHANGELOG
2021-07-06 13:59:02 +02:00
Alexander Lohnau
5dfa851f7b
Allow building the project without deprecations 2021-05-18 06:20:10 +02:00
Laurent Montel
1eb845767d GIT_SILENT: use qt_ macro 2021-05-16 11:47:37 +02:00
Nicolas Fella
e9ef688387 [pluginloader] Deprecate listContainments and listContainmentsOfType
They are based on the deprecated KPluginInfo and unused.
2021-05-06 13:38:39 +02:00
Nicolas Fella
6215355f28 Remove unneeded KIO linkage 2021-04-27 22:07:15 +02:00
Laurent Montel
5bc66ef272 Fix mem leak found by asan 2021-04-25 18:49:22 +00:00
Nicolas Fella
bfa1100523 [pluginloader] Add methods to list containments using KPluginMetaData
To replace the KPluginInfo-based variants
2021-03-29 20:41:37 +02:00
Ahmad Samir
2ff586d513 Tweak formatting after running clang-format
NO_CHANGELOG
2021-03-13 17:35:34 +00:00
Ahmad Samir
c0274df69a Run clang-format on all cpp/h files
NO_CHANGELOG
2021-03-13 17:35:34 +00:00
Ahmad Samir
34a8b79aa7 Use Q_EMIT instead of emit
In C++20 there are new classes that have member functions named emit().
c.f.:
https://lists.qt-project.org/pipermail/development/2020-February/038812.html
https://en.cppreference.com/w/cpp/io/basic_osyncstream/emit

GIT_SILENT
2021-01-18 13:08:40 +02:00
Waqar Ahmed
2864f99dc5 Fix windows build failing due to narrowing cast
NO_CHANGELOG
2021-01-09 13:58:19 +00:00
Friedrich W. H. Kossebau
b8d21595f9 Add missing include to unbreak build on FreeBSD
NO_CHANGELOG
2021-01-08 13:58:05 +01:00
Marco Martin
04c6f61f70 fix autotest
since it was manually generating a cacheid assuming the structure, port
o the new logic
2021-01-07 15:17:13 +00:00
Nicolas Fella
007eacca5b Use KPluginMetaData to list containmentActions
Add a new method that uses KPluginMetaData to list the
containmentActions and deprecate the KPLuginInfo-based one
2020-11-23 12:17:26 +00:00
Nicolas Fella
1a1133006b Use KPluginMetaData to list DataEngines
Avoid using KPluginInfo and KPluginTrader in favor of KPluginMetaData
and KPluginLoader.

Add new method that uses KPluginMetaData

Deprecate old KPluginInfo-based methods.

See also https://phabricator.kde.org/T13889
2020-11-23 12:16:32 +00:00
Laurent Montel
e2c16864c8 If include is define in .h remove it if it's defined in .cpp too (scripted) 2020-10-23 08:39:01 +02:00
Arjen Hiemstra
2f78dfb9d9 Provide a lastModified value in ThemeTest
Since lastModified is now required to be a valid value we should make
sure to test with a proper value as well.
2020-10-01 15:11:19 +00:00
Nicolas Fella
fe7598c6ef Remove commented code 2020-09-30 22:40:04 +02:00
Noah Davis
37a95de3f3 Add missing license headers 2020-09-01 12:53:40 +00:00
Nicolas Fella
107776b239 Drop empty X-KDE-PluginInfo-Depends
The whole concept is almost unused and there's no point in having it there but empty

See also https://phabricator.kde.org/T13553
2020-09-01 02:09:43 +02:00
Volker Krause
3e92503c2a Remove ancient unused ModelTest copy 2020-08-14 15:09:20 +02:00
Andreas Cord-Landwehr
d10afb5d2a plasma-framework: Convert copyright statements to SPDX expressions 2020-08-13 19:08:54 +00:00
Laurent Montel
e45a66139a Use camelcase include. (scripted) 2020-07-08 07:44:43 +02:00
Laurent Montel
48f60533b9 [plasma-framework] make it compiles without foreach
Summary: compile without foreach

Test Plan: autotest ok

Reviewers: dfaure, apol

Reviewed By: dfaure, apol

Subscribers: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19913
2020-04-17 06:47:04 +02:00
Laurent Montel
b387faa935 Port qrand to QRandomGenerator (qrand is deprecated in qt5.15)
Summary: Port to QRandomGenerator

Reviewers: apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D26464
2020-01-07 06:47:10 +01:00
Laurent Montel
29f2171813 GIT_SILENT: remove <QtTest> which includes all of <QtCore> (scripted) 2019-12-14 16:58:05 +01:00
Yuri Chornoivan
052a81f755 Fix minor issues found by EBN and typos 2019-11-10 12:06:10 +02:00
Aleix Pol
ea88d2aa51 Skip test on wayland
Summary: It's using some API that isn't available

Test Plan: Noise gone

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23587
2019-08-30 18:06:45 +02:00
David Edmundson
17d49c0bce Handle colors file in fake plasma theme installer 2019-07-25 00:15:30 +01:00
David Edmundson
08a6a4a7cd Install plasma theme into local XDG_DATA_DIR for icon test
Summary: Relevant code is moved from dialognativetest into a header for sharing

Test Plan: Unit test

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22732
2019-07-24 23:53:39 +01:00
Aleix Pol
72ff860ef0 Fix running the dialognativetest without installing
Reviewed by David Edmundson
2019-07-23 19:38:23 +02:00
David Edmundson
0e14ab6eca Remove deprecated tests
Summary:
Plasma::KPackage is deprecated in favour of KPackage.
There are much better tests there.

Storage is completely unused, no point testing it.

Test Plan: Compiles

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22611
2019-07-21 16:11:37 +02:00
David Faure
89724dbd8c autotests: don't fail if an unrelated window shows up.
Summary:
Running anything else in parallel to this test would make it fail,
because windowAdded() would be emitted with an unrelated window.
If we couldn't find our dialog when the signal is emitted,
just keep waiting for the signal to be emitted again.

Test Plan: ctest -j 8 .

Reviewers: hein, drosca, broulik, davidedmundson, jtamate

Reviewed By: jtamate

Subscribers: jtamate, kde-frameworks-devel, #plasma

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D14724
2019-04-01 09:48:22 +02:00
Laurent Montel
9fc663d9f0 Make it compiles without deprecated method
Summary: compile without deprecated method

Test Plan: all autotest ok

Reviewers: dfaure, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19418
2019-02-28 23:01:43 +01:00
Friedrich W. H. Kossebau
fcfc201c8d Use more https in links (& update a few urls)
GIT_SILENT
2019-01-19 16:36:59 +01:00
Kai Uwe Broulik
38098e96e3 Remove ComponentInstaller
When a dataengine failed to load it would ask PackageKit to install it but it's generally not how we want to distribute
plasmoid infrastructure these days and didn't work.

Differential Revision: https://phabricator.kde.org/D16301
2018-11-19 12:53:31 +01:00
Laurent Montel
cbd5abf787 Remove qt include prefixx 2018-11-06 07:23:52 +01:00
Yuri Chornoivan
72ca2f79e0 Fix minor EBN issues and typos 2018-10-22 21:05:29 +03:00
Kai Uwe Broulik
e92ed94d9d Remove PLASMA_NO_KIO option
It is a remnant of the Plasma Active days and didn't even compile.
This patch only removes those ifdefs, it doesn't fix any issues I found during (e.g. double lookups or the fact
that KRun::autoDelete is the default now)

Differential Revision: https://phabricator.kde.org/D16295
2018-10-18 16:44:27 +02:00
Friedrich W. H. Kossebau
30cbc2dc33 Use more nullptr 2018-07-02 00:16:21 +02:00
Laurent Montel
70a274ad3a Use override 2018-05-23 08:05:40 +02:00
Kai Uwe Broulik
639e8684e3 [Icon Item] Treat sources starting with a slash as local file
We have a special case for sources starting with "file://" but a "/" also represents an absolute path and shouldn't
conflict with icon theme names.
Kicker sets a custom image as local path and then we would end up trying to load it as a QIcon::fromTheme eventually.
This will cause the implicit size of the icon item to stay at its default as we only check a custom implicit size
for a source QImage or an SVG. Moreover, this potentially introduces scaling artefacts.

Differential Revision: https://phabricator.kde.org/D9812
2018-01-15 10:22:18 +01:00
Marco Martin
c318fde313 make packageurlinterceptor as noop as possible
Summary:
minimize file access during url rewrite

we still need it for accessing stuff under code/

Test Plan: plasma still loads, seems to save ~2%

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, ngraham, apol, plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D9124
2017-12-18 13:00:31 +01:00
Montel Laurent
7f0c023d3f Use nullptr + add explicit 2017-12-13 07:36:22 +01:00
Montel Laurent
dfac32f0e4 test return value from QTest::qWaitForWindowExposed 2017-12-06 08:17:42 +01:00
Aleix Pol
b8b8a69fd1 Remove implicit string casting
Summary: Follow the KF5 guidelines

Test Plan: Plasma shell starts

Reviewers: #plasma, #frameworks, sebas

Reviewed By: #plasma, sebas

Subscribers: plasma-devel

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D9108
2017-12-02 15:44:14 +01:00
Montel Laurent
5d9aa6816f We depend against 5.7 2017-11-29 21:10:48 +01:00
Luca Beltrame
cf79873de6 Revert "Don't list KF5::WindowSystem in public libraries"
PlasmaQuick::Dialog::WindowType uses KWindowSystem's API, so removing
it from the list of the public libraries causes compilation issues in
projects that depend on plasma-framework (such as plasma-desktop) which
no longer find KWindowSystem's includes.

This reverts commit f8de13c674.

CCMAIL: kde@davidedmundson.co.uk
2017-07-05 09:18:49 +02:00
David Edmundson
f8de13c674 Don't list KF5::WindowSystem in public libraries
Summary: We don't use it in public API

Reviewers: #plasma

Subscribers: plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D6495
2017-07-04 07:57:08 +01:00
Pino Toscano
0c8cac7849 tests: run i18ndcheck only when bash is found
it's a bash script, so it is pointless to attempt to start it when bash
is not installed
2017-06-06 16:09:25 +02:00