Commit Graph

68 Commits

Author SHA1 Message Date
Marco Martin
a629fe4d8f migrate to KPackage
Plasma::Package internally uses KPackage, being a pure wrapper.
old client code and old packagestructures still work using the wrapper.
old workspace code that is not directly using kpackage continues to work correctly

Change-Id: I05f95e8d05e3b67759973c4009e3753c61b1dcce
2014-12-29 13:56:52 +01:00
Marco Martin
a159208d54 Ensure corona::containments() is ordered
the order in which containments were restored used to be quite random:
ensure that's ordered by id this makes the shell startups be more reproduceable
from one to another, if a new containment arrives, ensure it's inserted
maintaining id order

containment::appelts() will need the same treatment

adds a test as well that checks the order is right

Change-Id: Ie1b278e5b83d7e3645f7293bf6d030aa7f43a221
2014-09-15 17:28:38 +02:00
Marco Martin
052a0c32ae base on screen() to see what containment is loading
if a containment's lastScreen is not -1 (and a valid screen)
*and* its activity() is not the current one, its QML
will *not* be loaded, therefore it would dangle blocking
corona::startupCompleted until the activity is selected

Change-Id: I6757d29240a012377e9ff0a22fe16541ea712ee6
2014-09-15 14:49:18 +02:00
Marco Martin
0b0daa2318 ensure empty containment emit uiReady()
Containments with no applets will emit uiReady now

It adds a test as well that checks if this is the case.

There is still a case where the corona doesn't emit startupCompleted()
that's when there is more than one activity, but that, as well the test
will be adressed by another patch on a different part.

Change-Id: I4d83aa612c29fb0f441d11681bc5aba241370bc3
2014-09-13 12:41:24 +02:00
Marco Martin
546ffbc791 reintroduce containmentForScreen with defaultPlugin
reintroduces an api call from plasma1:
its the only way to solve
https://bugs.kde.org/show_bug.cgi?id=337200
basically to avoid a crash when plasma starts with missing containments in the appletsrc and a locked corona, or a screen added with locked widgets.

it's the only entry point that allows a creation of a containment when widgets are locked
REVIEW:119513
CCBUG:337200
2014-07-28 13:43:23 +02:00
Marco Martin
188d131d77 make the uiloaded tests pass
work in case of every order the various applets and containments emit uiready
REVIEW:119284
2014-07-15 10:16:10 +02:00
Marco Martin
427acdb373 Merge branch 'mart/coronaautotest'
REVIEW:119270
2014-07-14 20:48:31 +02:00
Marco Martin
6666445af5 don't make failed applet block the corona 2014-07-14 14:22:36 +02:00
Aleix Pol
dac1d8f265 Figure out why my plasma wasn't notifying the startup
Make sure AppletPrivate::uiReady is set in applet_p.cpp when we report that
the ui is ready.
Make sure that if we loop through all the containments and they're all
ready, we emit that it's done.

So far, Corona::startupCompleted was never emitted.

REVIEW: 119220
2014-07-14 13:23:20 +02:00
Aleix Pol
459f81814d Only consider a containment as finished if it actually passes a "true".
So far, we were only considering the fact that teh signal was being
emitted, and that's doesn't seem correct.

REVIEW: 119191
2014-07-09 12:51:24 +02:00
Aleix Pol
5e0acaa443 --warning 2014-07-09 12:02:31 +02:00
Aleix Pol
a06c1569a1 The screen size will be defined by the final Corona
It doesn't make sense to try to give hints at what it will be given that
we don't know.
For example, see how we're defining ::numScreens as 1 on the other method
as well.
2014-06-05 01:25:18 +02:00
David Edmundson
e8297e9a0f QDesktopWidget -> QScreen 2014-06-04 18:55:05 +02:00
Marco Martin
f7e25fe696 don't link to xml and iconthemes 2014-05-19 19:09:09 +02:00
Aleix Pol
556c1e321a Remove random qDebug output
Makes it easier to spot the actual problems on the output. If there's
something that's actually indicating a problem, we should make it a
qWarning.
2014-05-06 19:57:37 +02:00
Marco Martin
a6eca11b84 restore corona immutability
BUG:334141
2014-04-30 19:31:56 +02:00
Kevin Ottens
72ba7b4146 Apply the astyle-kdelibs script 2014-04-26 01:48:37 +02:00
Marco Martin
47dfda75c0 introduce the signal Corona::startupCompleted()
when emitted we are sure all containments *graphics objects*
 have been created
2014-04-22 14:58:12 +02:00
Marco Martin
d8731d7806 re-add Corona::createContainmentDelayed()
unfortunate, but necessary for on the fly containment plugin switch
2014-04-09 22:15:46 +02:00
Martin Klapetek
6a1fa18986 Add availableScreenRect(int id) to Corona base class
This is already implemented in ShellCorona and is quite handy too

Reviewed-by: Marco Martin
2014-03-11 15:30:45 +01:00
David Edmundson
f5618db949 Remove unused property drawWallpaper
As suggested here: http://community.kde.org/Plasma/libplasma2/API_Review/Containment
kde-workspace doesn't use it.

REVIEW: 115224
2014-01-30 15:34:45 +01:00
Aleix Pol
d2992acfa7 Fix QObject::connect() warnings
Adapt to changes in Plasma::Corona
2013-12-19 17:31:28 +01:00
David Edmundson
37840b1490 Add default screenForContainment implementation 2013-12-17 15:46:57 +01:00
David Edmundson
a26913ccac Move screen management logic in ShellCorona
Previously shells, activities, shellcorona and corona all tried to
manage
which screen a containment was on.

This version moves all screen management into ShellCorona so we have a
central place for keeping tracking of containments, activities and
screens.
2013-12-16 15:30:13 +01:00
David Edmundson
ef58fdbf6f Remove Applet::Private::isContainment
Instead determine by introspecting if this inherits from Containment

REVIEW: 114405
2013-12-11 15:50:48 +01:00
Marco Martin
60e5a57c23 don't double signal containmentAdded 2013-10-23 22:38:41 +02:00
Martin Klapetek
17e95850fa Use proper default containment name
Fixes the case when loading the default containment would fail because
the default one couldn't be found

Reviewed-by: Sebastian Kügler
2013-10-23 15:25:02 +02:00
Marco Martin
800e5ec91c use the ctivity class and Kactivities
just building, issues with linking with kactivities, not used yet
2013-10-16 21:01:39 +02:00
Marco Martin
de6d0f12d0 Corona::packageChanged() signal
views listen to it to know when to reload theirview qml file
2013-09-02 21:06:35 +02:00
Marco Martin
b32a42c8e8 Corona::setPackage(QString) uses a Package
* symmetrical api in Corona
* there is no default package
2013-09-02 18:04:22 +02:00
Ivan Čukić
f786c74020 Ported the broken branch to a new one 2013-08-31 17:47:29 +02:00
Kevin Ottens
0e590217f8 Port away from kdebug 2013-07-30 08:05:09 +02:00
Sebastian Kügler
946a800a7a Replace QAction with KAction in containment
With this commit, plasma-framework is free from (direct) usage of
KAction. \o/

Removes any left-over KAction includes and fw-declarations.
2013-07-10 01:59:39 +02:00
Sebastian Kügler
af46f93a57 Corona's lock action becomes a QAction 2013-07-10 01:49:59 +02:00
Marco Martin
f22e4be172 fix startupcompleted constraints
use the new panel toolbox
2013-05-16 13:08:05 +02:00
Marco Martin
7761a995f2 rename ImmutabilityType 2013-05-14 20:27:32 +02:00
Marco Martin
812b9a06ab get rid of Plasma::Location 2013-05-14 18:27:27 +02:00
Marco Martin
e07600a83f Put all Plasma emums in a Types class
This makes possible to use them directly frmo QML
as a minus, is not pretty and requires tons of search and replace in old
c++ code
2013-05-10 19:29:13 +02:00
Sebastian Kügler
b1ce94159d KDE::icon becomes QIcon::fromTheme 2013-04-02 12:55:37 +02:00
Stephen Kelly
d8258866f4 Fix build in debug mode.
It seems some plasma API has changed, so I just commented it out. It
can be uncommented by someone who knows what to change it to.
2013-03-16 12:19:54 +01:00
Marco Martin
4219697fcb remove Corona::defaultContainmentActionsPlugins() 2013-03-13 11:32:00 +01:00
Marco Martin
7abd6d81d5 remove s_positioningContainments 2013-03-13 11:32:00 +01:00
Marco Martin
d884d396ec remove offscreenWidgets 2013-03-13 11:32:00 +01:00
Marco Martin
45c55b22b2 remove preferredToolBoxPlugin 2013-03-13 11:32:00 +01:00
Marco Martin
054f443469 remove defaultContainmentPlugin 2013-03-13 11:32:00 +01:00
Marco Martin
9e2240bd8c get shell package from config 2013-03-05 16:44:13 +01:00
Marco Martin
8646393758 shell package partly working 2013-03-05 13:58:18 +01:00
Marco Martin
e49b58c95d remove initializeLayout() 2013-03-04 16:48:17 +01:00
Marco Martin
759780ce3f remove releaseVisualFocus 2013-03-04 16:33:59 +01:00
Marco Martin
55add92bf8 remove actionCollections and shortcut config dlg 2013-03-04 16:28:51 +01:00