alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
13,626 Commits 1 Branch 0 Tags 40 MiB
8044e15a71
Commit Graph

405 Commits

Author SHA1 Message Date
David Edmundson
1f7951d873 Revert "Setting parent on toolbox causes problems. Instead delete via connection" 
This reverts commit c38e6a204e.

This causes problems on the panel toolbox.
We were already trying to set a parent; however as it's a property of a QQuickItem
it only changes the visual parent; kdeclarative has a code path that if there's
a visual parent to skip the memory management; bug is probably there instead.
 2014-07-17 21:08:02 +02:00
David Edmundson
c38e6a204e Setting parent on toolbox causes problems. Instead delete via connection 
Reviewed-by: Eike Hein
 2014-07-17 20:36:02 +02:00
David Edmundson
5e9fc425c6 Do not leak toolbox items 
Finally found the cause of the items QML_LEAK_CHECK warns of.

BUG:336561
REVIEW: 119343
 2014-07-17 18:50:05 +02:00
l10n daemon script
f7208d7d21 SVN_SILENT made messages (.desktop file) 2014-07-17 08:59:54 +00:00
David Edmundson
9b0d414e57 Fix minor memory leak in Wallpaper interface 
REVIEW: 119316
 2014-07-16 15:40:00 +02:00
Marco Martin
c2284cb48e connect(QPoineter breaks on some gcc versions 
please, use connect(QPointer.data(), for time to come
 2014-07-11 10:49:25 +02:00
Aleix Pol
d1e24d19fb fix build on jenkins 
for some reason it works here...
 2014-07-10 20:28:19 +02:00
Aleix Pol
f75eb2d984 Don't connect to signals until the class has been initialized 
While profiling plasmashell memory usage with Vishesh we realized that most
of the usage came from loading the Background image repeatedly.

We traced it back to this change, where we were connecting to
wallpaperChanged before initializing it, so it would initialize it again,
loading the wallpaper twice. It's not that we were leaking the object,
AFAIK, but loading an image using QQuickImage already raises the memory
quite a bit.

This change alone reduces by 15% the memory usage of my plasmashell (with 2
screens, that makes it a bit worse, because there's 2 DesktopViews then).

REVIEW: 119216
 2014-07-10 19:53:03 +02:00
l10n daemon script
8afadc6410 SVN_SILENT made messages (.desktop file) 2014-07-10 04:23:58 +00:00
l10n daemon script
ee230c4d21 SVN_SILENT made messages (.desktop file) 2014-07-09 03:37:24 +00:00
Marco Martin
9218543b65 QCoreApplication::closingDown() becomes true too late 
restore the disconnect: sometimes appletRemovedForward gets executed after
aboutToQuit is emitted, but before closingDown returns true
this prevents configuration to be forgotten
 2014-07-08 12:49:04 +02:00
Marco Martin
a5ecb2e0ff fix a crash sometimes happening on close 
the problem is that sometimes when QCoreApplication::aboutToQuit the containment is already deleted (the order is not really deterministic), therefore appletScript::applet() will hit an assert.
using a qpointer should solve it, its data being already 0ed in the cases the containment is already deleted at :aboutToquit time.
 2014-07-08 11:04:05 +02:00
Marco Martin
0dba9044bf actions() returns the complete list 
the disabled/invisible actions already have it as properties.
this fixes the add widgets action sometimes not being available
in the toolbox
Reviewed by: Bhushan Shah <bhush94@gmail.com>
 2014-07-07 19:36:30 +02:00
l10n daemon script
29908f145a SVN_SILENT made messages (.desktop file) 2014-07-01 12:38:20 +00:00
l10n daemon script
b06bb52100 SVN_SILENT made messages (.desktop file) 2014-06-29 08:42:52 +00:00
Marco Martin
e09a2eb44a check pointer validity, crash-- 
even if that code path shouldn't be hit, always better avoiding a crash
(proper fix coming)
CCBUG:336491
 2014-06-23 14:50:06 +02:00
l10n daemon script
ac4f519188 SVN_SILENT made messages (.desktop file) 2014-06-23 08:35:39 +00:00
Marco Martin
55b5e815b5 ignore inactive containment in containmentAt 
Reviewed by: Bhushan Shah <bhush94@gmail.com>
BUG:336168
 2014-06-20 17:32:36 +02:00
Aleix Pol
97cf403288 Reduce Applet::containment calls 
It's not a cheap call, and there's no need to re-calculate it every time.
 2014-06-17 16:02:43 +02:00
Marco Martin
34226faec1 one occasion less to crash 
(on debug builds an assert is still possible)
 2014-06-17 11:49:23 +02:00
l10n daemon script
b092bbed31 SVN_SILENT made messages (.desktop file) 2014-06-12 08:31:04 +00:00
Aleix Pol
8ab91f219d Expose the screenGeometry on the applet interface 
It's useful to be able to figure out information about the current screen
without having to ask the corona.
 2014-06-05 15:24:26 +02:00
Marco Martin
9d1727a1a4 Plasma1 behavior: no remove action in panels 
the remove context menu for applets is only visible when the panel controller is open
less accidental removal
 2014-06-03 16:35:01 +02:00
Marco Martin
223fe9b431 stop forwarding appletRemoved on application close 
the containment must not save geometries without the applets that are being deleted

BUG:335742
 2014-06-03 11:59:57 +02:00
l10n daemon script
9e45440ae7 SVN_SILENT made messages (.desktop file) 2014-05-29 08:11:19 +00:00
l10n daemon script
fd1674450e SVN_SILENT made messages (.desktop file) 2014-05-25 08:47:48 +00:00
l10n daemon script
2ba1a0c90f SVN_SILENT made messages (.desktop file) 2014-05-23 08:16:11 +00:00
l10n daemon script
db8da9ff8d SVN_SILENT made messages (.desktop file) 2014-05-20 10:48:03 +00:00
Aleix Pol
35d1dd2d65 Don't try to delete null objects 
Fixes a warning in Qt and makes sense of what the code it's actually doing.
At least it was not crashing!
 2014-05-16 03:08:11 +02:00
l10n daemon script
1b3060649c SVN_SILENT made messages (.desktop file) 2014-05-14 08:29:33 +00:00
Aleix Pol
da190fa711 Reduce calls to ShellCorona::screenForContainment 
Just store some values instead of calling repeatedly without reason.
 2014-05-13 14:15:46 +02:00
Aleix Pol
cc661dfdd6 Save some calls to ShellCorona::screenGeometry 
It's not an especially cheap function and it didn't make sense doing
it twice
 2014-05-13 14:03:46 +02:00
Marco Martin
3f516ddda6 adapt api change 2014-05-13 13:45:32 +02:00
Marco Martin
34b86471d0 fix screen region mapping 
BUG:334670
 2014-05-13 13:42:44 +02:00
Marco Martin
55514d28c7 Merge branch 'mart/plasmoidMove' 2014-05-13 12:47:49 +02:00
Marco Martin
64cff59a31 api to add an existing applet and position mapping 2014-05-13 12:46:17 +02:00
Marco Martin
cdb9c8c1cc addApplet function 
offers a crude support to applet migration between containments
 2014-05-12 21:07:41 +02:00
Marco Martin
895c5b6b2b close the menu if it was already open 
sometimes on plasma start, other context events may be triggered
while the menu is in its exec(), byt the qqmlincubator.
if so, close the already existing menu.

BUG:334562
 2014-05-12 11:02:56 +02:00
Marco Martin
97831b616f experim API to move plamoids between containments 2014-05-09 18:43:33 +02:00
Marco Martin
759036e19f remove dead code 2014-05-09 14:24:05 +02:00
Marco Martin
ea3544deb7 remove unused function 2014-05-09 14:21:23 +02:00
Marco Martin
53893e8d0b make the toolbox directly child of containmentinterface 2014-05-07 20:27:51 +02:00
Marco Martin
f21851548c new api for availablescreensize/region 2014-05-07 15:18:21 +02:00
Eike Hein
1805bb7496 Make sure the args part of Containment::createApplet(..., args) ends up in the applet. 2014-05-06 20:52:42 +02:00
Aleix Pol
556c1e321a Remove random qDebug output 
Makes it easier to spot the actual problems on the output. If there's
something that's actually indicating a problem, we should make it a
qWarning.
 2014-05-06 19:57:37 +02:00
Marco Martin
ac963b8a27 emit externalData only after the ui is here 2014-05-06 19:28:44 +02:00
Marco Martin
a7928f29dd if there are args, emit externalData 2014-05-06 19:06:31 +02:00
l10n daemon script
5713f72542 SVN_SILENT made messages (.desktop file) 2014-05-03 08:34:24 +00:00
l10n daemon script
d55335d2a9 SVN_SILENT made messages (.desktop file) 2014-05-02 08:52:44 +00:00
Marco Martin
4851be6e1e don't crash if destroy happens before first sync 2014-04-29 18:21:28 +02:00
l10n daemon script
238bc54c5b SVN_SILENT made messages (.desktop file) 2014-04-29 10:13:52 +00:00
l10n daemon script
012b0681c9 SVN_SILENT made messages (.desktop file) 2014-04-29 04:51:45 +00:00
l10n daemon script
d2f752597f SVN_SILENT made messages (.desktop file) 2014-04-28 15:59:04 +00:00
Aleix Pol
94dc5c30c9 Remove unneeded statements 2014-04-28 17:18:11 +02:00
l10n daemon script
8fcd320f27 SVN_SILENT made messages (.desktop file) 2014-04-28 12:45:07 +00:00
l10n daemon script
b9130c7c24 SVN_SILENT made messages (.desktop file) 2014-04-28 09:02:00 +00:00
l10n daemon script
880da9b195 SVN_SILENT made messages (.desktop file) 2014-04-28 05:09:56 +00:00
l10n daemon script
dfd425ae82 SVN_SILENT made messages (.desktop file) 2014-04-27 21:04:10 +00:00
l10n daemon script
cbf1e988e9 SVN_SILENT made messages (.desktop file) 2014-04-27 16:44:26 +00:00
Aleix Pol
e6f1fec0c7 Install all plasma files in a prefix/share/plasma directory 
At the moment, we could say that plasma is co-installable by chance,
it's only working because KF5 dropped the apps relative directory.
This change introduces a PLASMA_RELATIVE_DATA_INSTALL_DIR that will
be available to know where in share the components are and
PLASMA_DATA_INSTALL_DIR to know where data has to be installed to.

Reviewed by David Edmundson

CCMAIL: plasma-devel@kde.org
 2014-04-27 17:14:22 +02:00
l10n daemon script
d149d719a9 SVN_SILENT made messages (.desktop file) 2014-04-27 05:19:59 +00:00
David Edmundson
4ce14a1654 Remove duplicated ConfigLoader 
This moved to KConfigGui as KConfigLoader.

Use of private KConfig API in Service had to be ported to use only
public method.

REVIEW: 117784
 2014-04-26 17:10:13 +02:00
Kevin Ottens
72ba7b4146 Apply the astyle-kdelibs script 2014-04-26 01:48:37 +02:00
Aurélien Gâteau
fcbb057dca Disable Python script engine for now, it requires bindings for libplasma 
Approved by notmart
 2014-04-25 21:18:07 +02:00
Aurélien Gâteau
0efc0572af Consolidate all plasma-framework catalogs 2014-04-25 10:40:12 +02:00
Davide Bettio
e1a2555278
QML appletinterface: add support for actionTrigered(name) method so we don't have to create an action_name method for each contextmenu action. 
Signed-off-by: Davide Bettio <bettio@kde.org>
 2014-04-22 20:08:20 +02:00
Marco Martin
1d5c6e5964 revert 0b4272fa56 2014-04-22 15:32:20 +02:00
Marco Martin
0b4272fa56 guard the pointer 2014-04-22 15:15:40 +02:00
l10n daemon script
16ea0c68f6 SVN_SILENT made messages (.desktop file) 2014-04-19 04:52:27 +00:00
l10n daemon script
709d60a737 SVN_SILENT made messages (.desktop file) 2014-04-18 05:16:48 +00:00
Marco Martin
18f54dff73 make possible for containments to run as applets 
take into account the slightly different behaviour needed when containments such as folderview act as a normal plasmoid
BUG:333320
 2014-04-14 14:03:49 +02:00
Aleix Pol
0e3978e22c Expose the activated signal into the plasmoid 
This was a regression from Plasma 1.

Reviewed by David Edmundson
 2014-04-12 21:21:35 +02:00
Marco Martin
d8731d7806 re-add Corona::createContainmentDelayed() 
unfortunate, but necessary for on the fly containment plugin switch
 2014-04-09 22:15:46 +02:00
Marco Martin
aeabbe9444 new AppletInterface in case of inexistent plugin 
if the plugin name is wrong, create a fullfledged appletinterface for the error visualization.
This will make applet removal possible
BUG:332971
 2014-04-02 18:59:47 +02:00
Marco Martin
c4e6f06f42 expose the plugin name 2014-03-25 15:13:22 +01:00
Marco Martin
900e0108e1 if no position was provided, negative pos 
call the qml part with an invalid position if not supplied, will make new applets in the panels being put in the end instead of at the beginning
 2014-03-24 18:15:50 +01:00
l10n daemon script
99900255bf SVN_SILENT made messages (.desktop file) 2014-03-23 04:47:33 +00:00
Marco Martin
69cac03a64 the icon is now called org.kde.plasma.icon 2014-03-21 17:33:26 +01:00
Aleix Pol
a3641aac25 Fix headers management in plasma-framework 
Use generate headers instead of having them stored in the repository.
Figure out how relative paths are forwarded around, there were some weird
things.
Stop installing plasma header files in the KDE/ prefix.
 2014-03-17 16:28:24 +01:00
Martin Klapetek
62d35541ed Add availableScreenRect(int id) to ContainmentInterface 
Now plasmoids can simply get the available screen rect
 2014-03-11 15:30:45 +01:00
David Edmundson
effb5e8ad1 Add temp workaround to avoid black squares in main context menu 
BUG: 331809
 2014-03-10 17:50:50 +01:00
David Edmundson
fb7451051e Expose globalShortcut in AppletInterface so it can be set from the config 2014-03-05 17:28:50 +01:00
Marco Martin
ccd8f8494d workaround a crash in qt during drop events 
delay adding an applet with a queued connection.
this should be reverted once this is fixed:
https://bugreports.qt-project.org/browse/QTBUG-35702
 2014-02-27 17:39:42 +01:00
Marco Martin
a7c6d3a79e Merge branch 'mart/plasmaquickNamespace' 2014-02-20 12:36:44 +01:00
Marco Martin
aaf7fa328d export plugin name 
not super nice but the simplest way to avoid code duplication in the image plugin
 2014-02-20 12:33:31 +01:00
Marco Martin
90c608f863 complete porting 2014-02-19 20:00:29 +01:00
Martin Klapetek
d3d7a6fd63 Return early if we failed to load valid Wallpaper package 
Reviewed-by: Marco Martin
 2014-02-19 13:28:15 +01:00
l10n daemon script
592a0db2ab SVN_SILENT made messages (.desktop file) 2014-02-18 05:13:41 +00:00
Michael Palimaka
c9c4e6c3b2 Remove unused system dependencies. 
- plasma_appletscript_declarative includes QtUiTools but doesn't use it
- QtPrintSupport is not used anywhere
- Xss, Xext, and SM are not used anywhere
- OpenSSL is not used anywhere

REVIEW: 115830
 2014-02-18 03:12:12 +11:00
Marco Martin
7e8aa867b0 crash-- 
wait for the ui to be ready before connecting activated() to the expanding
 2014-02-14 17:25:59 +01:00
Marco Martin
50a584d0bc rename Applet::activate() with Applet::activated() 
activate() is a name that suggests a slot more than a signal
 2014-02-14 14:40:53 +01:00
Marco Martin
54549d8312 set the applet as expanded on activate signal 2014-02-14 14:26:53 +01:00
Aleix Pol
18473c9e9e Remove KRunner from Plasma-Framework 
Have it as a separate KRunner framework instead
 2014-02-11 18:03:06 +01:00
Marco Martin
da36ebe0e4 remove unused signal 2014-02-11 13:31:44 +01:00
Marco Martin
6f256aa7e6 remove the legacy config machinery 2014-02-11 13:29:37 +01:00
Marco Martin
808eca4182 use QStringLiteral instead 2014-02-10 16:38:15 +01:00
Marco Martin
87730146db and make the previous one actually work 2014-02-10 16:23:13 +01:00
Marco Martin
e30a50f755 null string:fallback empty string: empty 2014-02-10 16:18:13 +01:00
David Faure
e76d11be9d Port to updated KActivities 2014-02-08 18:48:40 +01:00
David Edmundson
fb0728d40a Ammend last commit 2014-02-07 19:37:06 +01:00