Commit Graph

82 Commits

Author SHA1 Message Date
Marco Martin
1da58c95f4 make paint(painter,pos,elementid) work when containsMultipleImages =
true

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=878053
2008-10-31 09:43:51 +00:00
Aaron J. Seigo
f1accd0eba ok, don't need this shouting all the time anymore
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872725
2008-10-17 23:41:13 +00:00
Marco Martin
027957f2e5 look ma, no FAILs!
use the suffix normal for natural for sizes in the cache, makes not
nevessary the svg size to be initialized

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872706
2008-10-17 21:27:32 +00:00
Davide Bettio
69155230cd Added a new useful overload.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872636
2008-10-17 17:45:18 +00:00
Aaron J. Seigo
51e053e529 so people can see when we FAIL and hit up an svg.
the goal is to see *zero* FAILs on a second run

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872383
2008-10-17 05:17:46 +00:00
Aaron J. Seigo
573306a3af ok, that was a stupid error. =)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872366
2008-10-17 02:52:51 +00:00
Aaron J. Seigo
de112e34fe * remove some (apparently accidently) duplicated code
* add the size of the element we are looking for to the cache, so multiple sizes of the same svg don't result in reading the renderer
* if found, then don't go and re-check it even if the rect is invalid

this commit introduces some breakage since it actually relies on the cache properly now, it's apparent that there are some caching issues and we're getting incorrect values in/out =)

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872363
2008-10-17 02:30:08 +00:00
Marco Martin
ed626e5869 ahem, there was a missing !
:)

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872290
2008-10-16 20:04:51 +00:00
Marco Martin
089fb6ea94 cache on disk rects of elements and the not-existence of them
should avoid some calls of createRenderer() the second time it's queried

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872250
2008-10-16 18:25:20 +00:00
Aaron J. Seigo
6374635bf3 on disk pixmap cache, and use it agressively for svg's. first step towards "no svg parsing on second run"!
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=871870
2008-10-15 20:55:07 +00:00
Allen Winter
c4573eae9a use QString::clear() to clear a QString instead of assigning QString().
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870305
2008-10-12 11:05:42 +00:00
Allen Winter
214ac5f91f clean up some kDebugs and kWarnings.
shorten some extra long lines.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870290
2008-10-12 10:20:02 +00:00
Allen Winter
a7aebfa60a a bunch more coding style fixes. still some lines longer than 100 chars.
this is definitely helping me find false positives in the Krazy style checker.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870161
2008-10-11 22:48:38 +00:00
Allen Winter
e88e2faa63 first batch of small coding style fixes.
these were found while testing the Krazy style checker, which I'm adapting
for the kdelibs style.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870051
2008-10-11 16:19:04 +00:00
Andrew Lake
9b312459be renderers hash table keys created with path but erased with themePath.
Corrects memory leak on theme change.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=867965
2008-10-05 04:47:25 +00:00
Marco Martin
94b4c8cfa7 pixmap() works also with containsMultipleImages
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=863958
2008-09-23 15:52:45 +00:00
Aaron J. Seigo
e99497b67f * Svg::pixmap
* ++apidox
* clean up SvgPrivate::findInCache a bit

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=862695
2008-09-19 16:41:39 +00:00
Sebastian Kügler
482c6a9f01 warnings--
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=862051
2008-09-17 22:38:05 +00:00
Marijn Kruisselbrink
21b148b963 change all ClassName::Private classes to ClassNamePrivate, and adjust friends accordingly; this makes plasma compilable with gcc < 4.2
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=826893
2008-07-01 18:56:43 +00:00
Marco Martin
b79b52624e when no element id is specified paint the svg with its own size
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=822139
2008-06-19 10:15:09 +00:00
Andrew Lake
e729dcd481 Fix broken theme change from theme svgs that do not use "hint-apply-colors" to theme svgs
that do.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=816504
2008-06-04 02:51:31 +00:00
Marco Martin
94517b3f87 a little more deterministic behaviour: Svg::elementSize(elementId)
returns 0,0 for not existing elements: this fixes also some of the panel
funny behaviour

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=803651
2008-05-03 17:30:37 +00:00
Jeff Mitchell
ee70465d89 Safety...if createRenderer was never called this will still be zero
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=803406
2008-05-02 19:22:07 +00:00
Robert Knight
ebdd9d4f99 Fix uninitialized variable.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801838
2008-04-27 21:49:09 +00:00
Aaron J. Seigo
0187b08069 one more place we might want to trigger a repaint
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800766
2008-04-24 20:12:24 +00:00
Aaron J. Seigo
d28a4c277a consolidate color and font methods into one method for each with a role enumeration
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800334
2008-04-23 22:36:00 +00:00
Anne-Marie Mahfouf
970e72245c API review
more SIGNAL changed() -> themeChanged()
thanks Alexis for your vigilance!

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800244
2008-04-23 18:35:03 +00:00
Marco Martin
d0ba4e77ec Api change:
Plasma::Svg(imagePath, parent) -> Plasma::Svg(parent)  and
Plasma::PanelSvg(imagePath, parent) -> Plasma::PanelSvg(parent)
updated as needed every class that was using Svg or PanelSvg

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800143
2008-04-23 13:07:41 +00:00
Anne-Marie Mahfouf
36bc2c4e97 Plasma::Theme::self() -> Plasma::Theme::defaultTheme() as planned during the sprint
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=799919
2008-04-22 21:10:14 +00:00
Aaron J. Seigo
868a4107a3 move getting the size for the subelement first before creating the cache id.
also remove all the SVG_CACHE_BUGFIX. it wasn't getting used and was making the code a lot uglier.

if someone wants to attempt to have the cache store transform-neutral renderings, they can have another crack it and do it so that ifdef's aren't necessary.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=799600
2008-04-21 23:00:58 +00:00
Aaron J. Seigo
92a2bb701e avoid painting empty pixmaps.
BUG:161122

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=799536
2008-04-21 19:32:26 +00:00
Marco Martin
419277a044 finished the Plasma::Svg api change
ContentType now is simply a bool and related methods now are
containsMultipleImages() and setContainsMultipleImages()

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=797998
2008-04-17 09:09:48 +00:00
Marco Martin
f522c38eeb file() and setFile() -> imagePath() and setImagePath()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=797772
2008-04-16 20:48:53 +00:00
Marco Martin
b08e8ae782 themeChanged() and colorsChanged() now are Q_PRIVATE_SLOTS
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=797745
2008-04-16 20:30:18 +00:00
Marco Martin
d07a60c581 Rename SvnPanel into PanelSvg and update accordingly who is using that,
as discussed in api reviews

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=797663
2008-04-16 17:23:58 +00:00
Dmitry Suzdalev
b237019d4f Plasma API adjustements:
Theme::colors() => Theme::colorScheme()
Theme::image() => Theme::imagePath()

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=797634
2008-04-16 15:53:16 +00:00
Marco Martin
4a5df9c733 begin of api changes, as in
http://techbase.kde.org/index.php?title=Projects/Plasma/Tokamak1#Plasma::Svg
elementRect() returns a QRectF
elementExisits() became hasElement()
matrixForElement is only private


svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=797610
2008-04-16 14:31:43 +00:00
Davide Bettio
4e6e78cb04 Now everything works but I don't really know the why.
Please, *check* this code.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=796915
2008-04-14 14:41:41 +00:00
Davide Bettio
90999c00d6 Fixed findInCache bug. Now findInCache is faster, thanks to bibr.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=796500
2008-04-13 17:27:02 +00:00
Andrew Lake
e8772b73d8 Change colorize from 0.9 to 1.0. No reason it should have been 0.9 in the
first place. Plus it fixes slight differences in intesity levels between 
system color-aware plasma themes and the currently selected style.

It was a very minor change so I just went ahead and committed. I don't 
anticipate any objections, but if there are please revert with my apologies. 
CCMAIL: panel-devel@kde.org

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=789757
2008-03-25 05:50:13 +00:00
Aaron J. Seigo
ac2b7ba7a5 colourization support for svgs. patch by Andrew Lake.
CCMAIL:jamboarder@yahoo.com

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=777967
2008-02-22 01:05:11 +00:00
Aaron J. Seigo
2e07ca5f64 remove all the cached pixmaps when the cache is cleared.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=776939
2008-02-19 04:28:17 +00:00
Aaron J. Seigo
ce3e58d2b4 be a lot more careful with how we react to theme changes. makes it innexpensive enough to call a bit more randomly (e.g. when compositing changes)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=771873
2008-02-07 04:33:57 +00:00
Aaron J. Seigo
20c5ddf8e7 return the right path for file()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=771450
2008-02-06 01:26:18 +00:00
Aaron J. Seigo
ddadcc6765 SVN_SILENT: whitespace fix; committing to get it off my hd
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=764592
2008-01-22 04:34:49 +00:00
Aaron J. Seigo
ee32d3c996 remove the use of 1209 explicitly now that i have Winter's Magic Formula for default debug space. makes backporting way easier; sorry for the noise of the earlier commit. suppose i should read planetkde.org more closely ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=758498
2008-01-08 01:25:09 +00:00
Aaron J. Seigo
12ef6308cb use the plasma debug area (1209); i considered wrapping this in Plasma::debug() but that seems overkill ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=758415
2008-01-07 20:50:31 +00:00
Aaron J. Seigo
b03a2588d2 make setFile actually work
CCMAIL:notmart@gmail.com

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=758400
2008-01-07 20:20:02 +00:00
Shawn Starr
5e77ba9e70 Add some convenience methods file(), to get the svg image path and setFile, to set the image path
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=750651
2007-12-19 20:29:22 +00:00
Aaron J. Seigo
997f9e75a8 allow moving on any part of the applet surface; it seems our widgets still work just fine with this which is pretty cool; in this case i like the event model for QGV =)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=738454
2007-11-18 23:03:57 +00:00