and eventually other things
this in the future should become something that can change dynamically in theme, but for now can already avoid quite some code duplication
When contentHeight and contentY change at the same time, we got to
some weird states where the scrollbar would trigger a change in the
Flickable positioning that wasn't triggered by the user, this should
be fixed now.
Also don't use the handle position to move the Flickable scrolling
if the scrollbar is disabled or non-interactive. It shouldn't be needed
now but it helps keeping the complexity to a minimum.
REVIEW: 105808
When the widgets use the button background frame, use buttonTextColor.
When they do not use any background frame, use textColor.
Avoids unreadable text with Oxygen
REVIEW: 105163
Plasma::LineEdit uses the button text color for its text. Do the same
in PlasmaComponents.TextField to avoid white text on white background with
Oxygen theme.
Also use button text color for PC.TextArea because it uses the same
background frame as PC.TextField (P.TextEdit, its C++ equivalent, does not
have any background frame)
REVIEW: 105159
It seems that there's not a single theme out there which properly sets
viewTextColor. The background of textedits is white, so the text has to
be black. On Air(-mobile) this is not a problem, since the text is black
anyway, on dark themes (which set the text color to white), text simply
isn't visible.
We'll have to look into how themes implement viewtextcolor, should
probably fix the themes instead of the components, but this makes it
work until we do.
Otherwise a client wanting to give another QML component the focus in
reaction to a clicked button has no chance doing so because the button
will steal the focus again right after the event handler has finished
executing.
REVIEW: 104893
- Improve spacing between icon and text
- Do not enforce a minimum width
Having a minimum width does not make much sense for a ToolButton:
1. It should aim at using the minimum amount of horizontal space when
used in a ToolBar.
2. It looks unbalanced when used with an icon because the content is
flushed to the left, leaving a large amount of white-space on the right.
REVIEW: 104735
