Commit Graph

2420 Commits

Author SHA1 Message Date
Marco Martin
8c285fdee5 don't allow to drag applets registered as drag handle when the
containment is locked
BUG: 162584

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812459
2008-05-25 14:10:47 +00:00
Kevin Ottens
8edc0b399f Remove the "ghost view" from public API. It's completely internal and
used nowhere.

"ervin, fighting feature creep in APIs since 1980."

(BTW, at this rate I'm less and less convinced that it'd be wise to not
have a second round of API review post 4.1)

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812172
2008-05-24 18:33:40 +00:00
Kevin Ottens
402a4ed8b2 Don't use the same name for this slot than in Applet. Otherwise, the
wrong slot will get called when you remove an applet which also happens
to be a containment (like the analog clock for instance)...
In such a case we were simply leaking the applet, and it was still in
the layout.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812153
2008-05-24 17:13:19 +00:00
Marco Martin
fb80af2962 update applet margins when the theme changes
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812116
2008-05-24 15:58:40 +00:00
Marco Martin
d01cb72c4d update the svg painting and margins calculations when the theme changes
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812089
2008-05-24 15:33:35 +00:00
Riccardo Iaconelli
a2fb80dd0e Safety++
Just to be sure, dear Bernhard, please double check that this does really fix the crash for you. =)

BUG: 162436

Signed-off-by: Riccardo Iaconelli <riccardo@kde.org>

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812085
2008-05-24 15:24:30 +00:00
Kevin Ottens
c3b5446a59 Since we're randomly changing public API, let's be consistent with Qt
instead. Use ToolBox everywhere, also for internals.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812019
2008-05-24 12:25:56 +00:00
Aaron J. Seigo
bea0906806 finish yet another 4.1 feature gap: allow the user to select what to do on drop. the text is a bit lame for icon, it should be "link to file" or something similar but that string doesn't seem to be handy and we're in a string freeze =/ at least it works =)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811949
2008-05-24 07:47:20 +00:00
Aaron J. Seigo
e32ed254f1 SVN_SILENT: shh
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811947
2008-05-24 07:33:33 +00:00
Chani Armitage
e5230a3f3e stop calling it ToolBox - it's Toolbox, and the capitalization inconsistency is driving me nuts :)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811934
2008-05-24 06:34:08 +00:00
Aaron J. Seigo
9f4246059e when changing the prefix, let's base it on the previous size.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811927
2008-05-24 05:29:42 +00:00
Chani Armitage
88260fabd2 'add activity' action returns
I just realised it was never disabled when plasma is locked, though. haven't yet decided what to do about that.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811919
2008-05-24 04:34:27 +00:00
Chani Armitage
3dcf445db4 convert the toolbox to use qactions. this makes the toolbox act a bit more reliably, makes some other bugs more annoying, and makes it easier to fix them.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811914
2008-05-24 01:48:36 +00:00
Aaron J. Seigo
ec0c7486b7 move the checkerboard painting to DesktopView. now when we drag things around in top levels we don't see odd checkerboards =)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811898
2008-05-23 23:35:39 +00:00
Aaron J. Seigo
590b3cebd8 add initializeLayout and separate the start up stuff from loadLayout into it so that we can properly load add on layouts
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811892
2008-05-23 23:12:05 +00:00
Rob Scheepmaker
e9989989c5 Check if containment() actually returns a containment, and if view() actually returns a
view. Should fix a crash reported by chani.


svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811785
2008-05-23 17:21:14 +00:00
Aaron J. Seigo
e97bd8e855 clearer apidox
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811688
2008-05-23 15:43:49 +00:00
Thiago Macieira
f6e555fdbc Initialise variable.
Valgrind rationale:
==18955== Conditional jump or move depends on uninitialised value(s)
==18955==    at 0x40E2295: Plasma::Applet::paint(QPainter*, QStyleOptionGraphicsItem const*, QWidget*) (applet.cpp:765)
==18955==    by 0x65259FF: _ZL12_q_paintItemP13QGraphicsItemP8QPainterPK24QStyleOptionGraphicsItemP7QWidgetb (qgraphicsscene.cpp:3766)
==18955==    by 0x6525AE3: QGraphicsScenePrivate::drawItemHelper(QGraphicsItem*, QPainter*, QStyleOptionGraphicsItem const*, QWidget*) (qgraphicsscene.cpp:3790)
==18955==    by 0x652B61E: QGraphicsScene::drawItems(QPainter*, int, QGraphicsItem**, QStyleOptionGraphicsItem const*, QWidget*) (qgraphicsscene.cpp:4015)
==18955==    by 0x6541637: QGraphicsView::drawItems(QPainter*, int, QGraphicsItem**, QStyleOptionGraphicsItem const*) (qgraphicsview.cpp:3294)
==18955==    by 0x6546C08: QGraphicsView::paintEvent(QPaintEvent*) (qgraphicsview.cpp:3042)
==18955==    by 0x5EDD149: QWidget::event(QEvent*) (qwidget.cpp:7082)
==18955==    by 0x62D12B1: QFrame::event(QEvent*) (qframe.cpp:627)
==18955==    by 0x63804C8: QAbstractScrollArea::viewportEvent(QEvent*) (qabstractscrollarea.cpp:914)
==18955==    by 0x6544410: QGraphicsView::viewportEvent(QEvent*) (qgraphicsview.cpp:2299)
==18955==    by 0x6383611: QAbstractScrollAreaPrivate::viewportEvent(QEvent*) (qabstractscrollarea_p.h:72)
==18955==    by 0x638363F: QAbstractScrollAreaFilter::eventFilter(QObject*, QEvent*) (qabstractscrollarea_p.h:83)

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811619
2008-05-23 14:41:55 +00:00
Aaron J. Seigo
58f283c58c needs to be public so custom coronas can get at it as needed
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811413
2008-05-22 22:59:35 +00:00
Marco Martin
bc1688ae41 when the view is not zoomed move the toolbox to avoid the panels
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811374
2008-05-22 20:22:28 +00:00
Aaron J. Seigo
1ff027988b be more lenient with the requirement for a service
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811335
2008-05-22 18:43:34 +00:00
Aaron J. Seigo
26f7e83a53 give proper control over saving/restoring to the containment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811211
2008-05-22 15:53:48 +00:00
Marco Martin
73c4847a75 remove an unused variable
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811184
2008-05-22 14:34:30 +00:00
Chani Armitage
7f822e8c8c SVN_SILENT: better comment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811016
2008-05-22 02:23:33 +00:00
Aaron J. Seigo
3f3b74e48b these two slots were swapped around, making for a lot more GUI updates than intended
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811013
2008-05-22 01:13:50 +00:00
Gilles Chauvin
937c17caae SVN_SILENT: Remove useless semicolons
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810938
2008-05-21 21:49:14 +00:00
Chani Armitage
81985d2b00 clicking an available desktop containment sets the view to that containment
now it's much easier to jump to the activity you want :)

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810614
2008-05-21 06:16:45 +00:00
Aaron J. Seigo
6b756dc236 last resort sort: alpha!
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810606
2008-05-21 05:18:30 +00:00
Aaron J. Seigo
a02a089e67 fix math in here; the other types are also going to be wrong, but i haven't fixed those yet
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810605
2008-05-21 05:12:40 +00:00
Chani Armitage
30dd547919 SVN_SILENT: really minor style cleanup.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810602
2008-05-21 04:37:10 +00:00
Alex Merry
9178353bb4 Fix inclusion guards for future widgets.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810532
2008-05-20 22:36:28 +00:00
Marco Martin
4c36d280c9 (hopefully) fixing the positioning of the desktop toolbox
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810501
2008-05-20 21:29:31 +00:00
Richard Dale
c3aa6bec48 * Fix the broken guard macros in the widget* headers
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810412
2008-05-20 17:29:23 +00:00
Pino Toscano
158a9ca5c0 fix path
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810272
2008-05-20 11:09:42 +00:00
Laurent Montel
47183f095f SVN_SILENT:
Typo

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810151
2008-05-20 06:24:52 +00:00
Chani Armitage
18a50b787d only do containment-style removal if it's *really* a containment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810132
2008-05-20 04:26:10 +00:00
Chani Armitage
ccde7ded20 replace Panel::remove() with Containment::destroy()
now I can remove some of the ten desktop containments I accumulated :)
oh, and the code is cleaner too, yay!

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810129
2008-05-20 04:02:36 +00:00
Aaron J. Seigo
fdef4627ab improved sorting
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810114
2008-05-20 02:47:13 +00:00
Chani Armitage
4f31401ca9 *basic keyboard shortcuts for desktop-containment-switching
*setContainment went virtual so that switches can be done reliably

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810098
2008-05-20 01:27:49 +00:00
Aaron J. Seigo
c413c02ca7 export these files too
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810070
2008-05-19 23:25:56 +00:00
Aaron J. Seigo
03552da98a put includes out of Widgets, so you can just do Plasma/Label, e.g.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810063
2008-05-19 23:22:02 +00:00
Aaron J. Seigo
9abfe2e1d0 export the classes
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810061
2008-05-19 23:17:44 +00:00
Pino Toscano
60f253cad5 fix path to the real include
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810057
2008-05-19 23:08:38 +00:00
Marco Martin
573f99e978 hides the panel toolbox when the whole desktop is locked
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809993
2008-05-19 20:49:44 +00:00
Chani Armitage
f6d290849f add groupbox
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809979
2008-05-19 20:18:46 +00:00
Aaron J. Seigo
a3d432d16d fix deadlock
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809963
2008-05-19 19:58:06 +00:00
Marco Martin
812d870086 enforce square aspect ratio when aspectRatioMode() is square of applets
in the panel

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809947
2008-05-19 19:34:13 +00:00
Alexis Ménard
5f6b242127 This magic line seems to fix our crash with embeeded widget
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809939
2008-05-19 19:19:47 +00:00
Chani Armitage
50889239d6 add combobox
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809932
2008-05-19 19:10:58 +00:00
Chani Armitage
ec2bcd9010 add textedit
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809903
2008-05-19 18:17:12 +00:00