alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
14,299 Commits 1 Branch 0 Tags 40 MiB
9814aff6b9
Commit Graph

14299 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Rosca
fa1ca80281 Fix iconitem test 
Icon name for QIcon must be from test-theme
 2016-03-05 11:05:52 +01:00
David Rosca
978b8b3b87 IconItem: Don't overwrite source when using QIcon::name() 
source should always return the same value as it was assigned.
Also removed duplicated code (empty sourceString is now handled
as if the source couldn't be converted to any type).

REVIEW: 127282
 2016-03-04 23:44:57 +01:00
David Rosca
da340aaefa ContainmentInterface: Fix use of QRect right() and bottom() 
right() = x() + width() - 1
bottom() = y() + height() - 1

REVIEW: 127277
 2016-03-04 23:44:05 +01:00
l10n daemon script
48d3dbc751 Upgrade ECM and KF5 version requirements for 5.20.0 release. 2016-03-04 22:27:18 +00:00
Anthony Fieroni
7c06cd064a Merge branch 'master' of git://anongit.kde.org/plasma-framework 2016-03-04 21:06:56 +02:00
Anthony Fieroni
6bb02c88eb [Applet] Don't crash on remove panel 
REVIEW: 127240
CCBUG: 345723

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
 2016-03-04 21:06:30 +02:00
David Edmundson
929d1fe008 Add missing file for iconitem test 2016-03-04 15:50:10 +00:00
l10n daemon script
6464f22534 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2016-03-04 09:12:16 +00:00
David Edmundson
1b21758570 Remove effectively duplicate code path for handling QPixmaps 
IconItem handled both QOixmaps and QImages as a source.

QVariant(somePixmap).canConvert<QImage>() returns true so one of the
two code paths isn't executed. Given converting between the two is
practically free, we don't need two code paths.

REVIEW: 127270
 2016-03-04 00:20:56 +00:00
David Edmundson
531b7f3a95 Add unit test for loading QPixmaps and QImages into IconItem 
REVIEW: 127269
 2016-03-04 00:20:35 +00:00
David Edmundson
8c4f789b17 Docs for IconItem 
REVIEW: 127268
 2016-03-04 00:20:02 +00:00
Marco Martin
58c465c042 fix stylesheet 
should fix colors assignments of the scrollbar elements

BUG:359345
 2016-03-02 12:14:50 +01:00
l10n daemon script
0f3198644e SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2016-03-01 11:55:01 +00:00
Eike Hein
ce4f7c1b79 Fix logic. 2016-03-01 17:41:03 +09:00
Eike Hein
3358c9eb9a Don't wipe window mask on every geometry change when compositing is active and no mask has been set. 
Avoids an extra full repaint.
 2016-03-01 17:27:33 +09:00
David Rosca
60af310cfc Theme: Discard pixmap cache when changing theme 
Changing theme also changes color scheme making the pixmap cache
invalid for monochrome icons.

CCBUG: 359924
REVIEW: 127226
 2016-03-01 00:06:15 +01:00
David Rosca
37fde3974e IconItemTest: Skip when grabToImage fails 2016-02-29 22:29:51 +01:00
David Rosca
30368e1d45 IconItem: Fix changing color of svg icons loaded from icon theme 
Connect to repaintNeeded when creating Plasma::Svg.

REVIEW: 127207
 2016-02-29 22:28:58 +01:00
Weng Xuetian
066cf0a0d7 Fix svg iconPath resolving in IconItem 
This fixes iconPath is not correctly set when its size changes.

REVIEW: 127201
 2016-02-29 13:05:48 -08:00
Marco Martin
40b99a9122 if path is passed, pick the tail 
PluginLoader::loadApplet works both by passing a simple plugin
name and a full path of a plasmoid package.

However, when loading the optional C++ plugin, we have to look
in the standard plasmoid plugin path, so only consider the
tail of the path name, as is guaranteed that part is equal to
the plugin name.

BUG:359902
Change-Id: Ic7300b7c12d7693bcb5590e29de780109a8ff81c
 2016-02-29 17:31:38 +01:00
Marco Martin
f55e20cc5f properties configurationRequired and reason 
unbreak api of Applet::SetConfigurationRequired + add bindings to
appletInterface as properties.
new properties configurationRequired and configurationRequiredReason

Change-Id: I18ff01df94c1a0c5fac79ff801bfa76714c9f986
REVIEW:127218
 2016-02-29 14:26:52 +01:00
David Edmundson
88ec6de113 Move contextualActionsAboutToShow to Applet 
Applet contains the menu actions, therefore reloading the menu should
happen in Applet not AppletInterface. With AppletInterface being a dumb
wrapper.

This exposes functionality to anyone who overrides Applet, but also will
also allows system tray to emit this signal without having to use
private API.

Change-Id: I95e65de315744a78a82ebba2a954e4f3ae1bd7b2
REVIEW: 127217
 2016-02-29 12:10:28 +00:00
l10n daemon script
e1e58332e7 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2016-02-29 11:17:43 +00:00
Aleix Pol
06c7b9c050 Remove some warnings 
Unused variables
Unused code
Unused arguments
Unnecessarily complex code
Initialization order
Duplicated properties

REVIEW: 127214
 2016-02-29 00:59:44 +01:00
Aleix Pol
9f62532674 Fix most of Clazy warnings in plasma-framework 
REVIEW: 126672
 2016-02-29 00:13:41 +01:00
David Rosca
3c8cb82d44 Fix build with Qt < 5.6 2016-02-28 10:36:57 +01:00
David Rosca
526915895b Add autotests for IconItem 
Add some tests for IconItem.
Also found one issue in animation when quickly changing source, first frame
will be rendered with wrong icon.

REVIEW: 127103
 2016-02-27 21:24:45 +01:00
l10n daemon script
361204cbee SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2016-02-27 09:29:41 +00:00
Marco Martin
d524d96a25 using the margins of the flickable item is wrong 
the clip will be at ScrollView, not at flickable level
 2016-02-24 12:52:24 +01:00
l10n daemon script
3847dc6d91 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2016-02-24 09:12:03 +00:00
David Rosca
172847fc3b DataContainer: Fix slot checks before connect/disconnect 
Use indexOfSlot instead of indexOfMethod and check for index >= 0.
Also added missing checks for all dataUpdated connects.

REVIEW: 127133
 2016-02-23 19:08:48 +01:00
David Edmundson
73aa13b26d fix uninitialised var 
Valgrind pointed this out whilst debugging something else.

REVIEW: 127079
 2016-02-23 13:05:10 +00:00
l10n daemon script
78cee23be3 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2016-02-22 10:53:01 +00:00
David Rosca
fca765bc05 ToolTip: Prevent multiple geometry changes while changing contents 
Unset mainItem and set it back only after changing of tooltip contents
is completed. This improves behavior of morphingpopups effect (popups
animates from/to incorrect values).

REVIEW: 127118
 2016-02-21 15:06:44 +01:00
David Rosca
4eeed04f0f Revert "Reparse svgElementsCache instead of deleting it in discardCache" 
This reverts commit a8e54e15e1.
 2016-02-21 15:05:13 +01:00
l10n daemon script
9e1b7dab46 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2016-02-21 09:52:09 +00:00
l10n daemon script
82c351cb04 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2016-02-20 09:50:14 +00:00
David Rosca
596fa082dd SvgItem: Don't use Plasma::Theme from rendering thread 
Logic is similar to IconItem - rendered image is updated
in updatePolish().

REVIEW: 127115
 2016-02-19 18:16:30 +01:00
David Rosca
f4e541ad87 Fix crash from previous commit - nullptr check 2016-02-19 13:39:55 +01:00
David Rosca
a8e54e15e1 Reparse svgElementsCache instead of deleting it in discardCache 
svgElementsCache may be created on render thread and deleted
on main thread, which will make KSharedConfig crash because
it uses per-thread storage.

BUG: 359539
REVIEW: 127112
 2016-02-19 13:25:26 +01:00
David Rosca
82e172cc9e AppletQuickItem: Fix finding own attached layout 
Regression from 344dbeb938

BUG: 358849
REVIEW: 127073
 2016-02-19 13:23:26 +01:00
Marco Martin
b6d636cc8f smaller expander for the taskbar 
2+ doesn't make sense.
use just a single + in a circle ~half of the old one
 2016-02-19 12:44:12 +01:00
l10n daemon script
57fbaa0597 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2016-02-19 09:24:58 +00:00
Kai Uwe Broulik
eccf7cf0b2 [ToolTip] Stop show timer if hideTooltip is called 
This prevents the tooltip from showing up if hideTooltip was called
before it was shown.

BUG: 358894

Differential Revision: https://phabricator.kde.org/D959
 2016-02-18 21:58:35 +01:00
Aleix Pol
978529d175 Remove unused variable 
Reviewed by Marco Martin
 2016-02-18 17:03:49 +01:00
David Rosca
1f98734dd3 Disable animation of icons in plasma tooltips 
Tooltips are now animated with KWin effect.

REVIEW: 126653
 2016-02-17 18:40:14 +01:00
Marco Martin
ce9751cb35 drop animations from tooltips 
tooltips are now animated by a KWin effect, don't try
to animate own X11 positions, that's quite dangerous

Change-Id: I08ef2bc23ec1ef7cb7c432ba1bf6d9c5b0a0ab01
 2016-02-17 17:16:02 +01:00
Marco Martin
3224f87c15 default theme follows color scheme 
new breeze-light that is just as the old one

REVIEW:127085

Change-Id: Iab4f79fff172e885f8188e0d1bbf2dea266cb9e3
 2016-02-17 12:08:31 +01:00
Dan Vrátil
525bf2d377 Fix IconItem not loading non-theme icons with name 
Commit 5184ac introduced a small regression that caused IconItem
to no longer load non-theme icons with name set, for instance icons
coming from sni-qt, causing sni-qt apps to not show in systray.

BUG: 359388
FIXED-IN: 5.20
REVIEW: 127091
 2016-02-16 21:16:01 +01:00
David Rosca
4d012a8cc5 Prefer other containments than desktop in containmentAt() 
Desktop containment will match every valid pos, so we should
return it only if nothing else matches.

REVIEW: 127075
 2016-02-15 19:06:47 +01:00