Remember to document ALL parameters to methods. They may seem obvious to you, but I had to look at the code for at least two of the methods in order to document their parameters correctly.
*waves stick of EBN-ness*
svn path=/trunk/KDE/kdelibs/; revision=908604
these were found while testing the Krazy style checker, which I'm adapting
for the kdelibs style.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870051
+setNeedsUpdate()->protected used in dataengine line 306
+checkUsage()->protected used in dataengine line 293
protected or pimpl/modification in dataengine too?
CCMAIL : ervin@kde.org
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801168
[note: I have checked that indeed it's not called as a slot in kdebase, /extragear/plasma or playground/base/plasma]
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800593
Not used anywhere outside libs/plasma, not used in /extragear/plasma or /playground/base/plasma
Same case as SIGNAL unused()->becameUnused() as Kévin noted, can be moved to pimpl of DataContainer
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800587
* don't do an immediate call using invokeMethod if the visualization is already connected and we're just adjusting it
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800383
- timestamp sources on update so we don't over update them due to multiple visualizations hammering on it. improves our tick situation even more.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=712188
this is needed by clocks, as the obvious example, since "once a minute" isn't enough: it needs to be once a minute *on* the minute
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=711737
- keep track of objects that are connected even at interval == 0
- remove disconnectNotify due to these changes
- allow multiple calls to connectVisualization to work properly without resulting in
multiple connections to the same object and allowing the update interval to be
adjusted for a given source/vis pair
this makes it pretty important to use connectVisualization and disconnectVisualization rather than QObject::connect and QObject::disconnect for the updated signal stuff
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=711717
i'm sure there are several bugs at this point (so don't try and use it quite yet ;) but most importantly:
- all methods are implemented
- it compiles ;)
- it does not have any negative impact on existing engines and applets as they currently are written
next will be to put it all through its paces, starting with the time engine and analog clock applet. i may not get to that until tomorrow, hoever.
this commit also fixed a number of buglettes along the way that had creeped in, e.g. not properly connecting all signals in connectAllSources (moved that ccode to the Private class to avoid code dupe and similar bugs in the future)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=710849
* Copyright (C) -> Copyright
* add "or later" clause to files that i have the sole copyright on
* add current year (2007) to my copyrights where it was missing
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=696946
