Summary:
This patch gives the clock's hour hand a shadow for the spindle too, since the shadow model we're using should logically have the spindle casting a shadow.
It also also increases the height of the minute hand shadow since its current length is short enough that it sometimes doesn't connect to anything.
CCBUG: 396612
Test Plan:
Before: {F6551256}
After: {F6551257}
There are no visual changes whatsoever because the hour hand shadow is not currently displayed (See D17751 for background)
Reviewers: #vdg, #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D18288
Summary:
This patch turns off light font styles for some headings because they cause visual and legibility issues, as explained in the respective bug report.
BUG: 402730
FIXED-IN: 5.54
Test Plan:
**//Worst case scenario testing//** - font does not have a "light" variant and falls back to using a thinner one such as "hairline"
**Before:**
{F6520036}
{F6520035}
{F6520034}
**After:**
{F6520039}
{F6520038}
{F6520037}
**//Plasma defaults testing//**
**Before**:
{F6520778}
{F6520777}
{F6520776}
**After:**
{F6520781}
{F6520780}
{F6520779}
Reviewers: ngraham, #plasma, #vdg, #frameworks
Reviewed By: ngraham, #vdg
Subscribers: #frameworks, #plasma, #vdg, ngraham, abetts, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D17905
The item's visible property is independent of the window visibility, which can be checked using Window.visible.
Differential Revision: https://phabricator.kde.org/D17543
Otherwise we'll keep piling up custom tooltip items in the dialog. They're invisible but they're still there.
Differential Revision: https://phabricator.kde.org/D17542
This allows for calendar widgets to override the Locale. Users may
want to start the week on a Sunday, Saturday, or Monday without
changing their locale's date formatting.
CCBUG: 390330
Differential Revision: https://phabricator.kde.org/D15321
Summary: It's exactly the same as the regular 32px bluetooth icon in this file, but D17346 needs it.
Reviewers: #vdg, #plasma, broulik, ngraham
Reviewed By: #vdg, #plasma, broulik, ngraham
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D17505
Summary:
Leverages QSharedPointer for the reference counting.
Keeps the last value of the cacheId, as it can change sometimes and crash
the system.
Reviewers: #plasma, #frameworks, zzag
Reviewed By: #plasma, zzag
Subscribers: mart, zzag, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D17052
KPackagePrivate::internalPackage already existed, the re-assignment to a
new value causes a memory leak.
Trace:
Indirect leak of 112 byte(s) in 1 object(s) allocated from:
#0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
#1 0x7f905829163f in KPackage::Package::Package(KPackage::PackageStructure*) /home/kfunk/devel/src/kf5/kpackage/src/kpackage/package.cpp:51:9
#2 0x7f9058fad786 in Plasma::Package::Package(Plasma::PackageStructure*) /home/kfunk/devel/src/kf5/plasma-framework/src/plasma/package.cpp:66:34
#3 0x7f9058f14dee in Plasma::Corona::package() const /home/kfunk/devel/src/kf5/plasma-framework/src/plasma/corona.cpp:78:13
#4 0x5d9eb9 in ShellCorona::ShellCorona(QObject*) /home/kfunk/devel/src/kf5/plasma-workspace/shell/shellcorona.cpp:132:70
#5 0x65c31d in ShellManager::loadHandlers() /home/kfunk/devel/src/kf5/plasma-workspace/shell/shellmanager.cpp:93:21
When a dataengine failed to load it would ask PackageKit to install it but it's generally not how we want to distribute
plasmoid infrastructure these days and didn't work.
Differential Revision: https://phabricator.kde.org/D16301
Without this, ToolButton.qml (Plasma Components 3) is not installed and
applets like the mediacontroller do not load because they can't find it.
The line has been removed in 6126954816,
and it looks like an unrelated change.
Marco, feel free to revert if the proper solution is different.
CCMAIL: notmart@gmail.com
Summary:
in QQC2 the text selection controls depend upon the style, which has to
implement it by itself
this adds touch based draggable cursor and text selection handles,
alongside a tiny toolbar for cut/copy/paste
the desktop style will need the exact same thing
T10023
Test Plan:
works correctly when in tablet mode, none of this is visible
when in desktop mode where the text fields behave normally
Reviewers: #plasma, bshah
Reviewed By: #plasma, bshah
Subscribers: ngraham, abetts, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D16841
Summary: The current colorschemes included in the breeze-light and breeze-dark Plasma themes do not match the Breeze and BreezeDark colorschemes in the breeze repo. For instance, the breeze-dark Plasma theme used an ugly yellow-green for ForegroundNeutral instead of Beware Orange like in the Breeze and BreezeDark colorschemes. It also used a much harsher red that looked inconsistent with BreezeDark. I've been using the new colorschemes for the past month and the most noticeable changes are just the new orange and red colors.
Test Plan:
Old:
{F6411526, size=full}
{F6411527, size=full}
{F6411875, size=full}
{F6411889, size=full}
New:
{F6411523, size=full}
{F6411525, size=full}
{F6411883, size=full}
{F6411898, size=full}
Reviewers: #vdg, #breeze, #plasma, mart, ngraham
Reviewed By: #vdg, #breeze, #plasma, mart, ngraham
Subscribers: ngraham, mart, broulik, #vdg, kde-frameworks-devel
Tags: #frameworks, #vdg, #breeze, #plasma
Differential Revision: https://phabricator.kde.org/D16810
