Remember to document ALL parameters to methods. They may seem obvious to you, but I had to look at the code for at least two of the methods in order to document their parameters correctly.
*waves stick of EBN-ness*
svn path=/trunk/KDE/kdelibs/; revision=908604
these were found while testing the Krazy style checker, which I'm adapting
for the kdelibs style.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870051
QueryMatch by value! shared dptr == no copy of data either! so (nearly) all the speed love of pointers with none of the crash hate. woo!
RunnerContext also by value! die pointers die!
also get rid of tons of locking that just doesn't make sense anymore; get rid of data priority enum as well since it's completely meaningless.
speed, glory, stability! ftw!
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=805661
-New RunnerManager class, it manages runners at high level
and gives a simple API for interfaces to use.
- AbstractRunners gains description, setIgnoredTypes, ignoredTypes methods.
Now runners can specify what SearchContext::Types they are not going to process.
- SearchContext tries shared data between the original context and any local context.
It doesn't have its own completer no more.
- SearchMatch has a new type of match, CompleterMatch. Instead of using a hard coded
completer in SearchContext
- Interface class on krunner has its own completer and other changes
done to accomodate the above changes in libplasma.
-A new configuration option blacklist for runnermanager and krunner
instead of the whitelist of krunner.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802903
run() method is more obvious than exec() (don't forget that a runner run :) ).
Anyway during the meeting we have decided to replace createMatchOptions() with createRunOptions()
and (set)hasMatchOptions() with (set)hasRunOptions(), now with this commit we have a more coherent naming.
CCMAIL: panel-devel@kde.org
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802143
applets,
please update to another revision to use the version that works
green flag from aaron
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=796368
* remove add*Match since they broke the pattern of usage (who owns the match? do you have to add it again? etc..)
* add addMatch to compliment addMatches for those runners that just ever have one match
* make the default SearchMatch type Possible rather than Exact (making Exact and Informational the exceptions, which matches usage patterns)
* const'ify the API a bit better
generally more performant, lower memory usage and clearer API having seen what is beign done in the runners. also makes it a bit easier to turn the Matches into a qt model
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=776931
