Commit Graph

308 Commits

Author SHA1 Message Date
David Edmundson
a36c2787b9 Merge branch 'davidedmundson/containmentcleanup2' 2013-12-17 16:44:54 +01:00
Sebastian Kügler
5c96de0c57 Minor cleanups in dialog.cpp 2013-12-17 05:11:50 +01:00
Sebastian Kügler
5ff0605529 Compile-time connection for dialog sizing 2013-12-17 03:54:37 +01:00
Sebastian Kügler
e352eb9157 Remove activeWindow property
This shadows and QWindow.active, so use that.
2013-12-17 03:37:32 +01:00
Sebastian Kügler
462cfdcdc7 Port from activateWindow to requestActivate 2013-12-17 03:05:16 +01:00
Sebastian Kügler
2edebc57c3 Remove windowFlags property
This is a needless duplication of the property, and it causes bugs.

Removing it, and porting all users to the flags property from QWindow
magically makes layering and resizability bugs vanish.

One problem is left: the dialog dismisses too easily, it should not
dismiss when being resized, moved or when a child dialog or QMenu opens
from it.
2013-12-17 02:39:26 +01:00
Sebastian Kügler
4c17887657 Remove hack, it does more harm than good. :/
CCMAIL:mgraesslin@kde.org
2013-12-17 02:39:10 +01:00
Sebastian Kügler
04fd5d719a Use visible property from QQuickWindow
Don't override it anymore, but react to the changed signal to do our
magic.
2013-12-17 01:21:59 +01:00
Sebastian Kügler
714042904f Abuse flags
Interestingly, this hack yields the correct behaviour in my system. We
quickly set the always on top hint once we're supposed to hide, so the
window stays on top for the duration of the animation -- without
apparent side effects on the positioning and resizability.

CCMAIL:mgraesslin@kde.org
2013-12-17 01:10:58 +01:00
David Edmundson
906caec817 Expose screen to MouseEventListener events 2013-12-16 15:30:13 +01:00
Aurélien Gâteau
02d6b37976 Renames for the KF5 prefix 2013-12-11 21:40:54 +01:00
Antonis Tsiapaliokas
4efb85e5d2 Replace tab with spaces 2013-12-11 21:40:54 +01:00
Martin Klapetek
3214bd8132 Add KF5 prefix to plasma framework
This changes the lib name and package names to follow other frameworks

libFoo -> libKF5Foo
find_package(KFoo) -> find_package(KF5Foo)

REVIEW: 114389
2013-12-11 21:40:54 +01:00
Martin Gräßlin
86d030efac Add a hideOnWindowDeactivate property to PlasmaCore.Dialog
This property is meant to bring back the functionality provided by
PopupApplet. If the property is set to true the dialog gets hidden
when it loses focus.

REVIEW: 114378
2013-12-11 11:15:07 +01:00
Antonis Tsiapaliokas
1ebb352a76 Replace tab with spaces 2013-12-10 18:36:30 +02:00
Aleix Pol
6c82a1ee86 Reduce compiler warnings
Remove unused and deprecated headers
Port some K_GLOBAL_STATIC to Q_GLOBAL_STATIC
2013-12-09 16:50:18 +01:00
Martin Gräßlin
1d28b028b1 Use IconEffect for disabled state in QIconItem
Reason for this change: a QIcon might not contain the disabled pixmaps.
Using the icon effect allows to get also the disabled state for such
icons.

REVIEW: 114334
2013-12-06 16:24:41 +01:00
Aleix Pol
fd3fe7d5f5 Try having code only verbose when there are problems
Random output on random components doesn't really help.
2013-12-05 19:34:12 +01:00
Martin Klapetek
13d1f5568f Remove KLocale bindings
KLocale is now kde4support and we have QLocale QML bindings. This patch
removes the KLocale bindings from plasma-framework (they are not used
anywhere anyway).

If we miss something from KLocale in QLocale, we should upstream it.

REVIEW: 114150
2013-11-27 16:28:46 +01:00
Martin Klapetek
c29773656e Make isToday compare actual dates
So we don't have to construct awkward strings everytime.
2013-11-27 00:23:41 +01:00
Martin Klapetek
6eea4da70d Use proper index validity checking 2013-11-27 00:22:57 +01:00
Martin Klapetek
cb4d7e8b4c Emit proper signals everywhere 2013-11-27 00:22:08 +01:00
Martin Klapetek
e80e2960c6 Shuffle the code around a bit
These methods are in the middle of other together-related methods, for
no reason. Looks like corn flakes in the middle of beer. Sure, you can
do that, but why would you. Actually I should try that.
2013-11-27 00:21:22 +01:00
Martin Klapetek
33f2670f07 Remove empty Q_SIGNALS & Q_SLOTS 2013-11-27 00:13:44 +01:00
Martin Klapetek
f9cca29bd1 Make MonthMenu items not hardcoded
That's just wrong.
2013-11-27 00:07:30 +01:00
Martin Klapetek
5c6b1c9251 Rename isTodayMonth() to today()
Whoever named the method like that should be slapped over his fingers.
2013-11-26 17:28:15 +01:00
Martin Klapetek
ab97884c00 Calculate days before current month properly 2013-11-26 16:24:04 +01:00
Martin Klapetek
d1dc311345 Reinstate the month name capitalization
Some CLDR (locale) data used by Qt have standalone month names
starting with lower-case letters. So if we want to provide consistent
look across locales, we need to capitalize it ourselves

See https://bugreports.qt-project.org/browse/QTBUG-35100
2013-11-25 17:00:19 +01:00
Martin Klapetek
580d7d198a Revert capitalizing the month's name
That's a locale thing/bug.
2013-11-25 13:42:54 +01:00
Martin Klapetek
ff47006845 Add some docs to Calendar binginds 2013-11-25 13:24:49 +01:00
Martin Klapetek
224e1a620b Make the calendar applet follow current locale with first day in week
Also rename startDay property to firstDayOfWeek property so it's more
clear what it does. Handling the first day of week is changed a bit too
as QML uses 0 for Sunday while QDate uses 7 for Sunday, so the
getter/setter is accomodated to that fact and converts from 0 to 7 on
setting and vice-versa in the getter.

REVIEW: 114099
2013-11-25 13:24:30 +01:00
Aleix Pol
f187db1e86 Remove KDE4Support dependency from plasma-frameworks (almost)
Stop using classes from kde4support:
- KComponentData is deprecated, it will be using QCoreApplication::
applicationName() and QCoreApplication::applicationVersion(). Of course,
this means that the existing shells will have to be ported. I have no
problem with doing that port myself, if I'm told where to look into.
- Drop usage of KLocale, ported to QLocale
- Drop usage of KStandardDirs, ported to QStandardPaths
- Drop usage of KIcon, ported to QIcon

Furthermore, there's a module in src/declarativeimports/locale that IIUC
exposes KLocale bindings to QML. A specific plan to port it should happen
as well.

REVIEW: 113920
2013-11-22 13:03:29 +01:00
Sebastian Kügler
ccca440859 Default to BottomEdge in Dialog
Also add a little bit of debugging to check sizing.
2013-11-20 04:05:35 +01:00
Aleix Pol
0fa21b4af5 Iterate over the cmake scripts
Prefer using imported targets rather than cmake variables.
2013-11-15 16:46:59 +01:00
Aleix Pol
3ef13c53dc Remove predicates on cmake end commands
http://techbase.kde.org/Policies/CMake_Coding_Style#End_commands
2013-11-14 17:25:10 +01:00
Mark Gaiser
d56f690fcf Add license to calendar component classes. 2013-11-13 13:41:41 +01:00
Sebastian Kügler
085e232641 Export MonthMenu, calendar 2013-11-13 06:05:52 +01:00
Sebastian Kügler
4337daa38e Various layout improvements 2013-11-13 05:28:42 +01:00
Sebastian Kügler
95dc36f0ee large spacing is defaultFont.mSize().height 2013-11-13 05:26:18 +01:00
Sebastian Kügler
d248fe1955 clean up a bit 2013-11-12 05:56:10 +01:00
Sebastian Kügler
6f8d1b6ab2 correct initial date setting, theming improvement 2013-11-12 05:51:45 +01:00
Sebastian Kügler
6134503899 Navigation improvements
- fix today highlighting
- click on month name opens menu to switch month
- jump to today works
2013-11-12 04:53:50 +01:00
Sebastian Kügler
19db9c9663 Add calendar QML components to the Plugin
This allows us to keep minimal API, since the calendar view and import
really belong together. Also makes it a lot easier to provide a separate
Calendar Plasmoid.
2013-11-12 03:40:52 +01:00
Sebastian Kügler
859e2ce352 theme.smallSpacing and theme.largeSpacing
Accessors to allow centralized control of spacing in a DPI-friendly way.
Will be used to unify spacing across default widget to make them look
more consistent.

Currently, smallSpacing is font height / 10, large is font height / 2.
2013-11-11 22:53:42 +01:00
Aleix Pol
1d3da96d88 Make sure that plasma-framework is not using anything from kdelibs4
Stop finding the packages
Remove KDE4_ includes
Remove unused LIBINTL finder, provided by kdelibs
2013-11-11 18:29:32 +01:00
David Faure
f4e6d019f6 Add missing include, after all-of-QtDBus-and-QtCore removal in kdelibs headers 2013-11-10 13:03:50 +01:00
Martin Gräßlin
9e32090b50 Do not add dialog to DialogShadows before it became visible at least once
Calling DialogShadows::self()->addWindow(...) will create the low level window.
If this is called before the property windowFlags is evaluated the window flag
X11BypassWindowManagerHint has no effect as that one must be present when the
window is created through the low level xcb call.

This was breaking declarative KWin scripts as KWin's windows need to have the
X11BypassWindowManagerHint.

REVIEW: 113700
2013-11-07 10:33:56 +01:00
Sebastian Kügler
44a27ca40a Update buttonDownPos in event filter
This basically fixes the clicked signal, probably a sutble change in Qt
between 4 and 5 revealed this bug.
2013-11-07 00:21:56 +01:00
Marco Martin
3530130b19 make sure is frameless 2013-10-30 18:39:42 +01:00
Sebastian Kügler
7b0faed939 Remove QIconItem 2013-10-30 17:20:57 +01:00