This in turn makes the default:
QPainter::fillRect(QRect(...), Qt::transparent);
a no-op. The commit makes the fillrect actually do what, I bet
it was supposed to be doing. (but i ain't much of a gambler since
i'm not sure what it's supposed to be doin in the first place. at
least now it's doing something "weird" faster)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=680260
Check for QString compares to ""... OOPS! 1 issue found!
./libs/plasma/widgets/lineedit.cpp: line#178 (1)
Do not compare a QString to "". Instead use the .isEmpty() method. For example, if(str == "") becomes if(str.isEmpty())
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=679628
i introduced a new enum in the Plasma namespace, ItemType, so we can keep track of these id's centrally.
however, the right click mechanism is rather broken in its implementation; we need a way to offer a centralized menu on appets no metter where they are clicked.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=678562
and it is empty, the can be "defaultText" that will be displayed. See
dict applet for example.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=678514
* don't click when moving (either the icon or the mini buttons)
* only show the buttons on hovered states, allowing for proper button/hover/pressed painting
* try and avoid unecessary if/else's and other codedamage
* get rid of some dead code
now it's about ready to be phased =)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=676842
* show the button(s) in .2s rather than the very slow feeling .5s
* don't leak the timeline
* don't connect to the timeline signal more than once
* comment in code that is ifdef'd out anyways
* don't set the svg element for fg and bg unless it exists
* remove some dead code
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=676786
Implemented the concept for icons from David Vignoni (screencast coming...).
Context menu now shows "Plasma".
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=676455
* Nicer SVG, also fixed the corners, now are pixel perfect
* Prepared the code for the upcoming blur of the wallpaper....
svn path=/trunk/KDE/kdebase/workspace/lib/plasma/; revision=672328
#include <plasma/foo.h>
in headers in libplasma. this is important so that they can be used post-install by third party plugins, apps, etc.
also, changed Applet::loadDataEngine to just Applet::dataEngine and make it actually return the data engine; move the applets to using it. safer and fewer LoC
svn path=/trunk/KDE/kdebase/workspace/lib/plasma/; revision=670850
- background
- background-hover
- background-pressed
- foreground
- foregound-hover
- foreground-pressed
what each does is left as an exercise for the reader ;)
svn path=/trunk/KDE/kdebase/workspace/plasma/lib/; revision=669620
* add a resetLayout() so layouts can release LayoutItems on deletion, avoiding dangling pointers and possible crashes
svn path=/trunk/KDE/kdebase/workspace/plasma/lib/; revision=668931
Widget remains problematic as it uses QGraphicsItem API, but it needs to be subclassed by items that are already QGraphicsItems. ugh.
svn path=/trunk/KDE/kdebase/workspace/plasma/lib/; revision=668083