Commit Graph

15523 Commits

Author SHA1 Message Date
Friedrich W. H. Kossebau
d70eadb977 API dox: adapt kapidox & ecm_add_qch settings to new deprecation macros
GIT_SILENT
2019-10-22 19:41:15 +02:00
Björn Feber
bbe0148db5 Improve panel options menu entries
Summary:
- Move "Panel Options" context menu items out of submenu
- Rename "Configure Panel..." option

See M144, T10047, T10190. This makes the panel customization options much more discoverable.

Test Plan: Open the panel context menu.

Reviewers: #plasma, #vdg, mart

Reviewed By: #plasma, #vdg, mart

Subscribers: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma

Tags: #frameworks

Maniphest Tasks: T10190, T11094, T10402

Differential Revision: https://phabricator.kde.org/D23951
2019-10-21 19:53:46 +02:00
Marco Martin
acbb200ac2 edit mode action
Summary: needed for the context menu entry

Test Plan: with the p-w- portion the action shows in the context menu

Reviewers: #plasma, #vdg, GB_2, ngraham, davidedmundson

Reviewed By: #plasma, #vdg, ngraham, davidedmundson

Subscribers: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10190, T11094, T10402

Differential Revision: https://phabricator.kde.org/D24263
2019-10-21 13:06:01 +02:00
Friedrich W. H. Kossebau
573b9a439f Enable KF_* group deprecation macros
GIT_SILENT
2019-10-20 03:46:32 +02:00
Friedrich W. H. Kossebau
df7f981890 Use ECMGenerateExportHeader to manage deprecated API better
Summary:
Allows
* projects linking to Plasma to hide deprecated API up to a
  given version or silence deprecation warnings after a given version,
  using
  * -DPLASMA_DISABLE_DEPRECATED_BEFORE_AND_AT
  * -DPLASMA_NO_DEPRECATED
  * -DPLASMA_DEPRECATED_WARNINGS_SINCE
  * -DPLASMA_NO_DEPRECATED_WARNINGS
  * -DPLASMAQUICK_DISABLE_DEPRECATED_BEFORE_AND_AT
  * -DPLASMAQUICK_NO_DEPRECATED
  * -DPLASMAQUICK_DEPRECATED_WARNINGS_SINCE
  * -DPLASMAQUICK_NO_DEPRECATED_WARNINGS

  or
  * -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
  * -DKF_NO_DEPRECATED
  * -DKF_DEPRECATED_WARNINGS_SINCE
  * -DKF_NO_DEPRECATED_WARNINGS

Reviewers: #plasma, mart, davidedmundson, apol, mlaurent

Reviewed By: #plasma, mart, mlaurent

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24678
2019-10-19 00:42:13 +02:00
Friedrich W. H. Kossebau
ab8e63a5a5 Use new INCLUDE_DIRS with ecm_add_qch, to have doxygen see more includes
GIT_SILENT
2019-10-19 00:39:53 +02:00
Friedrich W. H. Kossebau
7f52e22deb Include KDE CMake settings macros as first
GIT_SILENT
2019-10-15 17:58:10 +02:00
Noah Davis
15ed55b4cb [icons/media.svg] Add 16 & 32px icons, update style
Summary: Fixes blurry icons in the desktop shell

Test Plan:
{F7593397, size=full}

Examples of fuzzy icons:

task manager {F7593494, size=full}
media player widget {F7593497, size=full}

Fixed:

{F7593493, size=full}
{F7593509, size=full}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24627
2019-10-14 22:28:49 -04:00
l10n daemon script
e5b81587a5 GIT_SILENT Upgrade KF5 version to 5.64.0. 2019-10-12 21:26:10 +00:00
Nate Graham
949a26d3fa [PlasmaComponents3] Fix checkable toolbutton background
Summary:
This fixed the background of a checkable PC3 ToolButton not being visible when checked.
The PC3 Button and PC2 ToolButton did not suffer from the issue, but the PC3 one did.

Test Plan:
Checkable PC3 ToolButtons now look checked when checked

No change for non-checkable PC3 ToolButtons

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24402
2019-10-07 07:26:54 -06:00
l10n daemon script
04c8eca727 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.63.0 release. 2019-10-06 09:38:31 +00:00
Méven Car
5f6996ee50 Export Plasma core lib log category, add a category to a qWarning
Test Plan: Builds, new context for warning is visible

Reviewers: #frameworks, broulik, davidedmundson, apol

Reviewed By: davidedmundson, apol

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23266
2019-10-04 08:51:02 +02:00
David Edmundson
982c052025 [pluginloader] Use categorized logging 2019-09-30 09:29:40 +01:00
Marco Martin
c621ebe572 make editMode a corona global property
Summary:
The plans are to switch on/off the whole plasma shell into edit mode.
For this it needs to be a global corona property, rather then just
containmentInterface.
Plasmashell would expose a dbus call to set it from systemsettings

Test Plan: plasmoid.editMode=true still works

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, GB_2, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24239
2019-09-26 19:53:41 +02:00
Kai Uwe Broulik
d5a5d07f0f Honor global animation speed factor
Multiplies the animation speed by the given factor.

Differential Revision: https://phabricator.kde.org/D23857
2019-09-25 15:55:17 +02:00
Marco Martin
455b41bc62 properly install whole plasmacomponent3
Summary:
right now just a subsection of controls are installed under plasmacomponent3
which makes for random missing stuff, especially any new component added.
it was done to avoid to have things like "applicationwindow" which don't make sense
in plasma, tough those are already available anyways as plain qqc2
install the whole folder avoiding many potential headaches

Test Plan: ieverything still works, all the components are available

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24072
2019-09-20 14:02:02 +02:00
Marco Martin
f301c7ea2d we need bigger buttons on mobile
as is an hack, was tried to be removed, but it doesn't work
2019-09-19 11:53:32 +02:00
David Faure
a4b74ea551 GIT_SILENT disable deprecated API from Qt 5.13 and before 2019-09-17 21:31:26 +02:00
Kai Uwe Broulik
67811e152a [Dialog] Apply window type after changing flags
Changing flags might override the window type, ensure we set it back properly

Differential Revision: https://phabricator.kde.org/D22569
2019-09-16 08:55:09 +02:00
David Faure
b466a2a211 Port away from deprecated methods in Qt 5.14
Test Plan: Builds with -DQT_DISABLE_DEPRECATED_BEFORE=0x060000 (as of today)

Reviewers: davidedmundson, broulik, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23970
2019-09-16 05:40:34 +02:00
l10n daemon script
1a8cfcd585 GIT_SILENT Upgrade KF5 version to 5.63.0. 2019-09-14 11:42:40 +00:00
David Edmundson
4ecdbe9622 Add manual tests for PC3
Summary:
These were super useful for spotting bugs in PC2.
They show many many issues already.

Visually they should match PC2. They don't

Some API doesn't map directly. Those tests
were removed.

Test Plan:
Opened in qmlscene
Everything binds correctly. Some things look horrible.

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23827
2019-09-11 11:11:47 +02:00
Laurent Montel
d60831d650 Port from delta(); to angleDelta().y(); 2019-09-09 18:52:11 +02:00
Björn Feber
fb18347e4d Change reveal password button logic
Summary:
Indicate state, not the action it will have. When the password field is empty it feels like the password will be shown once I start typing. Dolphin has been doing it this way for the "show hidden files" action forever.
Also only show the button when the field contains text or when revealing the password, like in the PolKit dialog.

Test Plan:
Empty field
{F7326288}

{F5697017}
{F5697018}

Dolphin
Show hidden files, files are currently hidden
{F5697031}
Hide hidden files, files are currently shown
{F5697032}

Reviewers: #plasma, #vdg, ngraham, broulik, ndavis

Reviewed By: #vdg, ngraham, ndavis

Subscribers: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D10362
2019-09-09 17:48:54 +02:00
Friedrich W. H. Kossebau
c88354e0ed API dox: add missing @since
GIT_SILENT
2019-09-08 23:51:04 +02:00
Friedrich W. H. Kossebau
295059675c API dox: use full signatures for autolink on overloaded methods
GIT_SILENT
2019-09-08 23:50:40 +02:00
Friedrich W. H. Kossebau
3b6d9de925 API dox: fix name of item class
GIT_SILENT
2019-09-08 23:43:33 +02:00
Friedrich W. H. Kossebau
f31e4d95fd API dox: use @li for proper list
GIT_SILENT
2019-09-08 23:42:11 +02:00
Friedrich W. H. Kossebau
8ef47b1323 API dox: fix wrong use of @class
GIT_SILENT
2019-09-08 23:34:30 +02:00
Friedrich W. H. Kossebau
5e09728c1b API dox: use @code/@endcode
GIT_SILENT
2019-09-08 23:33:09 +02:00
David Edmundson
5f746ce1c2 Fix crash on teardown with Applet's ConfigLoader
Summary:
Deleting AppletPrivate will delete the ConfigLoader which will cause a
save, which can trigger a configSaved signal.

I think it is correct that the config might emit a signal just before
closing, and not at fault.

AppletPrivate is deleted by this point, but Applet is not so the
connection is still alive.

When we handle the signal, it goes into a Q_PRIVATE_SLOT that crashes.

This disconnect pattern is already used for guarding self config
changes.

BUG: 411221

Test Plan: kquitapp5 plasmashell, no longer crashes

Reviewers: #plasma, alexeymin

Reviewed By: alexeymin

Subscribers: alexeymin, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23707
2019-09-07 23:19:03 +02:00
l10n daemon script
9d6a24a771 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.62.0 release. 2019-09-07 12:38:57 +00:00
Noah Davis
db7837d5f5 Make notification icons use outline style
Summary: They didn't quite fit in with the filled style

Test Plan:
Old: {F7304467, size=full}

New: {F7304458, size=full}

Testing stylesheets in Plasma Theme Explorer:
{F7304463, size=full}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, filipf, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23627
2019-09-03 11:15:15 -04:00
Aleix Pol
ea88d2aa51 Skip test on wayland
Summary: It's using some API that isn't available

Test Plan: Noise gone

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23587
2019-08-30 18:06:45 +02:00
Aleix Pol
d3b22f8828 Port trivial connects to the new style 2019-08-30 17:26:54 +02:00
Laurent Montel
f53365633c GIT_SILENT: Use QLatin1String in QString::contains etc. Fix replace
usage
2019-08-29 07:25:48 +02:00
Camilo Higuita
069b4e95c1 make the sizing of the toolbuttons more coherent
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height  if those props are set.

Before patch:

{F7274098}

After patch:

{F7274097}

Reviewers: #plasma, mart, ngraham

Reviewed By: #plasma, mart, ngraham

Subscribers: broulik, apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23367
2019-08-28 08:59:32 -05:00
Marco Martin
86021afdf5 Revert "make button icons follow a reasonable size and layout"
This reverts commit f973619116.
2019-08-28 10:43:22 +02:00
Marco Martin
c6c882521f Revert "make the sizing of the toolbuttons more coherent"
This reverts commit 3887f5ec91.
2019-08-28 10:43:09 +02:00
Camilo Higuita
3887f5ec91 make the sizing of the toolbuttons more coherent
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height  if those props are set.

Before patch:

{F7274098}

After patch:

{F7274097}

Reviewers: #plasma, mart, ngraham

Reviewed By: ngraham

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23367
2019-08-23 16:35:37 -05:00
Camilo Higuita
f973619116 make button icons follow a reasonable size and layout
Summary:
with the Plasma style buttons which have an icon look wrong. The icon size is too big and in consecuence the whole button is drawn way too big.
With this patch the icon is set to a standard size and drawn in the button layout, in a way it looks consistent with other button with no icons.

example:

Before path:

{F7270612}

{F7270611}

With patch:

{F7270610}

{F7270609}

BUG: 399952
FIXED-IN: 5.62

Reviewers: #plasma, mart, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23352
2019-08-22 17:28:27 -05:00
l10n daemon script
9a3351fae5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-20 04:58:25 +02:00
David Edmundson
d62e99460a Allow applets/containments/wallpaper to defer UIReadyConstraint
Summary:
This is needed so that we don't remove the splash till the wallpaper is
loaded, but also allows doing this in a generic way.

Version 2 of the patch using a normal property.

We need to have the virtual so that the containment waits for the
wallpaper.

Test Plan:
Used with wallpaper patch
Added debug to ensure it happened after the stackview in the wallpaper
is pushed

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22852
2019-08-19 10:51:30 +01:00
l10n daemon script
56aa6dee3a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-17 05:07:40 +02:00
l10n daemon script
e454afa352 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-16 05:09:03 +02:00
l10n daemon script
dbe0c8ac73 GIT_SILENT Upgrade KF5 version to 5.62.0. 2019-08-11 07:15:53 +00:00
Noah Davis
134b2ac331 Make notification icons look like bells
Summary: BUG: 384015

Test Plan:
See D23018

{F7178298, size=full}

Reviewers: #vdg, #plasma, broulik, ngraham

Reviewed By: #vdg, #plasma, broulik, ngraham

Subscribers: ngraham, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23019
2019-08-09 07:43:42 -06:00
Konstantin Lisin
144bb90715 Fix incorrect initial tabs position for vertical tab bars
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.

BUG: 395390
FIXED-IN: 5.62

Reviewers: #plasma, ngraham, hein

Reviewed By: #plasma, ngraham, hein

Subscribers: kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10047

Differential Revision: https://phabricator.kde.org/D23036
2019-08-08 20:33:19 -06:00
Nate Graham
d186d5421b Revert "Fix incorrect initial tabs position for vertical tab bars"
I committed this patch without the author's attribution, sorry
This reverts commit e2cd97d822.
2019-08-08 20:32:28 -06:00
Nate Graham
e2cd97d822 Fix incorrect initial tabs position for vertical tab bars
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.

BUG: 395390
FIXED-IN: 5.62

Reviewers: #plasma, ngraham, hein

Reviewed By: #plasma, ngraham, hein

Subscribers: kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10047

Differential Revision: https://phabricator.kde.org/D23036
2019-08-08 20:28:15 -06:00