Commit Graph

17 Commits

Author SHA1 Message Date
David Edmundson
0bd2ea178f Add test for buttons with icon height 2019-05-13 09:54:44 +01:00
David Edmundson
ee2b12be04 Add extra visual indicator for Checkbox/Radio keyboard focus
Summary:
This draws a line underneath a Plasma checkbox label when it has
keyboard focus. This is needed as when an item is checked, the focus
shadow is practically invisible.

Visuals when clicking is completely unchanged
This brings it more in line with our QStyle.

Test Plan: Attached runtime tests

Reviewers: #plasma, #vdg, mart

Reviewed By: #plasma, mart

Subscribers: plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D7819
2017-09-19 13:50:44 +01:00
Kai Uwe Broulik
21f954d94d [PlasmaComponents Menu] Don't crash on null action
You can assign a QAction as "action", this way you can just pass it e.g. plasmoid.action("configure").
However, when assigning a null action as can happen with kiosk restrictions, it would crash
as it assigns m_action the nullptr but never checks for that.

This patch ensures we always have a QAction, creating a new empty one, if neccessary.
Also deletes our own action if an external one is assigned

Differential Revision: https://phabricator.kde.org/D6608
2017-07-11 12:23:39 +02:00
Kai Uwe Broulik
ceeb57d17f [PlasmaComponents Menu] Add maximumWidth property
This allows to limit the maximum width of a menu. It can be useful for instance
in task manager where long file names for recent documents will result in gigantic menus.

The property has a RESET method (which is called if you assign "undefined") which will
set it back to QWIDGETSIZE_MAX to remove the size restriction.

Differential Revision: https://phabricator.kde.org/D4257
2017-01-25 18:02:33 +01:00
David Edmundson
cb9ec94625 Add an optional reveal password button to TextField
Similar to KPasswordWidget in kwidgetaddons

Also fixes:
- the clear button still being clickable when not enabled
- RTL icons
- Updating the right margin correctly

REVIEW: 128660
2016-08-15 14:34:15 +01:00
David Edmundson
1a4c1d7eeb Fix Button minimumWidth property
Plasma's Button has an extra property "minimumWidth" which is an extra
hint not in QQC to say "what is the size to exactly fit the contents".

(it's a bit confusing, as we can perfectly handle a button below it's
"minmimum" size)

This should be based on the size the contents want to be (the
implicitWidth), not how small the contents can go (which with is pretty
meaningless when our button can elide)

It got broken at some point recently.

BUG: 353584
Change-Id: I637898c3abf98183bbae30d8f15c4d72801a3650
REVIEW: 125698
2015-10-19 11:30:19 +01:00
David Edmundson
7453beb9ce Use lineedit svg margins in sizeHint calculation
QQC button heights are max(backgroundHeight, label + margins).
QQC lineedits are only from the background

We need to take the margins into consideration when deciding how high
the textbox should be otherwise we're effectively just ignoring what the
SVG says.

This means button and textbox on the login screen are now the same
height.

REVIEW: 125240
2015-09-16 23:56:39 +01:00
David Edmundson
d6e5d81a59 Make more tests for button with descriptions
Change-Id: I6d1d2be97bac4b6f6b1deebc6e5654a303ba150e
2015-09-12 22:40:18 +02:00
Kai Uwe Broulik
93cf07deac Add support for menu sections
Also adds a manual unit test

CHANGELOG: PlasmaComponents.Menu now supports sections
REVIEW: 123537
2015-04-27 22:19:41 +02:00
David Edmundson
c546f314be Use the same text colour for comboboxes as buttons
Given comboboxes use the same background as buttons they should use the
same text colour too.

This prevents a situation in Breeze where a ComboBox could get white
text on a white background when using a colourscope with complementary
colours.

Change-Id: I21502186178a32ce480cd3e838335451bf644c3e
2014-12-11 15:06:54 +01:00
Kai Uwe Broulik
ca78cfa094 Make ProgressBar test cover the 1% case where the FrameSVG used to leak outside 2014-11-10 22:13:41 +01:00
Kai Uwe Broulik
f54ff55bc5 Migrate ProgressBar to QtQuick.Controls
Test is enhanced to also cover vertical bars. The ProgressBar does not yet use
the vertical assets since Qt just conveniently rotates the bar for us and
apparently just overriding the entire "panel" component is evil

REVIEW: 121085
2014-11-10 22:09:55 +01:00
Kai Uwe Broulik
65a6861476 Migrate BusyIndicator to QtQuick.Controls
Comes with a test for the seamless pause/resume

REVIEW: 121070
2014-11-09 01:16:30 +01:00
Kai Uwe Broulik
759b75314d Add indeterminate ProgressBar to test
REVIEW: 120491
2014-10-04 22:40:27 +02:00
David Edmundson
094a1c105d Add testcase for textfield
Change-Id: I579ab98a86e674cd1d6bd6c43c9c369259536248
2014-10-02 15:31:34 +02:00
David Edmundson
489ca7b76a Test progress bars
Change-Id: Iab1be67dc4ab059ab85ba2833df0da80775ed61f
2014-09-26 17:37:53 +02:00
David Edmundson
40fbd5f13c Add component tests
The rationale is to build simple tests which cover most combos of
components

Change-Id: I771a511eb3589c3815600697a800d4250e50175d
2014-09-25 12:37:44 +02:00