360 Commits

Author SHA1 Message Date
Marco Martin
11b2da667d fix logic of install/remove eventfilter 2014-08-07 13:28:37 +02:00
Marco Martin
1baddcc004 port plasma1 popupapplet event filter logic
use an event filter to open popup menus inside popups.
requires a recent 5.3 revision and a small change in the shell package
2014-08-06 19:45:31 +02:00
Marco Martin
120132879a contextualActionsAboutToShow signal
emitted just before showing a context menu
gives the plasmoid the time to fiddle with the actions beforehand
reviewd by:Eike Hein
BUG:337959
2014-08-06 11:43:55 +02:00
Marco Martin
80516dbef0 framework part of the applet alternatives chooser
this is the little part in plasma-framework for the applet alternatives chooser.
works together the branch mart/alternativesConfig of plasma-workspace and plsma-desktop.
for how it looks and why, see the vdg forum thread:
https://forum.kde.org/viewtopic.php?f=285&t=122067&p=315919#p315919

still possible problems:

I'm not sure about using a new desktop file entry X-Plasma-Provides, maybe Categories could be enough, but it may produce many false positives as well

REVIEW:119409
2014-07-23 12:25:32 +02:00
David Edmundson
a0bd7c9c14 Revert "Do not leak toolbox items"
This reverts commit 5e9fc425c62e1bc5ff1cab5b03214ef78f61bf04.
2014-07-17 21:12:16 +02:00
David Edmundson
1f7951d873 Revert "Setting parent on toolbox causes problems. Instead delete via connection"
This reverts commit c38e6a204e66a2fca2f9f0606475731b5c6bf0d1.

This causes problems on the panel toolbox.
We were already trying to set a parent; however as it's a property of a QQuickItem
it only changes the visual parent; kdeclarative has a code path that if there's
a visual parent to skip the memory management; bug is probably there instead.
2014-07-17 21:08:02 +02:00
David Edmundson
c38e6a204e Setting parent on toolbox causes problems. Instead delete via connection
Reviewed-by: Eike Hein
2014-07-17 20:36:02 +02:00
David Edmundson
5e9fc425c6 Do not leak toolbox items
Finally found the cause of the items QML_LEAK_CHECK warns of.

BUG:336561
REVIEW: 119343
2014-07-17 18:50:05 +02:00
l10n daemon script
f7208d7d21 SVN_SILENT made messages (.desktop file) 2014-07-17 08:59:54 +00:00
David Edmundson
9b0d414e57 Fix minor memory leak in Wallpaper interface
REVIEW: 119316
2014-07-16 15:40:00 +02:00
Marco Martin
c2284cb48e connect(QPoineter breaks on some gcc versions
please, use connect(QPointer.data(), for time to come
2014-07-11 10:49:25 +02:00
Aleix Pol
d1e24d19fb fix build on jenkins
for some reason it works here...
2014-07-10 20:28:19 +02:00
Aleix Pol
f75eb2d984 Don't connect to signals until the class has been initialized
While profiling plasmashell memory usage with Vishesh we realized that most
of the usage came from loading the Background image repeatedly.

We traced it back to this change, where we were connecting to
wallpaperChanged before initializing it, so it would initialize it again,
loading the wallpaper twice. It's not that we were leaking the object,
AFAIK, but loading an image using QQuickImage already raises the memory
quite a bit.

This change alone reduces by 15% the memory usage of my plasmashell (with 2
screens, that makes it a bit worse, because there's 2 DesktopViews then).

REVIEW: 119216
2014-07-10 19:53:03 +02:00
l10n daemon script
8afadc6410 SVN_SILENT made messages (.desktop file) 2014-07-10 04:23:58 +00:00
l10n daemon script
ee230c4d21 SVN_SILENT made messages (.desktop file) 2014-07-09 03:37:24 +00:00
Marco Martin
9218543b65 QCoreApplication::closingDown() becomes true too late
restore the disconnect: sometimes appletRemovedForward gets executed after
aboutToQuit is emitted, but before closingDown returns true
this prevents configuration to be forgotten
2014-07-08 12:49:04 +02:00
Marco Martin
a5ecb2e0ff fix a crash sometimes happening on close
the problem is that sometimes when QCoreApplication::aboutToQuit the containment is already deleted (the order is not really deterministic), therefore appletScript::applet() will hit an assert.
using a qpointer should solve it, its data being already 0ed in the cases the containment is already deleted at :aboutToquit time.
2014-07-08 11:04:05 +02:00
Marco Martin
0dba9044bf actions() returns the complete list
the disabled/invisible actions already have it as properties.
this fixes the add widgets action sometimes not being available
in the toolbox
Reviewed by: Bhushan Shah <bhush94@gmail.com>
2014-07-07 19:36:30 +02:00
l10n daemon script
29908f145a SVN_SILENT made messages (.desktop file) 2014-07-01 12:38:20 +00:00
l10n daemon script
b06bb52100 SVN_SILENT made messages (.desktop file) 2014-06-29 08:42:52 +00:00
Marco Martin
e09a2eb44a check pointer validity, crash--
even if that code path shouldn't be hit, always better avoiding a crash
(proper fix coming)
CCBUG:336491
2014-06-23 14:50:06 +02:00
l10n daemon script
ac4f519188 SVN_SILENT made messages (.desktop file) 2014-06-23 08:35:39 +00:00
Marco Martin
55b5e815b5 ignore inactive containment in containmentAt
Reviewed by: Bhushan Shah <bhush94@gmail.com>
BUG:336168
2014-06-20 17:32:36 +02:00
Aleix Pol
97cf403288 Reduce Applet::containment calls
It's not a cheap call, and there's no need to re-calculate it every time.
2014-06-17 16:02:43 +02:00
Marco Martin
34226faec1 one occasion less to crash
(on debug builds an assert is still possible)
2014-06-17 11:49:23 +02:00
l10n daemon script
b092bbed31 SVN_SILENT made messages (.desktop file) 2014-06-12 08:31:04 +00:00
Aleix Pol
8ab91f219d Expose the screenGeometry on the applet interface
It's useful to be able to figure out information about the current screen
without having to ask the corona.
2014-06-05 15:24:26 +02:00
Marco Martin
9d1727a1a4 Plasma1 behavior: no remove action in panels
the remove context menu for applets is only visible when the panel controller is open
less accidental removal
2014-06-03 16:35:01 +02:00
Marco Martin
223fe9b431 stop forwarding appletRemoved on application close
the containment must not save geometries without the applets that are being deleted

BUG:335742
2014-06-03 11:59:57 +02:00
l10n daemon script
9e45440ae7 SVN_SILENT made messages (.desktop file) 2014-05-29 08:11:19 +00:00
l10n daemon script
fd1674450e SVN_SILENT made messages (.desktop file) 2014-05-25 08:47:48 +00:00
l10n daemon script
2ba1a0c90f SVN_SILENT made messages (.desktop file) 2014-05-23 08:16:11 +00:00
l10n daemon script
db8da9ff8d SVN_SILENT made messages (.desktop file) 2014-05-20 10:48:03 +00:00
Aleix Pol
35d1dd2d65 Don't try to delete null objects
Fixes a warning in Qt and makes sense of what the code it's actually doing.
At least it was not crashing!
2014-05-16 03:08:11 +02:00
l10n daemon script
1b3060649c SVN_SILENT made messages (.desktop file) 2014-05-14 08:29:33 +00:00
Aleix Pol
da190fa711 Reduce calls to ShellCorona::screenForContainment
Just store some values instead of calling repeatedly without reason.
2014-05-13 14:15:46 +02:00
Aleix Pol
cc661dfdd6 Save some calls to ShellCorona::screenGeometry
It's not an especially cheap function and it didn't make sense doing
it twice
2014-05-13 14:03:46 +02:00
Marco Martin
3f516ddda6 adapt api change 2014-05-13 13:45:32 +02:00
Marco Martin
34b86471d0 fix screen region mapping
BUG:334670
2014-05-13 13:42:44 +02:00
Marco Martin
55514d28c7 Merge branch 'mart/plasmoidMove' 2014-05-13 12:47:49 +02:00
Marco Martin
64cff59a31 api to add an existing applet and position mapping 2014-05-13 12:46:17 +02:00
Marco Martin
cdb9c8c1cc addApplet function
offers a crude support to applet migration between containments
2014-05-12 21:07:41 +02:00
Marco Martin
895c5b6b2b close the menu if it was already open
sometimes on plasma start, other context events may be triggered
while the menu is in its exec(), byt the qqmlincubator.
if so, close the already existing menu.

BUG:334562
2014-05-12 11:02:56 +02:00
Marco Martin
97831b616f experim API to move plamoids between containments 2014-05-09 18:43:33 +02:00
Marco Martin
759036e19f remove dead code 2014-05-09 14:24:05 +02:00
Marco Martin
ea3544deb7 remove unused function 2014-05-09 14:21:23 +02:00
Marco Martin
53893e8d0b make the toolbox directly child of containmentinterface 2014-05-07 20:27:51 +02:00
Marco Martin
f21851548c new api for availablescreensize/region 2014-05-07 15:18:21 +02:00
Eike Hein
1805bb7496 Make sure the args part of Containment::createApplet(..., args) ends up in the applet. 2014-05-06 20:52:42 +02:00
Aleix Pol
556c1e321a Remove random qDebug output
Makes it easier to spot the actual problems on the output. If there's
something that's actually indicating a problem, we should make it a
qWarning.
2014-05-06 19:57:37 +02:00