Commit Graph

4 Commits

Author SHA1 Message Date
David Edmundson
1a4c1d7eeb Fix Button minimumWidth property
Plasma's Button has an extra property "minimumWidth" which is an extra
hint not in QQC to say "what is the size to exactly fit the contents".

(it's a bit confusing, as we can perfectly handle a button below it's
"minmimum" size)

This should be based on the size the contents want to be (the
implicitWidth), not how small the contents can go (which with is pretty
meaningless when our button can elide)

It got broken at some point recently.

BUG: 353584
Change-Id: I637898c3abf98183bbae30d8f15c4d72801a3650
REVIEW: 125698
2015-10-19 11:30:19 +01:00
David Edmundson
7453beb9ce Use lineedit svg margins in sizeHint calculation
QQC button heights are max(backgroundHeight, label + margins).
QQC lineedits are only from the background

We need to take the margins into consideration when deciding how high
the textbox should be otherwise we're effectively just ignoring what the
SVG says.

This means button and textbox on the login screen are now the same
height.

REVIEW: 125240
2015-09-16 23:56:39 +01:00
David Edmundson
d6e5d81a59 Make more tests for button with descriptions
Change-Id: I6d1d2be97bac4b6f6b1deebc6e5654a303ba150e
2015-09-12 22:40:18 +02:00
David Edmundson
40fbd5f13c Add component tests
The rationale is to build simple tests which cover most combos of
components

Change-Id: I771a511eb3589c3815600697a800d4250e50175d
2014-09-25 12:37:44 +02:00