Commit Graph

56 Commits

Author SHA1 Message Date
Alex Merry
4e1a2de897 Fix memory leak.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=851434
2008-08-23 16:37:04 +00:00
Marijn Kruisselbrink
21b148b963 change all ClassName::Private classes to ClassNamePrivate, and adjust friends accordingly; this makes plasma compilable with gcc < 4.2
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=826893
2008-07-01 18:56:43 +00:00
Aaron J. Seigo
32705801ba SVN_SILENT: ws microfix that's sitting on my hd wanting me to commit it so i don't keep seeing it in svn stat
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=820382
2008-06-14 01:30:39 +00:00
Mark Kretschmann
6406af5f58 Proper fix for the mutex issue, using K_GLOBAL_STATIC.
Thanks to dfaure and ervin for helping.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=814552
2008-05-30 17:04:05 +00:00
Mark Kretschmann
b98775d66f Change bigLock QMutex from static to nonstatic. This fixes a nasty bug that caused Amarok to hang on exit.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=814540
2008-05-30 16:13:57 +00:00
Aaron J. Seigo
fb80125034 changes to allow integration with kpluginselector; based on patch by Ryan Bitanga
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809860
2008-05-19 17:02:15 +00:00
Dan Meltzer
f57cc1c623 Lotsa little ebn fixes.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=805672
2008-05-09 05:32:15 +00:00
Aaron J. Seigo
6019dc7b27 huge patch, but it's needed to avoid crashes and i can't wait on other people's pending work forever. so...
QueryMatch by value! shared dptr == no copy of data either! so (nearly) all the speed love of pointers with none of the crash hate. woo!

RunnerContext also by value! die pointers die!

also get rid of tons of locking that just doesn't make sense anymore; get rid of data priority enum as well since it's completely meaningless.

speed, glory, stability! ftw!

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=805661
2008-05-09 03:49:11 +00:00
Aaron J. Seigo
6ea602b848 make RunnerManager a friend so we can do the happy-scripting-dance again
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=804739
2008-05-06 20:48:44 +00:00
Aaron J. Seigo
e2ec9b03db * get rid of Plasma-RunnerName; use Name and KPluginInfo's pluginName instead
* add AbstractRunner::id()
* add QueryMatch::id()

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=804670
2008-05-06 18:43:55 +00:00
Aaron J. Seigo
f3188fb672 SearchMatch -> QueryMatch
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=803385
2008-05-02 18:46:05 +00:00
Aaron J. Seigo
f55bbb73f9 SearchContext -> RunnerContext
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=803041
2008-05-01 18:40:10 +00:00
Jordi Polo
95157e20c4 Big patch with several internal changes to krunner:
-New RunnerManager class, it manages runners at high level 
and gives a simple API for interfaces to use. 
- AbstractRunners gains description, setIgnoredTypes, ignoredTypes methods. 
Now runners can specify what SearchContext::Types they are not going to process.
- SearchContext tries shared data between the original context and any local context.
It doesn't have its own completer no more.
- SearchMatch has a new type of match, CompleterMatch. Instead of using a hard coded 
completer in SearchContext
- Interface class on krunner has its own completer and other changes
done to accomodate the above changes in libplasma.
-A new configuration option blacklist for runnermanager and krunner 
instead of the whitelist of krunner. 


svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802903
2008-05-01 07:51:59 +00:00
Aaron J. Seigo
9165b11235 at tokamak i said i regretted using the term "Language" to describe what is really "API". i meant it.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802486
2008-04-29 16:24:14 +00:00
Davide Bettio
c32f8a4511 Replacing exec() with run(): this change wasn't discussed during the tokamak meeting.
run() method is more obvious than exec() (don't forget that a runner run :) ).
Anyway during the meeting we have decided to replace createMatchOptions() with createRunOptions()
and (set)hasMatchOptions() with (set)hasRunOptions(), now with this commit we have a more coherent naming.
CCMAIL: panel-devel@kde.org

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802143
2008-04-28 17:11:12 +00:00
Albert Astals Cid
4068f45cf9 const & in foreach
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801430
2008-04-26 16:19:00 +00:00
Davide Bettio
5ad0e12cdd API REVIEW: load() -> loadAll()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801377
2008-04-26 13:10:37 +00:00
Davide Bettio
444c2f6b49 API REVIEW: createMatchOptions() -> createRunOptions()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801372
2008-04-26 12:54:25 +00:00
Davide Bettio
e576ed397b API REVIEW: (set)hasMatchOptions -> (set)hasRunOptions()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801367
2008-04-26 12:41:16 +00:00
Davide Bettio
451dc3b8cd API REVIEW: runnerName() -> name()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801360
2008-04-26 12:20:29 +00:00
Davide Bettio
8418bb6fc7 addMatchesTo() -> moveMatchesTo() (move is better than copy)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800650
2008-04-24 15:37:12 +00:00
Aaron J. Seigo
637515f2a9 changes that were lost in the merge
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=796407
2008-04-13 14:37:10 +00:00
Alexis Ménard
4467261c95 Merge woc branch to trunk, say good bye to old plasma, there is a lot of stuff to port
applets, 
please update to another revision to use the version that works

green flag from aaron


svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=796368
2008-04-13 13:23:39 +00:00
Aaron J. Seigo
40866fc443 implement package support
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=796112
2008-04-12 16:00:43 +00:00
Aaron J. Seigo
7cf7109266 load* -> load .. simpler, less verbose API
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=779407
2008-02-26 01:58:55 +00:00
Aaron J. Seigo
b6767e1e39 we need a non-const object to lock, may as well make it a pointer as well since that's the common usage
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=776952
2008-02-19 06:27:31 +00:00
Aaron J. Seigo
2954087e8d * eliminate the three search lists and have just one
* remove add*Match since they broke the pattern of usage (who owns the match? do you have to add it again? etc..)
* add addMatch to compliment addMatches for those runners that just ever have one match
* make the default SearchMatch type Possible rather than Exact (making Exact and Informational the exceptions, which matches usage patterns)
* const'ify the API a bit better

generally more performant, lower memory usage and clearer API having seen what is beign done in the runners. also makes it a bit easier to turn the Matches into a qt model

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=776931
2008-02-19 03:59:21 +00:00
Aaron J. Seigo
123623d675 We make a thread-local copy of the SearchContext for each Runner. As such, there is no need to do locking on the thread-local copy. This patch also adds assertions on the non-thread safe methods (e.g. addExactMatch) which are used from thread-local copies, but which should never be used in the shared version.
Also adds a addMatchesTo(SearchContext) which encapsulates this code and makes it safe to delete matches on object deletion, preventing possible memory leaks on SearchContext destruction.

Finally, don't copy all the SearchMatches already registered for each thread-local copy as that's just unused and unecessary overhead.

BIC, though SC.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=773473
2008-02-11 06:04:20 +00:00
Aaron J. Seigo
4ebb5fcaeb automatic rate limiting of runners: mark ill performing runners as slow, but let speed runners marked as slow back into the main thread pool.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=772741
2008-02-09 14:59:43 +00:00
Aaron J. Seigo
5f0afdd61c * prevent potential crash introduced with scripting support (non-init'd AbstractRunner*)
* get the args right

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=772449
2008-02-08 19:21:25 +00:00
Aaron J. Seigo
9244e126f2 seems that priority has taken over what tier was intended for; easy to add back if necessary / desired, but i think that the idea of chaining really needs more expresivity than that
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=771458
2008-02-06 02:51:21 +00:00
Aaron J. Seigo
e3c3b847f6 provide a bigLock() for runners to use whenever accessing common but non-reentrant api (e.g. most everything in kdelibs ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=770952
2008-02-04 20:28:09 +00:00
Petri Damstén
8a15088888 Scripting update.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=770587
2008-02-04 04:41:40 +00:00
Aaron J. Seigo
55eb91140b some improvements as suggested by mattr via review-board. boy, what a neat tool
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=768467
2008-01-30 06:17:13 +00:00
Aaron J. Seigo
099785fbdc let's see if serializing (via a mutex) access to kservicetypetrader helps with those kservicetypetrader related crashes i'm seeing constantly go away
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=768454
2008-01-30 03:41:36 +00:00
Aaron J. Seigo
ee32d3c996 remove the use of 1209 explicitly now that i have Winter's Magic Formula for default debug space. makes backporting way easier; sorry for the noise of the earlier commit. suppose i should read planetkde.org more closely ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=758498
2008-01-08 01:25:09 +00:00
Ryan P. Bitanga
3328d293ae Give runners priority levels
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=758482
2008-01-08 00:21:10 +00:00
Aaron J. Seigo
12ef6308cb use the plasma debug area (1209); i considered wrapping this in Plasma::debug() but that seems overkill ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=758415
2008-01-07 20:50:31 +00:00
Aaron J. Seigo
5a44fae20f hush the compiler
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=747406
2007-12-11 22:30:05 +00:00
Aaron J. Seigo
5fc323b7db provide a place for runners to put their config. no, not overly performant but this really shouldn't need to be
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=747296
2007-12-11 16:53:40 +00:00
Ryan P. Bitanga
f1df93c794 Add runner speed functions to abstractrunner
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=746915
2007-12-10 16:20:46 +00:00
Aaron J. Seigo
cfd3bfac48 * SearchAction becomes SearchMatch; fall out of the refactoring
* add camel case headers for those classes now that they've settled in

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=744452
2007-12-03 17:18:28 +00:00
Ryan P. Bitanga
eff8326f80 Say hello to multithreaded krunner ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=743865
2007-12-02 07:11:50 +00:00
Ryan P. Bitanga
72a3b2b68b Add a whitelist to loadRunners, change canBeConfigured to isConfigurable
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=739989
2007-11-22 09:08:58 +00:00
Aaron J. Seigo
0a6f2af7f3 * move SearchAction and SearchContext to their own files
* term -> searchTerm
* add a completion object to SearchContext

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=731848
2007-11-02 02:34:46 +00:00
Aaron J. Seigo
82302e817b actually allow runns to provide their config ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=731262
2007-10-31 05:25:07 +00:00
Aaron J. Seigo
e099821b71 massive change to AbstractRunner API, but now at least it is hopefully future proof and we won't have to change it in BIC ways after 4.0
introduces two new classes: Plasma::SearchContext and Plasma::SearchAction

benefits include:
 - well, future proofing =)
 - the ability to eventually allow runners that mutate the search
 - multiple exact matches per runner
 - 'executing' of informational runners (useful for, e.g., the calculator)
 - being able to centralize expensive operations such a KUriFilter actions
 - simplifies writing runners *dramatically*

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=731253
2007-10-31 04:44:09 +00:00
Aaron J. Seigo
ff935b47f5 * KRunner/Runner -> Plasma/Runner as it is actually hosted by libplasma
* move the service description .desktop file into libs/plasma/servicetypes with the rest of them
* add a X-Plasma-RunnerPhase property so we can try and order these puppies

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=723217
2007-10-09 03:20:02 +00:00
Andreas Pakulat
70f0a9f9be Merge the KConfig branch. This are the 3 main modules (+kdeadmin), which are
needed now because friday is the last BC day. The rest of the modules will
follow as fast as my laptop allows.

svn path=/trunk/KDE/kdelibs/; revision=721704
2007-10-05 22:21:25 +00:00
Aaron J. Seigo
06465f6cb1 more deprecated api removal; kservice seems almost OO now ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=717491
2007-09-26 23:06:17 +00:00