Commit Graph

15288 Commits

Author SHA1 Message Date
Kevin Funk
d13f9e6f85 ASAN: Fix memory leak in Corona
KPackagePrivate::internalPackage already existed, the re-assignment to a
new value causes a memory leak.

Trace:
Indirect leak of 112 byte(s) in 1 object(s) allocated from:
    #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
    #1 0x7f905829163f in KPackage::Package::Package(KPackage::PackageStructure*) /home/kfunk/devel/src/kf5/kpackage/src/kpackage/package.cpp:51:9
    #2 0x7f9058fad786 in Plasma::Package::Package(Plasma::PackageStructure*) /home/kfunk/devel/src/kf5/plasma-framework/src/plasma/package.cpp:66:34
    #3 0x7f9058f14dee in Plasma::Corona::package() const /home/kfunk/devel/src/kf5/plasma-framework/src/plasma/corona.cpp:78:13
    #4 0x5d9eb9 in ShellCorona::ShellCorona(QObject*) /home/kfunk/devel/src/kf5/plasma-workspace/shell/shellcorona.cpp:132:70
    #5 0x65c31d in ShellManager::loadHandlers() /home/kfunk/devel/src/kf5/plasma-workspace/shell/shellmanager.cpp:93:21
2018-11-20 15:15:42 +01:00
Kevin Funk
e3eafabd55 ASAN: Fix leak in AppletQuickItem
Direct leak of 3960 byte(s) in 15 object(s) allocated from:
    #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
    #1 0x7f0dd8a3e2bd in PlasmaQuick::AppletQuickItem::AppletQuickItem(Plasma::Applet*, QQuickItem*) /home/kfunk/devel/src/kf5/plasma-framework/src/plasmaquick/appletquickitem.cpp:472:9
    #2 0x7f0dcb7b365b in AppletInterface::AppletInterface(DeclarativeAppletScript*, QList<QVariant> const&, QQuickItem*) /home/kfunk/devel/src/kf5/plasma-framework/src/scriptengines/qml/plasmoid/appletinterface.cpp:50:7
    #3 0x7f0dcb7aede1 in DeclarativeAppletScript::init() /home/kfunk/devel/src/kf5/plasma-framework/src/scriptengines/qml/plasmoid/declarativeappletscript.cpp:87:27
    ...
2018-11-20 15:15:42 +01:00
l10n daemon script
044d3472c2 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-11-20 05:36:28 +01:00
Kai Uwe Broulik
38098e96e3 Remove ComponentInstaller
When a dataengine failed to load it would ask PackageKit to install it but it's generally not how we want to distribute
plasmoid infrastructure these days and didn't work.

Differential Revision: https://phabricator.kde.org/D16301
2018-11-19 12:53:31 +01:00
Albert Astals Cid
e6f6bf9624 Qt 5.9 is now the minimum required version 2018-11-17 11:24:51 +01:00
Albert Astals Cid
6d6e1bfee9 GIT_SILENT Upgrade Qt5 version requirement to 5.9.0. 2018-11-17 11:21:39 +01:00
Luca Beltrame
17c8927748
Add back (accidentally?) deleted line in CMakeLists.txt
Without this, ToolButton.qml (Plasma Components 3) is not installed and
applets like the mediacontroller do not load because they can't find it.

The line has been removed in 6126954816,
and it looks like an unrelated change.

Marco, feel free to revert if the proper solution is different.

CCMAIL: notmart@gmail.com
2018-11-14 23:41:59 +01:00
Marco Martin
02d5c8a19f 100% consistency with kirigami heading sizing
reviewed-by: VDG and Nate
2018-11-13 14:34:00 +01:00
Marco Martin
b34b92346f more homogeneous look with Kirigami headings
tries harder to make the text weight light
2018-11-13 13:14:24 +01:00
Marco Martin
6126954816 install the processed version of private imports 2018-11-13 12:37:26 +01:00
Marco Martin
513923f7b5 Mobile text selection controls
Summary:
in QQC2 the text selection controls depend upon the style, which has to
implement it by itself
this adds touch based draggable cursor and text selection handles,
alongside a tiny toolbar for cut/copy/paste

the desktop style will need the exact same thing
T10023

Test Plan:
works correctly when in tablet mode, none of this is visible
when in desktop mode where the text fields behave normally

Reviewers: #plasma, bshah

Reviewed By: #plasma, bshah

Subscribers: ngraham, abetts, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16841
2018-11-12 17:45:10 +01:00
Noah Davis
2c0ba9826f Update breeze-light and breeze-dark colorschemes
Summary: The current colorschemes included in the breeze-light and breeze-dark Plasma themes do not match the Breeze and BreezeDark colorschemes in the breeze repo. For instance, the breeze-dark Plasma theme used an ugly yellow-green for ForegroundNeutral instead of Beware Orange like in the Breeze and BreezeDark colorschemes. It also used a much harsher red that looked inconsistent with BreezeDark. I've been using the new colorschemes for the past month and the most noticeable changes are just the new orange and red colors.

Test Plan:
Old:
{F6411526, size=full}
{F6411527, size=full}
{F6411875, size=full}
{F6411889, size=full}
New:
{F6411523, size=full}
{F6411525, size=full}
{F6411883, size=full}
{F6411898, size=full}

Reviewers: #vdg, #breeze, #plasma, mart, ngraham

Reviewed By: #vdg, #breeze, #plasma, mart, ngraham

Subscribers: ngraham, mart, broulik, #vdg, kde-frameworks-devel

Tags: #frameworks, #vdg, #breeze, #plasma

Differential Revision: https://phabricator.kde.org/D16810
2018-11-12 10:01:09 -05:00
Aleix Pol
069acf600c Make sure private header fields are initialized 2018-11-12 03:11:25 +01:00
l10n daemon script
214b2790ca GIT_SILENT Upgrade KF5 version to 5.53.0. 2018-11-10 08:59:21 +00:00
José Manuel Santamaría Lema
ed1724c63e Summary:
After this commit
https://cgit.kde.org/plasma-framework.git/commit/?id=9f08668147d2e99f8b5069ff50d5c54e672a87af
the iconitemtest started to fail, the reason was just a typo in the initial
"if" so it does exactly the same in the "if" and the "else" part. So let's
correct it to do what it is suposed to do.

Test Plan: Ran test

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16733
2018-11-08 16:23:20 +01:00
Aleix Pol
768b0882e9 remove unneeded include 2018-11-07 02:45:47 +01:00
Laurent Montel
cbd5abf787 Remove qt include prefixx 2018-11-06 07:23:52 +01:00
l10n daemon script
fbfd3b9591 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.52.0 release. 2018-11-03 12:03:07 +00:00
Albert Astals Cid
9b53406f23 Remove unused variables
Reviewers: apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16575
2018-11-03 01:34:40 +01:00
l10n daemon script
3e4dbde6b0 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-24 05:58:03 +02:00
Marco Martin
a1269ad059 revert icons scaling on mobile
plasma mobile can't handle that
2018-10-23 12:18:26 +02:00
Yuri Chornoivan
72ca2f79e0 Fix minor EBN issues and typos 2018-10-22 21:05:29 +03:00
Marco Martin
9b6c2cddc7 upport mnemonic labels 2018-10-19 13:43:17 +02:00
Kai Uwe Broulik
e92ed94d9d Remove PLASMA_NO_KIO option
It is a remnant of the Plasma Active days and didn't even compile.
This patch only removes those ifdefs, it doesn't fix any issues I found during (e.g. double lookups or the fact
that KRun::autoDelete is the default now)

Differential Revision: https://phabricator.kde.org/D16295
2018-10-18 16:44:27 +02:00
Marco Martin
21cd448c38 proper color group for icons 2018-10-17 17:57:32 +02:00
Marco Martin
584f7709e1 center text when no icon 2018-10-17 17:54:41 +02:00
Marco Martin
828ab59eb1 smaller dots 2018-10-17 13:42:44 +02:00
l10n daemon script
f8565a19c9 GIT_SILENT Upgrade KF5 version to 5.52.0. 2018-10-15 08:23:53 +00:00
l10n daemon script
a600ff9aa0 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-15 05:39:14 +02:00
Aleix Pol
d9b907e953 Reduce double and triple lookups to the frames hash
Test Plan: Everything runs, tests pass

Reviewers: #plasma, davidedmundson, broulik

Reviewed By: #plasma, davidedmundson, broulik

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16060
2018-10-11 17:27:02 +02:00
l10n daemon script
4b7bac26cc SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-10 06:27:59 +02:00
Aleix Pol
0698c65a83 No point in including an empty foreach when NDEBUG isn't defined 2018-10-09 01:20:10 +02:00
Aleix Pol
8c18054a0d Properly look for fallback themes
Summary:
At the moment we always look at the first fallback and load the original
theme again, rendering moot the fallback look-up.

Reviewers: #plasma, davidedmundson, hein

Reviewed By: #plasma, davidedmundson, hein

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15970
2018-10-09 01:19:55 +02:00
l10n daemon script
f4ffdd8f3f GIT_SILENT Upgrade ECM and KF5 version requirements for 5.51.0 release. 2018-10-07 10:10:56 +00:00
Nathaniel Graham
6f01e8d105 Bump theme version strings because there are new icons in 5.51 2018-10-03 08:30:12 -06:00
Marco Martin
64c5bfae65 add missing PageIndicator 2018-09-28 13:17:58 +02:00
Marco Martin
df6115193b better sizing for roundbutton
use tabletmode for hoverenabled
2018-09-28 13:05:43 +02:00
Kai Uwe Broulik
ea6cf10f42 Also raise configuration window when reusing it
It seems requestActivate only implies unminimizing but not raising if already visible

Differential Revision: https://phabricator.kde.org/D15705
2018-09-27 13:20:34 +02:00
Marco Martin
f6008dafc4 follow colorscope 2018-09-24 18:13:50 +02:00
Marco Martin
938b9cc1a1 no hover effects on mobile 2018-09-24 17:58:51 +02:00
Marco Martin
ff04bf0214 Revert "add a "preview" file definition for widgetexplorer"
This reverts commit 2c07878237.
2018-09-19 15:55:26 +02:00
Marco Martin
ba3e94aa7f slightly translucent when disabled 2018-09-19 15:54:20 +02:00
Marco Martin
9f08668147 Add missing component: RoundButton 2018-09-19 15:48:27 +02:00
Marco Martin
2c07878237 add a "preview" file definition for widgetexplorer 2018-09-18 17:51:59 +02:00
Laurent Montel
4c229713b7 Remove this line 2018-09-18 06:57:24 +02:00
Friedrich W. H. Kossebau
53a2960353 Avoid potential detach on range-loops with non-const Qt containers
Seen by clazy range-loop
2018-09-18 01:11:28 +02:00
l10n daemon script
a73ac63ace SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-15 05:56:48 +02:00
Phil Stefan
32e0f78677 Combine display OSD icon files and move to plasma icon theme
Summary:
Move the icons from D10937 to plasma-frameworks and combine all the sizes

BUG: 395714

Test Plan: "osd-shutd-screen.svg" does not display correctly for me. I can't find any difference between it and the rest of the icons. Help appreciated.

Reviewers: ngraham, #vdg, broulik

Reviewed By: ngraham, #vdg, broulik

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D14971
2018-09-12 08:04:49 -06:00
l10n daemon script
269113d31c GIT_SILENT Upgrade KF5 version to 5.51.0. 2018-09-08 09:10:35 +00:00
l10n daemon script
6e7239b3b1 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-08 06:12:26 +02:00