Commit Graph

15454 Commits

Author SHA1 Message Date
David Faure
b466a2a211 Port away from deprecated methods in Qt 5.14
Test Plan: Builds with -DQT_DISABLE_DEPRECATED_BEFORE=0x060000 (as of today)

Reviewers: davidedmundson, broulik, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23970
2019-09-16 05:40:34 +02:00
l10n daemon script
1a8cfcd585 GIT_SILENT Upgrade KF5 version to 5.63.0. 2019-09-14 11:42:40 +00:00
David Edmundson
4ecdbe9622 Add manual tests for PC3
Summary:
These were super useful for spotting bugs in PC2.
They show many many issues already.

Visually they should match PC2. They don't

Some API doesn't map directly. Those tests
were removed.

Test Plan:
Opened in qmlscene
Everything binds correctly. Some things look horrible.

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23827
2019-09-11 11:11:47 +02:00
Laurent Montel
d60831d650 Port from delta(); to angleDelta().y(); 2019-09-09 18:52:11 +02:00
Björn Feber
fb18347e4d Change reveal password button logic
Summary:
Indicate state, not the action it will have. When the password field is empty it feels like the password will be shown once I start typing. Dolphin has been doing it this way for the "show hidden files" action forever.
Also only show the button when the field contains text or when revealing the password, like in the PolKit dialog.

Test Plan:
Empty field
{F7326288}

{F5697017}
{F5697018}

Dolphin
Show hidden files, files are currently hidden
{F5697031}
Hide hidden files, files are currently shown
{F5697032}

Reviewers: #plasma, #vdg, ngraham, broulik, ndavis

Reviewed By: #vdg, ngraham, ndavis

Subscribers: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D10362
2019-09-09 17:48:54 +02:00
Friedrich W. H. Kossebau
c88354e0ed API dox: add missing @since
GIT_SILENT
2019-09-08 23:51:04 +02:00
Friedrich W. H. Kossebau
295059675c API dox: use full signatures for autolink on overloaded methods
GIT_SILENT
2019-09-08 23:50:40 +02:00
Friedrich W. H. Kossebau
3b6d9de925 API dox: fix name of item class
GIT_SILENT
2019-09-08 23:43:33 +02:00
Friedrich W. H. Kossebau
f31e4d95fd API dox: use @li for proper list
GIT_SILENT
2019-09-08 23:42:11 +02:00
Friedrich W. H. Kossebau
8ef47b1323 API dox: fix wrong use of @class
GIT_SILENT
2019-09-08 23:34:30 +02:00
Friedrich W. H. Kossebau
5e09728c1b API dox: use @code/@endcode
GIT_SILENT
2019-09-08 23:33:09 +02:00
David Edmundson
5f746ce1c2 Fix crash on teardown with Applet's ConfigLoader
Summary:
Deleting AppletPrivate will delete the ConfigLoader which will cause a
save, which can trigger a configSaved signal.

I think it is correct that the config might emit a signal just before
closing, and not at fault.

AppletPrivate is deleted by this point, but Applet is not so the
connection is still alive.

When we handle the signal, it goes into a Q_PRIVATE_SLOT that crashes.

This disconnect pattern is already used for guarding self config
changes.

BUG: 411221

Test Plan: kquitapp5 plasmashell, no longer crashes

Reviewers: #plasma, alexeymin

Reviewed By: alexeymin

Subscribers: alexeymin, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23707
2019-09-07 23:19:03 +02:00
l10n daemon script
9d6a24a771 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.62.0 release. 2019-09-07 12:38:57 +00:00
Noah Davis
db7837d5f5 Make notification icons use outline style
Summary: They didn't quite fit in with the filled style

Test Plan:
Old: {F7304467, size=full}

New: {F7304458, size=full}

Testing stylesheets in Plasma Theme Explorer:
{F7304463, size=full}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, filipf, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23627
2019-09-03 11:15:15 -04:00
Aleix Pol
ea88d2aa51 Skip test on wayland
Summary: It's using some API that isn't available

Test Plan: Noise gone

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23587
2019-08-30 18:06:45 +02:00
Aleix Pol
d3b22f8828 Port trivial connects to the new style 2019-08-30 17:26:54 +02:00
Laurent Montel
f53365633c GIT_SILENT: Use QLatin1String in QString::contains etc. Fix replace
usage
2019-08-29 07:25:48 +02:00
Camilo Higuita
069b4e95c1 make the sizing of the toolbuttons more coherent
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height  if those props are set.

Before patch:

{F7274098}

After patch:

{F7274097}

Reviewers: #plasma, mart, ngraham

Reviewed By: #plasma, mart, ngraham

Subscribers: broulik, apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23367
2019-08-28 08:59:32 -05:00
Marco Martin
86021afdf5 Revert "make button icons follow a reasonable size and layout"
This reverts commit f973619116.
2019-08-28 10:43:22 +02:00
Marco Martin
c6c882521f Revert "make the sizing of the toolbuttons more coherent"
This reverts commit 3887f5ec91.
2019-08-28 10:43:09 +02:00
Camilo Higuita
3887f5ec91 make the sizing of the toolbuttons more coherent
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height  if those props are set.

Before patch:

{F7274098}

After patch:

{F7274097}

Reviewers: #plasma, mart, ngraham

Reviewed By: ngraham

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23367
2019-08-23 16:35:37 -05:00
Camilo Higuita
f973619116 make button icons follow a reasonable size and layout
Summary:
with the Plasma style buttons which have an icon look wrong. The icon size is too big and in consecuence the whole button is drawn way too big.
With this patch the icon is set to a standard size and drawn in the button layout, in a way it looks consistent with other button with no icons.

example:

Before path:

{F7270612}

{F7270611}

With patch:

{F7270610}

{F7270609}

BUG: 399952
FIXED-IN: 5.62

Reviewers: #plasma, mart, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23352
2019-08-22 17:28:27 -05:00
l10n daemon script
9a3351fae5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-20 04:58:25 +02:00
David Edmundson
d62e99460a Allow applets/containments/wallpaper to defer UIReadyConstraint
Summary:
This is needed so that we don't remove the splash till the wallpaper is
loaded, but also allows doing this in a generic way.

Version 2 of the patch using a normal property.

We need to have the virtual so that the containment waits for the
wallpaper.

Test Plan:
Used with wallpaper patch
Added debug to ensure it happened after the stackview in the wallpaper
is pushed

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22852
2019-08-19 10:51:30 +01:00
l10n daemon script
56aa6dee3a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-17 05:07:40 +02:00
l10n daemon script
e454afa352 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-16 05:09:03 +02:00
l10n daemon script
dbe0c8ac73 GIT_SILENT Upgrade KF5 version to 5.62.0. 2019-08-11 07:15:53 +00:00
Noah Davis
134b2ac331 Make notification icons look like bells
Summary: BUG: 384015

Test Plan:
See D23018

{F7178298, size=full}

Reviewers: #vdg, #plasma, broulik, ngraham

Reviewed By: #vdg, #plasma, broulik, ngraham

Subscribers: ngraham, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23019
2019-08-09 07:43:42 -06:00
Konstantin Lisin
144bb90715 Fix incorrect initial tabs position for vertical tab bars
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.

BUG: 395390
FIXED-IN: 5.62

Reviewers: #plasma, ngraham, hein

Reviewed By: #plasma, ngraham, hein

Subscribers: kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10047

Differential Revision: https://phabricator.kde.org/D23036
2019-08-08 20:33:19 -06:00
Nate Graham
d186d5421b Revert "Fix incorrect initial tabs position for vertical tab bars"
I committed this patch without the author's attribution, sorry
This reverts commit e2cd97d822.
2019-08-08 20:32:28 -06:00
Nate Graham
e2cd97d822 Fix incorrect initial tabs position for vertical tab bars
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.

BUG: 395390
FIXED-IN: 5.62

Reviewers: #plasma, ngraham, hein

Reviewed By: #plasma, ngraham, hein

Subscribers: kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10047

Differential Revision: https://phabricator.kde.org/D23036
2019-08-08 20:28:15 -06:00
Laurent Montel
4b427e4f03 Add missing include 2019-08-08 13:02:11 +02:00
l10n daemon script
bbad328bc2 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-05 04:45:06 +02:00
l10n daemon script
2ac6999881 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.61.0 release. 2019-08-03 19:36:41 +00:00
Kai Uwe Broulik
1f0215ebc6 [ToolButtonStyle] Use same color group for hovered state
This is a remnant from when we used a full background on hovered ToolButtons
instead of the frame we have now. It broke icon item appearance when hovered
in a custom ColorScope.

Reviewed-By: notmart
2019-08-02 13:29:51 +02:00
l10n daemon script
781d2f6fff SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-07-31 05:13:30 +02:00
David Edmundson
17d49c0bce Handle colors file in fake plasma theme installer 2019-07-25 00:15:30 +01:00
David Edmundson
08a6a4a7cd Install plasma theme into local XDG_DATA_DIR for icon test
Summary: Relevant code is moved from dialognativetest into a header for sharing

Test Plan: Unit test

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22732
2019-07-24 23:53:39 +01:00
Jonah Brüchert
31cd4f8d8e
Apply busy indicator duration change of D22646 to the QQC2 style
Summary:
Match the duration (2 seconds) that was set in D22630.

This style is mainly used by Plasma Mobile, therefore requesting team review from that project as well.

Reviewers: #vdg, #plasma:_mobile, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22720
2019-07-24 21:13:28 +02:00
David Edmundson
af2a7fbf69 Compile package structure plugins into expected subdirectory
Summary: This means they're found by unit tests pre-installation

Test Plan:
Removed installed files
Ran make (but not make install)
ConfigModelTest now passes

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22682
2019-07-24 17:07:29 +01:00
Noah Davis
b0541ffbff Change Highlight to ButtonFocus
Summary: Changed Highlight to Button focus so that these SVGs wouldn't use the same color as the selection background.

Reviewers: #vdg, #plasma, #breeze, ngraham

Reviewed By: #vdg, #breeze, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22670
2019-07-24 03:34:52 -04:00
l10n daemon script
47281f2a64 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-07-24 05:33:26 +02:00
Aleix Pol
04c0ff5cd7 Make sure we compare paths properly 2019-07-23 19:41:05 +02:00
Aleix Pol
72ff860ef0 Fix running the dialognativetest without installing
Reviewed by David Edmundson
2019-07-23 19:38:23 +02:00
Marco Martin
0e859870a9 Search for the plugin of the other plasmoid
Summary:
Some applets use completely the code of another one with the key
X-Plasma-RootPath.
At the moment it doesn't work on applets that have a binary plugin portion
This makes pluginloader load the plugin of the original applet we're using

Test Plan:
an applet that falls back to one that has a binary plugin now works.
ones that fall back to applets without binary plugin still work
normal applets as well

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22675
2019-07-23 11:13:13 +02:00
Nate Graham
28bc0f3ea1 [Busy Indicator] Match duration of QQC2-desktop-style version
Summary: Match the duration (2 seconds) that was set in D22630.

Reviewers: broulik, #vdg

Reviewed By: broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22646
2019-07-22 07:58:17 -06:00
Harald Sitter
a965fa4cb8 remove dangling remote widgets code
Summary:
can't be enabled anywhere + not actually doing anything as there is no
backing for it in the cpp + qca isn't even looked for by cmake

Test Plan: none

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22618
2019-07-22 10:02:03 +02:00
David Edmundson
0e14ab6eca Remove deprecated tests
Summary:
Plasma::KPackage is deprecated in favour of KPackage.
There are much better tests there.

Storage is completely unused, no point testing it.

Test Plan: Compiles

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22611
2019-07-21 16:11:37 +02:00
Noah Davis
249365e327 Remove hardcoded colors (view.svg, system.svg) 2019-07-21 04:09:26 -04:00
Aleix Pol
f04584d423 Add missing components in org.kde.plasma.components 3.0
Summary:
These were created but never installed. Was looking into porting krunner
to 3.0 and they were missing.

Test Plan: Used them in the WIP port of KRunner

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22546
2019-07-19 16:16:19 +02:00