Summary:
These were super useful for spotting bugs in PC2.
They show many many issues already.
Visually they should match PC2. They don't
Some API doesn't map directly. Those tests
were removed.
Test Plan:
Opened in qmlscene
Everything binds correctly. Some things look horrible.
Reviewers: #plasma
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23827
Summary:
Indicate state, not the action it will have. When the password field is empty it feels like the password will be shown once I start typing. Dolphin has been doing it this way for the "show hidden files" action forever.
Also only show the button when the field contains text or when revealing the password, like in the PolKit dialog.
Test Plan:
Empty field
{F7326288}
{F5697017}
{F5697018}
Dolphin
Show hidden files, files are currently hidden
{F5697031}
Hide hidden files, files are currently shown
{F5697032}
Reviewers: #plasma, #vdg, ngraham, broulik, ndavis
Reviewed By: #vdg, ngraham, ndavis
Subscribers: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel
Tags: #plasma, #frameworks
Differential Revision: https://phabricator.kde.org/D10362
Summary:
Deleting AppletPrivate will delete the ConfigLoader which will cause a
save, which can trigger a configSaved signal.
I think it is correct that the config might emit a signal just before
closing, and not at fault.
AppletPrivate is deleted by this point, but Applet is not so the
connection is still alive.
When we handle the signal, it goes into a Q_PRIVATE_SLOT that crashes.
This disconnect pattern is already used for guarding self config
changes.
BUG: 411221
Test Plan: kquitapp5 plasmashell, no longer crashes
Reviewers: #plasma, alexeymin
Reviewed By: alexeymin
Subscribers: alexeymin, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23707
Summary: It's using some API that isn't available
Test Plan: Noise gone
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23587
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height if those props are set.
Before patch:
{F7274098}
After patch:
{F7274097}
Reviewers: #plasma, mart, ngraham
Reviewed By: #plasma, mart, ngraham
Subscribers: broulik, apol, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23367
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height if those props are set.
Before patch:
{F7274098}
After patch:
{F7274097}
Reviewers: #plasma, mart, ngraham
Reviewed By: ngraham
Subscribers: apol, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23367
Summary:
with the Plasma style buttons which have an icon look wrong. The icon size is too big and in consecuence the whole button is drawn way too big.
With this patch the icon is set to a standard size and drawn in the button layout, in a way it looks consistent with other button with no icons.
example:
Before path:
{F7270612}
{F7270611}
With patch:
{F7270610}
{F7270609}
BUG: 399952
FIXED-IN: 5.62
Reviewers: #plasma, mart, ngraham
Reviewed By: ngraham
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23352
Summary:
This is needed so that we don't remove the splash till the wallpaper is
loaded, but also allows doing this in a generic way.
Version 2 of the patch using a normal property.
We need to have the virtual so that the containment waits for the
wallpaper.
Test Plan:
Used with wallpaper patch
Added debug to ensure it happened after the stackview in the wallpaper
is pushed
Reviewers: #plasma
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22852
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.
BUG: 395390
FIXED-IN: 5.62
Reviewers: #plasma, ngraham, hein
Reviewed By: #plasma, ngraham, hein
Subscribers: kde-frameworks-devel
Tags: #frameworks
Maniphest Tasks: T10047
Differential Revision: https://phabricator.kde.org/D23036
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.
BUG: 395390
FIXED-IN: 5.62
Reviewers: #plasma, ngraham, hein
Reviewed By: #plasma, ngraham, hein
Subscribers: kde-frameworks-devel
Tags: #frameworks
Maniphest Tasks: T10047
Differential Revision: https://phabricator.kde.org/D23036
This is a remnant from when we used a full background on hovered ToolButtons
instead of the frame we have now. It broke icon item appearance when hovered
in a custom ColorScope.
Reviewed-By: notmart
Summary: Relevant code is moved from dialognativetest into a header for sharing
Test Plan: Unit test
Reviewers: #plasma
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22732
Summary:
Match the duration (2 seconds) that was set in D22630.
This style is mainly used by Plasma Mobile, therefore requesting team review from that project as well.
Reviewers: #vdg, #plasma:_mobile, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22720
Summary: This means they're found by unit tests pre-installation
Test Plan:
Removed installed files
Ran make (but not make install)
ConfigModelTest now passes
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22682
Summary: Changed Highlight to Button focus so that these SVGs wouldn't use the same color as the selection background.
Reviewers: #vdg, #plasma, #breeze, ngraham
Reviewed By: #vdg, #breeze, ngraham
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22670
Summary:
Some applets use completely the code of another one with the key
X-Plasma-RootPath.
At the moment it doesn't work on applets that have a binary plugin portion
This makes pluginloader load the plugin of the original applet we're using
Test Plan:
an applet that falls back to one that has a binary plugin now works.
ones that fall back to applets without binary plugin still work
normal applets as well
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22675
Summary: Match the duration (2 seconds) that was set in D22630.
Reviewers: broulik, #vdg
Reviewed By: broulik
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22646
Summary:
can't be enabled anywhere + not actually doing anything as there is no
backing for it in the cpp + qca isn't even looked for by cmake
Test Plan: none
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22618
Summary:
Plasma::KPackage is deprecated in favour of KPackage.
There are much better tests there.
Storage is completely unused, no point testing it.
Test Plan: Compiles
Reviewers: #plasma
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22611
Summary:
These were created but never installed. Was looking into porting krunner
to 3.0 and they were missing.
Test Plan: Used them in the WIP port of KRunner
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22546
